NetBSD Problem Report #55455

From www@netbsd.org  Fri Jul  3 19:08:43 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 8A3A51A9217
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  3 Jul 2020 19:08:43 +0000 (UTC)
Message-Id: <20200703190842.7D9941A9218@mollari.NetBSD.org>
Date: Fri,  3 Jul 2020 19:08:42 +0000 (UTC)
From: mcbig@zeropage.cz
Reply-To: mcbig@zeropage.cz
To: gnats-bugs@NetBSD.org
Subject: No gir file in gtkspell3
X-Send-Pr-Version: www-1.0

>Number:         55455
>Category:       pkg
>Synopsis:       No gir file in gtkspell3
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          feedback
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 03 19:10:00 +0000 2020
>Closed-Date:    
>Last-Modified:  Fri Jul 10 06:15:01 +0000 2020
>Originator:     Ond&#345;ej T&#367;ma
>Release:        current 2020-07-03
>Organization:
>Environment:
NetBSD localhost 8.1 NetBSD 8.1 (GENERIC) #0: Fri May 31 08:43:59 UTC 2019  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64

>Description:
gtkspell3 package does not have gobject itrospection files, so it could not be used in python for example.

I send a patch which i crate with inspiration in gtksourceview package. Now, package contains gir file by default and it could be used in other programming language.
>How-To-Repeat:

>Fix:
? work
cvs diff: Diffing .
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/gtkspell3/Makefile,v
retrieving revision 1.10
diff -u -r1.10 Makefile
--- Makefile    20 Mar 2020 11:58:26 -0000      1.10
+++ Makefile    3 Jul 2020 19:00:10 -0000
@@ -1,7 +1,7 @@
 # $NetBSD: Makefile,v 1.10 2020/03/20 11:58:26 nia Exp $

 DISTNAME=      gtkspell3-3.0.10
-PKGREVISION=   4
+PKGREVISION=   5
 CATEGORIES=    textproc devel
 MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=gtkspell/}
 EXTRACT_SUFX=  .tar.xz
@@ -17,6 +17,21 @@
 PKGCONFIG_OVERRIDE=    gtkspell-3.0.pc.in
 CONFIGURE_ARGS+=       --disable-gtk-doc

+PKG_OPTIONS_VAR=       PKG_OPTIONS.gtkspell3
+PKG_SUPPORTED_OPTIONS= introspection
+PKG_SUGGESTED_OPTIONS= introspection
+PLIST_VARS+=           introspection
+
+.include "../../mk/bsd.options.mk"
+
+.if !empty(PKG_OPTIONS:Mintrospection)
+PLIST.introspection=   yes
+BUILDLINK_API_DEPENDS.gobject-introspection+=  gobject-introspection>=1.42.0
+.include "../../devel/gobject-introspection/buildlink3.mk"
+.else
+CONFIGURE_ARGS+=       --enable-introspection=no
+.endif
+
 .include "../../textproc/enchant2/buildlink3.mk"
 .include "../../x11/gtk3/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/gtkspell3/PLIST,v
retrieving revision 1.2
diff -u -r1.2 PLIST
--- PLIST       13 Nov 2018 13:33:29 -0000      1.2
+++ PLIST       3 Jul 2020 19:00:10 -0000
@@ -1,7 +1,9 @@
-@comment $NetBSD: PLIST,v 1.2 2018/11/13 13:33:29 bsiegert Exp $
+@comment $NetBSD$
 include/gtkspell-3.0/gtkspell/gtkspell.h
+lib/girepository-1.0/GtkSpell-3.0.typelib
 lib/libgtkspell3-3.la
 lib/pkgconfig/gtkspell3-3.0.pc
+share/gir-1.0/GtkSpell-3.0.gir
 share/gtk-doc/html/gtkspell3/annotation-glossary.html
 share/gtk-doc/html/gtkspell3/api-index-full.html
 share/gtk-doc/html/gtkspell3/ch02.html

>Release-Note:

>Audit-Trail:
From: Leonardo Taccari <leot@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/55455: No gir file in gtkspell3
Date: Fri, 03 Jul 2020 22:39:12 +0200

 Hello!
 A couple of suggested changes directly inline.

 mcbig@zeropage.cz writes:
 > [...]
 > >Fix:
 > ? work
 > cvs diff: Diffing .
 > Index: Makefile
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/textproc/gtkspell3/Makefile,v
 > retrieving revision 1.10
 > diff -u -r1.10 Makefile
 > --- Makefile    20 Mar 2020 11:58:26 -0000      1.10
 > +++ Makefile    3 Jul 2020 19:00:10 -0000
 > @@ -1,7 +1,7 @@
 >  # $NetBSD: Makefile,v 1.10 2020/03/20 11:58:26 nia Exp $
 >  
 >  DISTNAME=      gtkspell3-3.0.10
 > -PKGREVISION=   4
 > +PKGREVISION=   5
 >  CATEGORIES=    textproc devel
 >  MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=gtkspell/}
 >  EXTRACT_SUFX=  .tar.xz
 > @@ -17,6 +17,21 @@
 >  PKGCONFIG_OVERRIDE=    gtkspell-3.0.pc.in
 >  CONFIGURE_ARGS+=       --disable-gtk-doc
 >  
 > +PKG_OPTIONS_VAR=       PKG_OPTIONS.gtkspell3
 > +PKG_SUPPORTED_OPTIONS= introspection
 > +PKG_SUGGESTED_OPTIONS= introspection
 > +PLIST_VARS+=           introspection
 > +
 > +.include "../../mk/bsd.options.mk"
 > +
 > +.if !empty(PKG_OPTIONS:Mintrospection)
 > +PLIST.introspection=   yes
 > +BUILDLINK_API_DEPENDS.gobject-introspection+=  gobject-introspection>=1.42.0
 > +.include "../../devel/gobject-introspection/buildlink3.mk"
 > +.else
 > +CONFIGURE_ARGS+=       --enable-introspection=no
 > +.endif
 > +
 > [...]

 Only cosmetic: it would be better to move all the option logic in a
 separate options.mk file in order to separate the logic regarding
 options in a separate file.

 Can you please also use `--disable-introspection' instead of
 `--enable-introspection=no' (it is easier to read) and explicitly also
 pass `--enable-introspection' (so if for any reason the option could not
 be enabled it should fail to build instead of silently disable
 introspection support)?

 > Index: PLIST
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/textproc/gtkspell3/PLIST,v
 > retrieving revision 1.2
 > diff -u -r1.2 PLIST
 > --- PLIST       13 Nov 2018 13:33:29 -0000      1.2
 > +++ PLIST       3 Jul 2020 19:00:10 -0000
 > @@ -1,7 +1,9 @@
 > -@comment $NetBSD: PLIST,v 1.2 2018/11/13 13:33:29 bsiegert Exp $
 > +@comment $NetBSD$
 >  include/gtkspell-3.0/gtkspell/gtkspell.h
 > +lib/girepository-1.0/GtkSpell-3.0.typelib
 >  lib/libgtkspell3-3.la
 >  lib/pkgconfig/gtkspell3-3.0.pc
 > +share/gir-1.0/GtkSpell-3.0.gir
 > [...]

 I think that both new entries are missing a ${PLIST.introspection},
 please add it.

State-Changed-From-To: open->feedback
State-Changed-By: leot@NetBSD.org
State-Changed-When: Fri, 03 Jul 2020 21:16:52 +0000
State-Changed-Why:
Changes requested


From: =?UTF-8?B?T25kxZllaiBUxa9tYQ==?= <mcbig@zeropage.cz>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/55455: No gir file in gtkspell3
Date: Fri, 10 Jul 2020 08:10:06 +0200

 --Sig_/IM2=vj+ByV77OvJUV/63=AP
 Content-Type: multipart/mixed; boundary="MP_/nhYyxpmLYcp4P5EvLiqWnAH"

 --MP_/nhYyxpmLYcp4P5EvLiqWnAH
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: inline

 Hi,

 second try in attachment with your comments :-)

 V Fri,  3 Jul 2020 20:40:02 +0000 (UTC)
 Leonardo Taccari <leot@NetBSD.org> naps=C3=A1no:

 >  Hello!
 >  A couple of suggested changes directly inline.

 --=20
 Ond=C5=99ej T=C5=AFma <mcbig@zeropage.cz>
 https://ipv6.mcbig.cz     https://keybase.io/mcbig    twitter: mcbig_cz

 --MP_/nhYyxpmLYcp4P5EvLiqWnAH
 Content-Type: text/x-patch
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: attachment; filename=introspection.patch

 Index: Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/textproc/gtkspell3/Makefile,v
 retrieving revision 1.10
 diff -u -p -r1.10 Makefile
 --- Makefile	20 Mar 2020 11:58:26 -0000	1.10
 +++ Makefile	10 Jul 2020 06:05:41 -0000
 @@ -1,7 +1,7 @@
  # $NetBSD: Makefile,v 1.10 2020/03/20 11:58:26 nia Exp $
 =20
  DISTNAME=3D	gtkspell3-3.0.10
 -PKGREVISION=3D	4
 +PKGREVISION=3D	5
  CATEGORIES=3D	textproc devel
  MASTER_SITES=3D	${MASTER_SITE_SOURCEFORGE:=3Dgtkspell/}
  EXTRACT_SUFX=3D	.tar.xz
 @@ -17,6 +17,8 @@ GNU_CONFIGURE=3D		yes
  PKGCONFIG_OVERRIDE=3D	gtkspell-3.0.pc.in
  CONFIGURE_ARGS+=3D	--disable-gtk-doc
 =20
 +.include "options.mk"
 +
  .include "../../textproc/enchant2/buildlink3.mk"
  .include "../../x11/gtk3/buildlink3.mk"
  .include "../../mk/bsd.pkg.mk"
 Index: PLIST
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/textproc/gtkspell3/PLIST,v
 retrieving revision 1.2
 diff -u -p -r1.2 PLIST
 --- PLIST	13 Nov 2018 13:33:29 -0000	1.2
 +++ PLIST	10 Jul 2020 06:05:41 -0000
 @@ -1,7 +1,9 @@
 -@comment $NetBSD: PLIST,v 1.2 2018/11/13 13:33:29 bsiegert Exp $
 +@comment $NetBSD$
  include/gtkspell-3.0/gtkspell/gtkspell.h
 +${PLIST.introspection}lib/girepository-1.0/GtkSpell-3.0.typelib
  lib/libgtkspell3-3.la
  lib/pkgconfig/gtkspell3-3.0.pc
 +${PLIST.introspection}share/gir-1.0/GtkSpell-3.0.gir
  share/gtk-doc/html/gtkspell3/annotation-glossary.html
  share/gtk-doc/html/gtkspell3/api-index-full.html
  share/gtk-doc/html/gtkspell3/ch02.html
 Index: options.mk
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: options.mk
 diff -N options.mk
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ options.mk	10 Jul 2020 06:05:41 -0000
 @@ -0,0 +1,26 @@
 +# $NetBSD: options.mk,v 1.21 2020/03/10 18:14:04 leot Exp $
 +#
 +
 +PKG_OPTIONS_VAR=3D	PKG_OPTIONS.gtkspell3
 +PKG_SUPPORTED_OPTIONS=3D	introspection
 +PKG_SUGGESTED_OPTIONS=3D	introspection
 +
 +PLIST_VARS=3D	introspection
 +
 +.include "../../mk/bsd.options.mk"
 +
 +#
 +# Introspection
 +#
 +.if !empty(PKG_OPTIONS:Mintrospection)
 +PLIST.introspection=3D				yes
 +BUILDLINK_API_DEPENDS.gobject-introspection+=3D	gobject-introspection>=3D1=
 .42.0
 +BUILDLINK_DEPMETHOD.gobject-introspection+=3D	build
 +
 +.include "../../devel/gobject-introspection/buildlink3.mk"
 +
 +CONFIGURE_ARGS+=3D	--enable-introspection
 +.else
 +CONFIGURE_ARGS+=3D	--disable-introspection
 +.endif
 +

 --MP_/nhYyxpmLYcp4P5EvLiqWnAH--

 --Sig_/IM2=vj+ByV77OvJUV/63=AP
 Content-Type: application/pgp-signature
 Content-Description: Digitální podpis OpenPGP

 -----BEGIN PGP SIGNATURE-----

 iQIzBAEBCgAdFiEEdlj+NNFMWaEf/Gl1Bd+niyV86poFAl8IBj4ACgkQBd+niyV8
 6prwuhAA5Q0AfpG1Ol5beWU/Oh2IddTZQFqPMRWeVGh+okooNX3w12H2/rTP1pxE
 k2DZr3xUwChUWBdRmQ9tPBAEb158XY7h827gbRYfL8H9FSomBhC4CoXbGbdNdpaQ
 4DVISdBSn9ic5/WmcMRmRYkZ5zdkfcA+lAO9s5XlF/VjfvJaGTHGgQ4NA2FCNDNP
 AEDdn/WYhD9MDOOdDauzlWe+ubc0y5mcUkCwiCTMsGnSuwb8srSCUt5Z/nbbY52D
 3+VPSfIfadp5k+ZSFtV9IYDkGXzIMHVZ7/6J9lvf9kKfwvWQah4BWDFQmOoBEycJ
 bWEWNxWxILpt7X7sgkWBBb1AeWN6Wt9uUh7Itr/38MF5ZHBDVt9pEHv0iN0z8O2d
 KhxSTHJq70cXEmv5oH1xxmVAjS2aBtlb7jefCUwL2dllzSueaywLNWMe66+5tkjl
 HcVTj1/Uf9ub0ZEU8McYEV9jYyPS0u5SKT7VjarQeWzuHniujtrRnmle6i3XHy55
 Qqhfpnq7ayDhVfCYmPJRJlzq0FrRxqxnduHq/QKfhEPMvqxs/e5kMJk3O4aLGIIe
 JH3RSif3MjcpIqMoser64ofvFOssM/ZWGEgHjF0oB41gKzHCpwdrsjO9T6MGVE+3
 iUSdEBZhtM6ShuLc7ySW5KP2POV9v/suM2hj3PqzPoENonL/W/8=
 =Iht2
 -----END PGP SIGNATURE-----

 --Sig_/IM2=vj+ByV77OvJUV/63=AP--

>Unformatted:

Home	PR Database Search