NetBSD Problem Report #55495

From www@netbsd.org  Fri Jul 17 04:59:02 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 278E31A9213
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 17 Jul 2020 04:59:02 +0000 (UTC)
Message-Id: <20200717045900.ECF3A1A921E@mollari.NetBSD.org>
Date: Fri, 17 Jul 2020 04:59:00 +0000 (UTC)
From: schaecsn@gmx.net
Reply-To: schaecsn@gmx.net
To: gnats-bugs@NetBSD.org
Subject: xfig dependency on netpbm
X-Send-Pr-Version: www-1.0

>Number:         55495
>Category:       pkg
>Synopsis:       xfig dependency on netpbm
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 17 05:00:00 +0000 2020
>Last-Modified:  Sat Jul 18 19:25:01 +0000 2020
>Originator:     Stefan Schaeckeler
>Release:        NetBSD 9.0 / pkgsrc-2020Q2
>Organization:
>Environment:
NetBSD XXX 9.0 NetBSD 9.0 (GENERIC) #0: Fri Feb 14 00:06:28 UTC 2020  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64

>Description:
Building graphics/xfig silently fails on missing pgmtopbm, pbmtoxbm and ppmtopgm resulting in an empty splash.xbm file.

--- w_library.o ---
depbase=`echo w_library.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/X11R7/include  -DXAW_INTERNATIONALIZATION -DNDEBUG -DXFIGLIBDIR="\"/usr/local/share/xfig\""  -DOBJLIBDIR="\"/usr/local/share/xfig/Libraries\"" -DXFIGDOCDIR="\"/usr/local/share/doc/xfig\""  -I/usr/local/include -I/usr/include -I/usr/X11R7/include  -march=native -O2 -pipe -D_FORTIFY_SOURCE=2 -I/usr/local/include -I/usr/include -I/usr/X11R7/include -MT w_library.o -MD -MP -MF $depbase.Tpo -c -o w_library.o w_library.c && mv -f $depbase.Tpo $depbase.Po
--- splash.xbm ---
Error in ghostcript or netpbm command
command was: gs -q -dSAFER -r80 -g631x211 -dTextAlphaBits=4 -dGraphicsAlphaBits=4 -sDEVICE=ppmraw -o - - | { ppmtopgm | pgmtopbm | pbmtoxbm; } 2>/var/tmp//f2derrorUsoN2I
Messages resulting:
  sh: pgmtopbm: not found
  sh: pbmtoxbm: not found
  sh: ppmtopgm: not found
--- w_listwidget.o ---
depbase=`echo w_listwidget.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/X11R7/include  -DXAW_INTERNATIONALIZATION -DNDEBUG -DXFIGLIBDIR="\"/usr/local/share/xfig\""  -DOBJLIBDIR="\"/usr/local/share/xfig/Libraries\"" -DXFIGDOCDIR="\"/usr/local/share/doc/xfig\""  -I/usr/local/include -I/usr/include -I/usr/X11R7/include  -march=native -O2 -pipe -D_FORTIFY_SOURCE=2 -I/usr/local/include -I/usr/include -I/usr/X11R7/include -MT w_listwidget.o -MD -MP -MF $depbase.Tpo -c -o w_listwidget.o w_listwidget.c && mv -f $depbase.Tpo $depbase.Po
--- w_modepanel.o ---



The picture file splash.xbm includes interestingly some #defines now not found in w_icons.c:

--- w_icons.o ---
depbase=`echo w_icons.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; gcc -DHAVE_CONFIG_H -I. -I..  -I/usr/X11R7/include  -DXAW_INTERNATIONALIZATION -DNDEBUG -DXFIGLIBDIR="\"/usr/local/share/xfig\""  -DOBJLIBDIR="\"/usr/local/share/xfig/Libraries\"" -DXFIGDOCDIR="\"/usr/local/share/doc/xfig\""  -I/usr/local/include -I/usr/include -I/usr/X11R7/include  -march=native -O2 -pipe -D_FORTIFY_SOURCE=2 -I/usr/local/include -I/usr/include -I/usr/X11R7/include -MT w_icons.o -MD -MP -MF $depbase.Tpo -c -o w_icons.o w_icons.c && mv -f $depbase.Tpo $depbase.Po
w_icons.c:3242:31: error: 'spl_bckgnd_width' undeclared here (not in a function); did you mean 'spl_bckgnd_ic'?
 icon_struct spl_bckgnd_ic = { spl_bckgnd_width, spl_bckgnd_height,
                               ^~~~~~~~~~~~~~~~
                               spl_bckgnd_ic
w_icons.c:3242:49: error: 'spl_bckgnd_height' undeclared here (not in a function); did you mean 'spl_bckgnd_width'?
 icon_struct spl_bckgnd_ic = { spl_bckgnd_width, spl_bckgnd_height,
                                                 ^~~~~~~~~~~~~~~~~
                                                 spl_bckgnd_width
w_icons.c:3243:17: error: 'spl_bckgnd_bits' undeclared here (not in a function); did you mean 'spl_bckgnd_width'?
          (char*)spl_bckgnd_bits };
                 ^~~~~~~~~~~~~~~
                 spl_bckgnd_width
>How-To-Repeat:
uninstall graphics/netpbm and build graphics/xfig.
>Fix:
Index: graphics/xfig/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/xfig/Makefile,v
retrieving revision 1.78
diff -u -p -r1.78 Makefile
--- graphics/xfig/Makefile      30 May 2020 18:11:22 -0000      1.78
+++ graphics/xfig/Makefile      17 Jul 2020 04:25:03 -0000
@@ -11,6 +11,8 @@ COMMENT=      CAD-like 2D drawing tool, good 
 # not completely, but near enough
 LICENSE=       mit

+BUILD_DEPENDS+=        netpbm-[0-9]*:../../graphics/netpbm
+
 DEPENDS+=      fig2dev-[0-9]*:../../print/fig2dev

 XAW_TYPE?=             3d

>Audit-Trail:
From: Stefan Schaeckeler <schaecsn@gmx.net>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/55495: xfig dependency on netpbm
Date: Sat, 18 Jul 2020 12:21:41 -0700 (PDT)

 I was wrong. The xfig build calls fig2dev which in turn calls pgmtopbm, pb=
 mtoxbm and ppmtopgm.

 $ fig2dev -L xbm -S 4 xfig-3.2.7b/splash-image/spl_bckgnd.fig
 Error in ghostcript or netpbm command
 command was: gs -q -dSAFER -r80 -g631x211 -dTextAlphaBits=3D4 -dGraphicsAl=
 phaBits=3D4 -sDEVICE=3Dppmraw -o - - | { ppmtopgm | pgmtopbm | pbmtoxbm; }=
  2>/var/tmp//f2derrorx8Ote1
 Messages resulting:
   sh: pgmtopbm: not found
   sh: pbmtoxbm: not found
   sh: ppmtopgm: not found

 So, there should be a patch against fig2dev only

 Index: print/fig2dev/Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/print/fig2dev/Makefile,v
 retrieving revision 1.6
 diff -u -p -r1.6 Makefile
 =2D-- print/fig2dev/Makefile      16 May 2020 02:15:06 -0000      1.6
 +++ print/fig2dev/Makefile      18 Jul 2020 19:08:41 -0000
 @@ -16,6 +16,7 @@ LDFLAGS.SunOS+=3D       -liconv

  USE_TOOLS+=3D    gs:run

 +.include "../../graphics/netpbm/buildlink3.mk"
  .include "../../graphics/png/buildlink3.mk"
  .include "../../converters/libiconv/buildlink3.mk"
  .include "../../x11/libXpm/buildlink3.mk"


 Note, xfig's src/Makefile needs pgmtopbm, pbmtoxbm and ppmtopgm for target=
  version.xbm. version.xbm is already bundled with xfig and is not (re-)gen=
 erated during a pkgsrc build. So, xfig does not need a dependency on netpb=
 m.

Home	PR Database Search