NetBSD Problem Report #55688

From www@netbsd.org  Wed Sep 30 01:14:17 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 8114A1A9217
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 30 Sep 2020 01:14:17 +0000 (UTC)
Message-Id: <20200930011416.5D21A1A923F@mollari.NetBSD.org>
Date: Wed, 30 Sep 2020 01:14:16 +0000 (UTC)
From: juliensavard17@gmail.com
Reply-To: juliensavard17@gmail.com
To: gnats-bugs@NetBSD.org
Subject: OpenSSL 1.1.1 fails to compile on Solaris 10
X-Send-Pr-Version: www-1.0

>Number:         55688
>Category:       pkg
>Synopsis:       OpenSSL 1.1.1 fails to compile on Solaris 10
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    solaris-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 30 01:15:00 +0000 2020
>Closed-Date:    Fri Oct 16 05:06:58 +0000 2020
>Last-Modified:  Fri Dec 11 08:55:02 +0000 2020
>Originator:     Julien Savard
>Release:        pkgsrc2020Q1 and up
>Organization:
None
>Environment:
SunOS zone3 5.10 Generic_150400-58 sun4u sparc SUNW,UltraAX-i2
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/opt/gcc-8.3.0/libexec/gcc/sparc-sun-solaris2.10/8.3.0/lto-wrapper
Target: sparc-sun-solaris2.10
Configured with: /usr/local/gcc-8.3.0/configure --prefix=/opt/gcc-8.3.0 --enable-languages=c,c++,fortran,go : (reconfigured) /usr/local/gcc-8.3.0/configure --prefix=/opt/gcc-8.3.0 --enable-languages=c,c++ : (reconfigured) /usr/local/gcc-8.3.0/configure --prefix=/opt/gcc-8.3.0 --enable-languages=c,c++,fortran
Thread model: posix
gcc version 8.3.0 (GCC)

>Description:
OpenSSL Fails to compile on Solaris 10 :

===> Building for openssl-1.1.1gnb1
/usr/sfw/bin/gmake depend && /usr/sfw/bin/gmake _all
gmake[1]: Entering directory `/var/tmp/pkgbuild/security/openssl/work/openssl-1.1.1g'
gmake[1]: Leaving directory `/var/tmp/pkgbuild/security/openssl/work/openssl-1.1.1g'
gmake[1]: Entering directory `/var/tmp/pkgbuild/security/openssl/work/openssl-1.1.1g'
gcc -fPIC -m32 -mcpu=ultrasparc -pthread -O2 -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -O2 -O2 -L. -shared -Wl,-Bsymbolic  -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/l
ib -Wl,-h,libssl.so.1.1 \
        -o libssl.so.1.1 -Wl,-M,libssl.map ssl/bio_ssl.o ssl/d1_lib.o ssl/d1_msg.o ssl/d1_srtp.o ssl/methods.o ssl/packet.o ssl/pqueue.o ssl/record/dtls1_bitmap.o ssl/record/rec_layer_d1.o ssl/record/rec_lay
er_s3.o ssl/record/ssl3_buffer.o ssl/record/ssl3_record.o ssl/record/ssl3_record_tls13.o ssl/s3_cbc.o ssl/s3_enc.o ssl/s3_lib.o ssl/s3_msg.o ssl/ssl_asn1.o ssl/ssl_cert.o ssl/ssl_ciph.o ssl/ssl_conf.o ssl/ss
l_err.o ssl/ssl_init.o ssl/ssl_lib.o ssl/ssl_mcnf.o ssl/ssl_rsa.o ssl/ssl_sess.o ssl/ssl_stat.o ssl/ssl_txt.o ssl/ssl_utst.o ssl/statem/extensions.o ssl/statem/extensions_clnt.o ssl/statem/extensions_cust.o
ssl/statem/extensions_srvr.o ssl/statem/statem.o ssl/statem/statem_clnt.o ssl/statem/statem_dtls.o ssl/statem/statem_lib.o ssl/statem/statem_srvr.o ssl/t1_enc.o ssl/t1_lib.o ssl/t1_trce.o ssl/tls13_enc.o ssl
/tls_srp.o \
                 -lcrypto -lsocket -lnsl -ldl -pthread
gcc -fPIC -m32 -mcpu=ultrasparc -pthread -O2 -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -O2 -O2 -L. -shared -Wl,-Bsymbolic  -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/l
ib \
        -o engines/capi.so engines/e_capi.o \
                 -lcrypto -lsocket -lnsl -ldl -pthread
gcc -fPIC -m32 -mcpu=ultrasparc -pthread -O2 -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -O2 -O2 -L. -shared -Wl,-Bsymbolic  -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/l
ib \
        -o engines/dasync.so engines/e_dasync.o \
                 -lcrypto -lsocket -lnsl -ldl -pthread
gcc -fPIC -m32 -mcpu=ultrasparc -pthread -O2 -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -O2 -O2 -L. -shared -Wl,-Bsymbolic  -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/l
ib \
        -o engines/ossltest.so engines/e_ossltest.o \
                 -lcrypto -lsocket -lnsl -ldl -pthread
gcc -fPIC -m32 -mcpu=ultrasparc -pthread -O2 -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -O2 -O2 -L. -shared -Wl,-Bsymbolic  -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/l
ib \
        -o engines/padlock.so engines/e_padlock.o \
                 -lcrypto -lsocket -lnsl -ldl -pthread
rm -f fuzz/asn1parse-test
${LDCMD:-gcc} -m32 -mcpu=ultrasparc -pthread -O2 -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -O2 -O2 -L.  -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib \
        -o fuzz/asn1parse-test fuzz/asn1parse.o fuzz/test-corpus.o \
         -lcrypto -lsocket -lnsl -ldl -pthread
if [ 'libssl.so' != 'libssl.so.1.1' ]; then \
        rm -f libssl.so; \
        ln -s libssl.so.1.1 libssl.so; \
fi
gmake[1]: Leaving directory `/var/tmp/pkgbuild/security/openssl/work/openssl-1.1.1g'
*** Error code 2

Stop.
bmake[1]: stopped in /srv/pkgsrc/security/openssl
*** Error code 1

Stop.
bmake: stopped in /srv/pkgsrc/security/openssl

>How-To-Repeat:
bootstrap pkgsrc and run "bmake package" in security/openssl
>Fix:
It seems it is a known issue by the OpenSSL team: 
https://www.mail-archive.com/openssl-users@openssl.org/msg87889.html

So as stated by the OpenSSL team, the quick fix would be to add the following line to your pkgsrc OpenSSL Makefile :

LDFLAGS+=               -lrt

I can confirm it works

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Wed, 30 Sep 2020 17:54:59 +0000
Responsible-Changed-Why:
A Solaris problem.


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55688 CVS commit: pkgsrc/security/openssl
Date: Tue, 13 Oct 2020 07:37:29 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Tue Oct 13 07:37:29 UTC 2020

 Modified Files:
 	pkgsrc/security/openssl: Makefile

 Log Message:
 openssl: add -lrt for the benefit of Solaris 10.

 PR pkg/55688
 PR pkg/54958


 To generate a diff of this commit:
 cvs rdiff -u -r1.264 -r1.265 pkgsrc/security/openssl/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Fri, 16 Oct 2020 05:06:58 +0000
State-Changed-Why:
Applied a variation of this. Please let me know if something went wrong (or not) and the package failed. Thanks.


From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55688 CVS commit: [pkgsrc-2020Q3] pkgsrc/security/openssl
Date: Fri, 11 Dec 2020 08:50:56 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Fri Dec 11 08:50:56 UTC 2020

 Modified Files:
 	pkgsrc/security/openssl [pkgsrc-2020Q3]: Makefile PLIST distinfo
 Removed Files:
 	pkgsrc/security/openssl/patches [pkgsrc-2020Q3]:
 	    patch-Configurations_10-main.conf patch-crypto_rand_rand__unix.c

 Log Message:
 Pullup ticket #6384 - requested by wiz
 security/openssl: security fix

 Revisions pulled up:
 - security/openssl/Makefile                                     1.264-1.266
 - security/openssl/PLIST                                        1.7
 - security/openssl/distinfo                                     1.146-1.147
 - security/openssl/patches/patch-Configurations_10-main.conf    deleted
 - security/openssl/patches/patch-crypto_rand_rand__unix.c       deleted

 ---
    Module Name:	pkgsrc
    Committed By:	wiz
    Date:		Wed Sep 30 09:25:31 UTC 2020

    Modified Files:
    	pkgsrc/security/openssl: Makefile PLIST distinfo
    Removed Files:
    	pkgsrc/security/openssl/patches: patch-crypto_rand_rand__unix.c

    Log Message:
    openssl: update to 1.1.1h.

      Major changes between OpenSSL 1.1.1g and OpenSSL 1.1.1h [22 Sep 2020]

          o Disallow explicit curve parameters in verifications chains when
            X509_V_FLAG_X509_STRICT is used
          o Enable 'MinProtocol' and 'MaxProtocol' to configure both TLS and DTLS
            contexts
          o Oracle Developer Studio will start reporting deprecation warnings

 ---
    Module Name:	pkgsrc
    Committed By:	maya
    Date:		Tue Oct 13 07:37:29 UTC 2020

    Modified Files:
    	pkgsrc/security/openssl: Makefile

    Log Message:
    openssl: add -lrt for the benefit of Solaris 10.

    PR pkg/55688
    PR pkg/54958

 ---
    Module Name:	pkgsrc
    Committed By:	wiz
    Date:		Tue Dec  8 18:54:17 UTC 2020

    Modified Files:
    	pkgsrc/security/openssl: Makefile distinfo
    Removed Files:
    	pkgsrc/security/openssl/patches: patch-Configurations_10-main.conf

    Log Message:
    openssl: update to 1.1.1i.

      Major changes between OpenSSL 1.1.1h and OpenSSL 1.1.1i [8 Dec 2020]

          o Fixed NULL pointer deref in GENERAL_NAME_cmp (CVE-2020-1971)


 To generate a diff of this commit:
 cvs rdiff -u -r1.263 -r1.263.2.1 pkgsrc/security/openssl/Makefile
 cvs rdiff -u -r1.6 -r1.6.2.1 pkgsrc/security/openssl/PLIST
 cvs rdiff -u -r1.144.2.1 -r1.144.2.2 pkgsrc/security/openssl/distinfo
 cvs rdiff -u -r1.1 -r0 \
     pkgsrc/security/openssl/patches/patch-Configurations_10-main.conf \
     pkgsrc/security/openssl/patches/patch-crypto_rand_rand__unix.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search