NetBSD Problem Report #55710

From kimmo@suominen.org  Sat Oct 10 11:41:06 2020
Return-Path: <kimmo@suominen.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D70121A9239
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 10 Oct 2020 11:41:06 +0000 (UTC)
Message-Id: <20201010114100.511C51B737@equinoxe.x.gw.fi>
Date: Sat, 10 Oct 2020 14:41:00 +0300 (EEST)
From: kim@netbsd.org (Kimmo Suominen)
To: gnats-bugs@NetBSD.org
Subject: Manual pages for ntp are stale
X-Send-Pr-Version: 3.95

>Number:         55710
>Category:       bin
>Synopsis:       Manual pages for ntp are stale
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 10 11:45:00 +0000 2020
>Closed-Date:    Wed Nov 04 21:45:57 +0000 2020
>Last-Modified:  Wed Nov 04 21:45:57 +0000 2020
>Originator:     Kimmo Suominen
>Release:        NetBSD 9.0_STABLE (202010080940Z)
>Organization:
>Environment:
System: NetBSD equinoxe.x.gw.fi 9.0_STABLE NetBSD 9.0_STABLE (GENERIC) #0: Sun Oct 4 18:24:07 UTC 2020 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
	Manual pages installed for the ntp software (ntpq, ntpd, etc.)
	are stale.  They are from 2013 instead of being from the
	imported ntp software (which is currently from 2018).
>How-To-Repeat:
	Read manual pages and notice they do not correspond to how
	the software works.
>Fix:
	Correctly generate manual pages from the dist/*/*.mdoc.in
	files and install those instead of maintaining separate copies
	parallel to dist.

	There are dist/*/*.1*mdoc (e.g. dist/ntpq/ntpq.1ntpqmdoc) files
	currently in the tree. The naming seems like an accident during
	generation before importing.

	Based on a comparison of the mdoc files in dist with those
	parallel to dist it looks like if the filenames and section
	numbers inside the files were generated correctly, they would
	be perfectly suitable for installing as the manual pages.

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55710 CVS commit: src/external/bsd/ntp/bin
Date: Sat, 10 Oct 2020 10:25:22 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Sat Oct 10 14:25:21 UTC 2020

 Removed Files:
 	src/external/bsd/ntp/bin/ntp-keygen: ntp-keygen.8
 	src/external/bsd/ntp/bin/ntpd: ntp.conf.5 ntp.keys.5 ntpd.8
 	src/external/bsd/ntp/bin/ntpdc: ntpdc.8
 	src/external/bsd/ntp/bin/ntpq: ntpq.8
 	src/external/bsd/ntp/bin/sntp: sntp.1

 Log Message:
 PR/55710: Kimmo Suominen: Delete manual pages so that they get copy from the
 imported, already generated ones.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r0 src/external/bsd/ntp/bin/ntp-keygen/ntp-keygen.8
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/ntpd/ntp.conf.5
 cvs rdiff -u -r1.2 -r0 src/external/bsd/ntp/bin/ntpd/ntp.keys.5 \
     src/external/bsd/ntp/bin/ntpd/ntpd.8
 cvs rdiff -u -r1.2 -r0 src/external/bsd/ntp/bin/ntpdc/ntpdc.8
 cvs rdiff -u -r1.2 -r0 src/external/bsd/ntp/bin/ntpq/ntpq.8
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/sntp/sntp.1

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Kimmo Suominen <kim@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: PR/55710 CVS commit: src/external/bsd/ntp/bin
Date: Sun, 11 Oct 2020 02:11:24 +0300

 pullup-9 #1109
 http://releng.netbsd.org/cgi-bin/req-9.cgi?show=1109

 pullup-8 #1616
 http://releng.netbsd.org/cgi-bin/req-8.cgi?show=1616

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55710 CVS commit: [netbsd-9] src/external/bsd/ntp
Date: Mon, 12 Oct 2020 10:17:34 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon Oct 12 10:17:33 UTC 2020

 Modified Files:
 	src/external/bsd/ntp [netbsd-9]: Makefile.inc
 	src/external/bsd/ntp/bin [netbsd-9]: Makefile.inc
 	src/external/bsd/ntp/bin/ntp-keygen [netbsd-9]: Makefile
 	src/external/bsd/ntp/bin/ntpd [netbsd-9]: Makefile
 	src/external/bsd/ntp/bin/ntpdc [netbsd-9]: Makefile
 	src/external/bsd/ntp/bin/ntpq [netbsd-9]: Makefile
 	src/external/bsd/ntp/bin/sntp [netbsd-9]: Makefile
 Removed Files:
 	src/external/bsd/ntp/bin/ntp-keygen [netbsd-9]: ntp-keygen.8
 	src/external/bsd/ntp/bin/ntpd [netbsd-9]: ntp.conf.5 ntp.keys.5 ntpd.8
 	src/external/bsd/ntp/bin/ntpdc [netbsd-9]: ntpdc.8
 	src/external/bsd/ntp/bin/ntpq [netbsd-9]: ntpq.8
 	src/external/bsd/ntp/bin/sntp [netbsd-9]: sntp.1

 Log Message:
 Pull up following revision(s) (requested by kim in ticket #1109):

 	external/bsd/ntp/bin/ntpq/ntpq.8: file removal
 	external/bsd/ntp/bin/Makefile.inc: revision 1.4
 	external/bsd/ntp/bin/ntpd/ntpd.8: file removal
 	external/bsd/ntp/bin/ntpq/Makefile: revision 1.9 (patch)
 	external/bsd/ntp/bin/ntpd/Makefile: revision 1.28 (patch)
 	external/bsd/ntp/bin/sntp/sntp.1: file removal
 	external/bsd/ntp/bin/ntpd/ntp.keys.5: file removal
 	external/bsd/ntp/bin/ntpd/ntp.conf.5: file removal
 	external/bsd/ntp/Makefile.inc: revision 1.20
 	external/bsd/ntp/Makefile.inc: revision 1.21
 	external/bsd/ntp/bin/sntp/Makefile: revision 1.8
 	external/bsd/ntp/bin/ntp-keygen/Makefile: revision 1.7 (patch)
 	external/bsd/ntp/bin/sntp/Makefile: revision 1.9 (patch)
 	external/bsd/ntp/bin/ntp-keygen/ntp-keygen.8: file removal
 	external/bsd/ntp/bin/ntpdc/ntpdc.8: file removal
 	external/bsd/ntp/bin/ntpdc/Makefile: revision 1.7 (patch)

 Fix build; clean manpages only if they are generated automatically.
 include bsd.own.mk so that ../../Makefile.inc does not do it...

 Add rules for manual pages builds, remove including Makefile.inc

 Use .PARSEDIR

 PR/55710: Kimmo Suominen: Delete manual pages so that they get copy from the
 imported, already generated ones.


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.18.2.1 src/external/bsd/ntp/Makefile.inc
 cvs rdiff -u -r1.3 -r1.3.56.1 src/external/bsd/ntp/bin/Makefile.inc
 cvs rdiff -u -r1.5 -r1.5.34.1 src/external/bsd/ntp/bin/ntp-keygen/Makefile
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/ntp-keygen/ntp-keygen.8
 cvs rdiff -u -r1.22 -r1.22.6.1 src/external/bsd/ntp/bin/ntpd/Makefile
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/ntpd/ntp.conf.5 \
     src/external/bsd/ntp/bin/ntpd/ntpd.8
 cvs rdiff -u -r1.2 -r0 src/external/bsd/ntp/bin/ntpd/ntp.keys.5
 cvs rdiff -u -r1.6 -r1.6.34.1 src/external/bsd/ntp/bin/ntpdc/Makefile
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/ntpdc/ntpdc.8
 cvs rdiff -u -r1.7 -r1.7.34.1 src/external/bsd/ntp/bin/ntpq/Makefile
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/ntpq/ntpq.8
 cvs rdiff -u -r1.6 -r1.6.34.1 src/external/bsd/ntp/bin/sntp/Makefile
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/sntp/sntp.1

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55710 CVS commit: [netbsd-8] src/external/bsd/ntp
Date: Mon, 12 Oct 2020 10:23:41 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon Oct 12 10:23:41 UTC 2020

 Modified Files:
 	src/external/bsd/ntp [netbsd-8]: Makefile.inc
 	src/external/bsd/ntp/bin [netbsd-8]: Makefile.inc
 	src/external/bsd/ntp/bin/ntp-keygen [netbsd-8]: Makefile
 	src/external/bsd/ntp/bin/ntpd [netbsd-8]: Makefile
 	src/external/bsd/ntp/bin/ntpdc [netbsd-8]: Makefile
 	src/external/bsd/ntp/bin/ntpq [netbsd-8]: Makefile
 	src/external/bsd/ntp/bin/sntp [netbsd-8]: Makefile
 Removed Files:
 	src/external/bsd/ntp/bin/ntp-keygen [netbsd-8]: ntp-keygen.8
 	src/external/bsd/ntp/bin/ntpd [netbsd-8]: ntp.conf.5 ntp.keys.5 ntpd.8
 	src/external/bsd/ntp/bin/ntpdc [netbsd-8]: ntpdc.8
 	src/external/bsd/ntp/bin/ntpq [netbsd-8]: ntpq.8
 	src/external/bsd/ntp/bin/sntp [netbsd-8]: sntp.1

 Log Message:
 Pull up following revision(s) (requested by kim in ticket #1616):

 	external/bsd/ntp/bin/ntpq/ntpq.8: file removal
 	external/bsd/ntp/bin/Makefile.inc: revision 1.4
 	external/bsd/ntp/bin/ntpd/ntpd.8: file removal
 	external/bsd/ntp/bin/ntpq/Makefile: revision 1.9 (patch)
 	external/bsd/ntp/bin/ntpd/Makefile: revision 1.28 (patch)
 	external/bsd/ntp/bin/sntp/sntp.1: file removal
 	external/bsd/ntp/bin/ntpd/ntp.keys.5: file removal
 	external/bsd/ntp/bin/ntpd/ntp.conf.5: file removal
 	external/bsd/ntp/Makefile.inc: revision 1.20
 	external/bsd/ntp/Makefile.inc: revision 1.21
 	external/bsd/ntp/bin/sntp/Makefile: revision 1.8
 	external/bsd/ntp/bin/ntp-keygen/Makefile: revision 1.7 (patch)
 	external/bsd/ntp/bin/sntp/Makefile: revision 1.9 (patch)
 	external/bsd/ntp/bin/ntp-keygen/ntp-keygen.8: file removal
 	external/bsd/ntp/bin/ntpdc/ntpdc.8: file removal
 	external/bsd/ntp/bin/ntpdc/Makefile: revision 1.7 (patch)

 Fix build; clean manpages only if they are generated automatically.
 include bsd.own.mk so that ../../Makefile.inc does not do it...

 Add rules for manual pages builds, remove including Makefile.inc

 Use .PARSEDIR

 PR/55710: Kimmo Suominen: Delete manual pages so that they get copy from the
 imported, already generated ones.


 To generate a diff of this commit:
 cvs rdiff -u -r1.17 -r1.17.2.1 src/external/bsd/ntp/Makefile.inc
 cvs rdiff -u -r1.3 -r1.3.46.1 src/external/bsd/ntp/bin/Makefile.inc
 cvs rdiff -u -r1.5 -r1.5.24.1 src/external/bsd/ntp/bin/ntp-keygen/Makefile
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/ntp-keygen/ntp-keygen.8
 cvs rdiff -u -r1.21.8.1 -r1.21.8.2 src/external/bsd/ntp/bin/ntpd/Makefile
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/ntpd/ntp.conf.5 \
     src/external/bsd/ntp/bin/ntpd/ntpd.8
 cvs rdiff -u -r1.2 -r0 src/external/bsd/ntp/bin/ntpd/ntp.keys.5
 cvs rdiff -u -r1.6 -r1.6.24.1 src/external/bsd/ntp/bin/ntpdc/Makefile
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/ntpdc/ntpdc.8
 cvs rdiff -u -r1.7 -r1.7.24.1 src/external/bsd/ntp/bin/ntpq/Makefile
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/ntpq/ntpq.8
 cvs rdiff -u -r1.6 -r1.6.24.1 src/external/bsd/ntp/bin/sntp/Makefile
 cvs rdiff -u -r1.1 -r0 src/external/bsd/ntp/bin/sntp/sntp.1

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: kim@NetBSD.org
State-Changed-When: Wed, 04 Nov 2020 21:45:57 +0000
State-Changed-Why:
Fixed in -current, 9.1, and 8.3


>Unformatted:

Home	PR Database Search