NetBSD Problem Report #55789

From www@netbsd.org  Fri Nov  6 03:30:22 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 1502A1A9246
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  6 Nov 2020 03:30:22 +0000 (UTC)
Message-Id: <20201106033020.B3C001A925A@mollari.NetBSD.org>
Date: Fri,  6 Nov 2020 03:30:20 +0000 (UTC)
From: nruslan_devel@yahoo.com
Reply-To: nruslan_devel@yahoo.com
To: gnats-bugs@NetBSD.org
Subject: New rump drivers
X-Send-Pr-Version: www-1.0

>Number:         55789
>Category:       kern
>Synopsis:       New rump drivers
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 06 03:35:00 +0000 2020
>Closed-Date:    Mon Dec 07 19:15:11 +0000 2020
>Last-Modified:  Mon Dec 07 19:15:11 +0000 2020
>Originator:     Ruslan Nikolaev
>Release:        master
>Organization:
Virginia Tech
>Environment:
>Description:
While working on rumprun-smp (github.com/ssrg-vt/rumprun-smp), we added additional glue code (rump files) for some new NetBSD drivers.

We have changes for ixgbe, NVMe, and xHCI. We are going to post them here shortly when they are fully ready for the latest branch.

xHCI patch is ready and attached.
>How-To-Repeat:

>Fix:
xHCI patch:

diff --git a/sys/rump/dev/lib/libpci_usbhc/Makefile b/sys/rump/dev/lib/libpci_usbhc/Makefile
index dddcd21dd27b..6aa253bc92c4 100644
--- a/sys/rump/dev/lib/libpci_usbhc/Makefile
+++ b/sys/rump/dev/lib/libpci_usbhc/Makefile
@@ -14,6 +14,7 @@ RUMP_COMPONENT=ioconf
 SRCS+=	ohci_pci.c ohci.c
 SRCS+=	uhci_pci.c uhci.c
 SRCS+=	ehci_pci.c ehci.c
+SRCS+=	xhci_pci.c xhci.c
 SRCS+=	usb_pci.c

 CPPFLAGS+= -I${RUMPTOP}/librump/rumpkern -I${RUMPTOP}/../dev
diff --git a/sys/rump/dev/lib/libpci_usbhc/PCI_USBHC.ioconf b/sys/rump/dev/lib/libpci_usbhc/PCI_USBHC.ioconf
index 4c324d0fbf3a..922e44d1c402 100644
--- a/sys/rump/dev/lib/libpci_usbhc/PCI_USBHC.ioconf
+++ b/sys/rump/dev/lib/libpci_usbhc/PCI_USBHC.ioconf
@@ -11,3 +11,4 @@ pseudo-root pci*
 ohci* at pci?
 uhci* at pci?
 ehci* at pci?
+xhci* at pci?
diff --git a/sys/rump/dev/lib/libusb/USB.ioconf b/sys/rump/dev/lib/libusb/USB.ioconf
index ca6e2bd71637..5f49f6fc1424 100644
--- a/sys/rump/dev/lib/libusb/USB.ioconf
+++ b/sys/rump/dev/lib/libusb/USB.ioconf
@@ -12,6 +12,7 @@ include "rump/dev/files.rump"
 pseudo-root ugenhc*

 # PCI host controllers
+pseudo-root xhci*diff --git a/sys/rump/dev/lib/libpci_usbhc/Makefile b/sys/rump/dev/lib/libpci_usbhc/Makefile
index dddcd21dd27b..6aa253bc92c4 100644
--- a/sys/rump/dev/lib/libpci_usbhc/Makefile
+++ b/sys/rump/dev/lib/libpci_usbhc/Makefile
@@ -14,6 +14,7 @@ RUMP_COMPONENT=ioconf
 SRCS+=	ohci_pci.c ohci.c
 SRCS+=	uhci_pci.c uhci.c
 SRCS+=	ehci_pci.c ehci.c
+SRCS+=	xhci_pci.c xhci.c
 SRCS+=	usb_pci.c

 CPPFLAGS+= -I${RUMPTOP}/librump/rumpkern -I${RUMPTOP}/../dev
diff --git a/sys/rump/dev/lib/libpci_usbhc/PCI_USBHC.ioconf b/sys/rump/dev/lib/libpci_usbhc/PCI_USBHC.ioconf
index 4c324d0fbf3a..922e44d1c402 100644
--- a/sys/rump/dev/lib/libpci_usbhc/PCI_USBHC.ioconf
+++ b/sys/rump/dev/lib/libpci_usbhc/PCI_USBHC.ioconf
@@ -11,3 +11,4 @@ pseudo-root pci*
 ohci* at pci?
 uhci* at pci?
 ehci* at pci?
+xhci* at pci?
diff --git a/sys/rump/dev/lib/libusb/USB.ioconf b/sys/rump/dev/lib/libusb/USB.ioconf
index ca6e2bd71637..5f49f6fc1424 100644
--- a/sys/rump/dev/lib/libusb/USB.ioconf
+++ b/sys/rump/dev/lib/libusb/USB.ioconf
@@ -12,6 +12,7 @@ include "rump/dev/files.rump"
 pseudo-root ugenhc*

 # PCI host controllers
+pseudo-root xhci*
 pseudo-root ehci*
 pseudo-root ohci*
 pseudo-root uhci*
@@ -22,6 +23,7 @@ pseudo-root uhci*
 #
 usb*    at ugenhc?

+usb*	at xhci?
 usb*	at ehci?
 usb*	at ohci?
 usb*	at uhci?
 pseudo-root ehci*
 pseudo-root ohci*
 pseudo-root uhci*
@@ -22,6 +23,7 @@ pseudo-root uhci*
 #
 usb*    at ugenhc?

+usb*	at xhci?
 usb*	at ehci?
 usb*	at ohci?
 usb*	at uhci?

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55789 CVS commit: src/sys/rump/dev/lib
Date: Fri, 6 Nov 2020 10:35:33 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Nov  6 15:35:33 UTC 2020

 Modified Files:
 	src/sys/rump/dev/lib/libpci_usbhc: Makefile PCI_USBHC.ioconf
 	src/sys/rump/dev/lib/libusb: USB.ioconf

 Log Message:
 PR/55789: Ruslan Nikolaev: New rump drivers


 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.6 src/sys/rump/dev/lib/libpci_usbhc/Makefile
 cvs rdiff -u -r1.1 -r1.2 src/sys/rump/dev/lib/libpci_usbhc/PCI_USBHC.ioconf
 cvs rdiff -u -r1.2 -r1.3 src/sys/rump/dev/lib/libusb/USB.ioconf

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 07 Dec 2020 19:15:11 +0000
State-Changed-Why:
seems this got committed by christos. let me know if that's wrong.


>Unformatted:

Home	PR Database Search