NetBSD Problem Report #55840

From www@netbsd.org  Fri Dec  4 15:03:05 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BF8F81A9217
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  4 Dec 2020 15:03:05 +0000 (UTC)
Message-Id: <20201204150304.64ADC1A9239@mollari.NetBSD.org>
Date: Fri,  4 Dec 2020 15:03:04 +0000 (UTC)
From: kd@panix.com
Reply-To: kd@panix.com
To: gnats-bugs@NetBSD.org
Subject: mutt-2.0.2 slang build with pkgsrc patch-color.c patch fails
X-Send-Pr-Version: www-1.0

>Number:         55840
>Category:       pkg
>Synopsis:       mutt-2.0.2 slang build with pkgsrc patch-color.c patch fails
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tonio
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 04 15:05:00 +0000 2020
>Closed-Date:    Sat Dec 05 13:25:32 +0000 2020
>Last-Modified:  Sat Dec 05 13:25:32 +0000 2020
>Originator:     Ken Dunlap
>Release:        NetBSD-9
>Organization:
PANIX
>Environment:
NetBSD juggler.panix.com 9.0 NetBSD 9.0 (PANIX-STD) #7: Sun May  3 21:08:07 EDT 2020  root@juggler.panix.com:/misc/obj64/misc/devel/netbsd/9.0/src/sys/arch/amd64/compile/PANIX-STD amd64
>Description:
The patch causes the preprocessor to use the wrong defines when building with slang on NetBSD.
>How-To-Repeat:
Apply patch, configure using slang, build.  Error output:

color.c:264:33: error: use of undeclared identifier 'A_ATTRIBUTES'
  merged_pair |= (source_pair & ATTR_MASK) | (overlay_pair & ATTR_MASK);
                                ^
color.c:123:20: note: expanded from macro 'ATTR_MASK'
#define ATTR_MASK (A_ATTRIBUTES ^ A_COLOR)
                   ^
color.c:264:62: error: use of undeclared identifier 'A_ATTRIBUTES'
  merged_pair |= (source_pair & ATTR_MASK) | (overlay_pair & ATTR_MASK);
                                                             ^
color.c:123:20: note: expanded from macro 'ATTR_MASK'
#define ATTR_MASK (A_ATTRIBUTES ^ A_COLOR)
                   ^
2 errors generated.
>Fix:
Revised patch:

--- color.c.orig        2020-12-03 11:40:02.377302672 -0500
+++ color.c     2020-12-03 11:43:57.080051289 -0500
@@ -119,7 +119,7 @@

 #define COLOR_QUOTE_INIT       8

-#ifdef NCURSES_VERSION
+#if defined(NCURSES_VERSION) || (defined(__NetBSD__) && !defined(USE_SLANG_CURSES))
 #define ATTR_MASK (A_ATTRIBUTES ^ A_COLOR)
 #elif defined (USE_SLANG_CURSES)
 #define ATTR_MASK (~(unsigned int)A_NORMAL ^ (A_CHARTEXT | A_UNUSED | A_COLOR))

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->tonio
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Sat, 05 Dec 2020 09:29:30 +0000
Responsible-Changed-Why:
Antoine, can you please give a look to it?
(over to MAINTAINER)


From: "Antoine Reilles" <tonio@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55840 CVS commit: pkgsrc/mail/mutt/patches
Date: Sat, 5 Dec 2020 13:02:03 +0000

 Module Name:	pkgsrc
 Committed By:	tonio
 Date:		Sat Dec  5 13:02:03 UTC 2020

 Modified Files:
 	pkgsrc/mail/mutt/patches: patch-color.c

 Log Message:
 Fix pr/55840: build under netbsd with slang

 When using slang, do not use ncurses synbols


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/mail/mutt/patches/patch-color.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: tonio@NetBSD.org
State-Changed-When: Sat, 05 Dec 2020 13:25:32 +0000
State-Changed-Why:
Patch applied, thanks for the PR


>Unformatted:

Home	PR Database Search