NetBSD Problem Report #55882

From bsiegert@netbsd.org  Sat Dec 19 14:46:59 2020
Return-Path: <bsiegert@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D461D1A9239
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 19 Dec 2020 14:46:58 +0000 (UTC)
Message-Id: <20201219144657.938CD1A923A@mollari.NetBSD.org>
Date: Sat, 19 Dec 2020 14:46:57 +0000 (UTC)
From: bsiegert@netbsd.org
Reply-To: bsiegert@netbsd.org
To: gnats-bugs@NetBSD.org
Subject: pkg_install.conf does not support whitespace after =
X-Send-Pr-Version: 3.95

>Number:         55882
>Category:       pkg
>Synopsis:       pkg_install.conf does not support whitespace after =
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 19 14:50:00 +0000 2020
>Last-Modified:  Sat Dec 19 22:25:01 +0000 2020
>Originator:     Benny Siegert
>Release:        pkgsrc-current as of December 2020 / NetBSD 9.1
>Organization:
	The NetBSD Foundation
>Environment:
	NetBSD shiso.mirbsd.org 9.1 NetBSD 9.1 (LARGEFONT) #0: Thu Oct 22 09:55:35 CEST 2020  bsiegert@shiso.mirbsd.org:/usr/obj/sys/arch/amd64/compile/LARGEFONT amd64
>Description:
In pkgsrc Makefiles, it is usual to align the values with one or more Tab characters after the = sign. This also works in mk.conf but not in pkg_install.conf:

 28138      1 pkg_info NAMI  "/etc/pkg_install.conf"
 28138      1 pkg_info RET   open 3
 28138      1 pkg_info CALL  read(3,0x7afb0b81c780,0x4000)
 28138      1 pkg_info GIO   fd 3 read 26 bytes
       "PKG_DBDIR=      /usr/pkg/pkgdb\n"
 28138      1 pkg_info RET   read 26/0x1a
[...]
 28138      1 pkg_info CALL  open(0x7afb0b825040,0x600004,0xea014d11)
 28138      1 pkg_info NAMI  "  /usr/pkg/pkgdb"
 28138      1 pkg_info RET   open -1 errno 2 No such file or directory


>How-To-Repeat:
Put the following in /etc/pkg_install.conf:

PKG_DBDIR=      /usr/pkg/pkgdb

(with a Tab in the middle)
>Fix:
n/a

>Release-Note:

>Audit-Trail:
From: Joerg Sonnenberger <joerg@bec.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/55882: pkg_install.conf does not support whitespace after =
Date: Sat, 19 Dec 2020 15:56:39 +0100

 On Sat, Dec 19, 2020 at 02:50:00PM +0000, bsiegert@netbsd.org wrote:
 > In pkgsrc Makefiles, it is usual to align the values with one or more Tab characters after the = sign. This also works in mk.conf but not in pkg_install.conf:

 It works as documented. It is not a Makefile.

 Joerg

From: Benny Siegert <bsiegert@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/55882: pkg_install.conf does not support whitespace after =
Date: Sat, 19 Dec 2020 17:11:05 +0100

 On Sat, Dec 19, 2020 at 4:00 PM Joerg Sonnenberger <joerg@bec.de> wrote:
 >  It works as documented. It is not a Makefile.

 Maybe, but it is certainly surprising that the rules for
 pkg_install.conf are different from mk.conf. It would not be hard to
 strip leading whitespace.

From: Joerg Sonnenberger <joerg@bec.de>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
	bsiegert@netbsd.org
Subject: Re: pkg/55882: pkg_install.conf does not support whitespace after =
Date: Sat, 19 Dec 2020 16:52:20 +0100

 On Sat, Dec 19, 2020 at 03:15:02PM +0000, Benny Siegert wrote:
 > The following reply was made to PR pkg/55882; it has been noted by GNATS.
 > 
 > From: Benny Siegert <bsiegert@netbsd.org>
 > To: gnats-bugs@netbsd.org
 > Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
 > Subject: Re: pkg/55882: pkg_install.conf does not support whitespace after =
 > Date: Sat, 19 Dec 2020 17:11:05 +0100
 > 
 >  On Sat, Dec 19, 2020 at 4:00 PM Joerg Sonnenberger <joerg@bec.de> wrote:
 >  >  It works as documented. It is not a Makefile.
 >  
 >  Maybe, but it is certainly surprising that the rules for
 >  pkg_install.conf are different from mk.conf. It would not be hard to
 >  strip leading whitespace.

 So the next person comes along and complains that += doesn't work. Or
 that ${} variablse are not expanded. A week later, make is embedded in
 pkg_install. So no, it is not a bug. At best it is a feature request.

 Joerg

From: Benny Siegert <bsiegert@netbsd.org>
To: Joerg Sonnenberger <joerg@bec.de>
Cc: gnats-admin@netbsd.org, gnats-bugs@netbsd.org, pkg-manager@netbsd.org, 
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/55882: pkg_install.conf does not support whitespace after =
Date: Sat, 19 Dec 2020 17:36:49 +0100

 --0000000000009392c405b6d3d57e
 Content-Type: text/plain; charset="UTF-8"

 Are feature requests less legitimate than bugs?

 --0000000000009392c405b6d3d57e
 Content-Type: text/html; charset="UTF-8"

 Are feature requests less legitimate than bugs?

 --0000000000009392c405b6d3d57e--

From: Joerg Sonnenberger <joerg@bec.de>
To: Benny Siegert <bsiegert@netbsd.org>
Cc: gnats-admin@netbsd.org, gnats-bugs@netbsd.org, pkg-manager@netbsd.org,
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/55882: pkg_install.conf does not support whitespace after =
Date: Sat, 19 Dec 2020 17:38:16 +0100

 On Sat, Dec 19, 2020 at 05:36:49PM +0100, Benny Siegert wrote:
 > Are feature requests less legitimate than bugs?

 It is filled as "sw-bug"?

 Joerg

From: Benny Siegert <bsiegert@netbsd.org>
To: Joerg Sonnenberger <joerg@bec.de>
Cc: gnats-admin@netbsd.org, gnats-bugs@netbsd.org, pkg-manager@netbsd.org, 
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/55882: pkg_install.conf does not support whitespace after =
Date: Sat, 19 Dec 2020 19:53:21 +0100

 On Sat, Dec 19, 2020 at 6:40 PM Joerg Sonnenberger <joerg@bec.de> wrote:
 >
 > On Sat, Dec 19, 2020 at 05:36:49PM +0100, Benny Siegert wrote:
 > > Are feature requests less legitimate than bugs?
 >
 > It is filled as "sw-bug"?

 I made it a change-request. Thanks for being so kind and supportive.

From: "John D. Baker" <jdbaker@consolidated.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/55882: pkg_install.conf does not support whitespace after
 =
Date: Sat, 19 Dec 2020 16:21:09 -0600 (CST)

 It is interesting to note that when the pkgsrc machinery detects that one
 is about to build/install a package with license not among the default
 acceptable licenses, part of the advice reads:

 ... or add

   ACCEPTABLE_LICENSES= foo-license

 to /etc/pkg_install.conf.

 Note the deliberate space between the "=" and the license name.

 For whatever reason, I've habitually squashed that space whenever
 I've cut'n'pasted such an advice line to my "/etc/pkg_install.conf",
 so I've never noticed that it would cause a problem.

 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]consolidated[flyspeck]net  OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645

>Unformatted:

Home	PR Database Search