NetBSD Problem Report #55897
From www@netbsd.org Wed Dec 30 13:10:18 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id B5B8E1A921F
for <gnats-bugs@gnats.NetBSD.org>; Wed, 30 Dec 2020 13:10:18 +0000 (UTC)
Message-Id: <20201230131017.2A0F51A923A@mollari.NetBSD.org>
Date: Wed, 30 Dec 2020 13:10:17 +0000 (UTC)
From: alexander.i.mukhin@gmail.com
Reply-To: alexander.i.mukhin@gmail.com
To: gnats-bugs@NetBSD.org
Subject: A mess with complex arithmetics in earmv7hf
X-Send-Pr-Version: www-1.0
>Number: 55897
>Category: port-arm
>Synopsis: A mess with complex arithmetics in earmv7hf
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: port-arm-maintainer
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Dec 30 13:15:00 +0000 2020
>Closed-Date: Sun Aug 08 19:22:08 +0000 2021
>Last-Modified: Sun Aug 08 19:22:08 +0000 2021
>Originator: Alexander Mukhin
>Release: 9.1_STABLE
>Organization:
>Environment:
NetBSD rpi2 9.1_STABLE NetBSD 9.1_STABLE (MY-RPI2-9-v3) #1: Mon Dec 21 12:31:59 UTC 2020 alexandr1@rpi2:/home/alexandr1/build/usr/obj/sys/arch/evbarm/compile/MY-RPI2-9-v3 evbarm
>Description:
I'm developing a Fourier transform library. While testing my software on
NetBSD/earmv7hf, I found, to my surprise, that even simplest complex
arithmetics cause the programs to dump core or return garbage, if they
are linked against libm.
Tracking the issue down, I found that it is caused by the builtin
complex arithmetic routines, such as muldc3, taken from compiler-rt and
included in libm. These routines use the standard AAPCS calling
convention, while the compiler calls them via the VFP calling convention
variant, utilizing VFP registers for parameter passing and result
return.
All this is because the complex arithmetic routines in compiler-rt are
defined with the COMPILER_RT_ABI macro, which expands to
__attribute__((pcs("aapcs"))) and overrides the default ABI.
>How-To-Repeat:
$ cat test.c
#include <complex.h>
int main (void) {
double complex z,w,u;
z=1+I;
w=2+I;
u=z*w;
return 0;
}
$ gcc test.c -lm
$ ./a.out
[1] Bus error (core dumped) ./a.out
>Fix:
A quick and dirty fix I used for myself was to force the macro
COMPILER_RT_ABI to be undefined when compiling these routines for libm:
$ diff -u src/lib/libm/compiler_rt/Makefile.inc.orig src/lib/libm/compiler_rt/Makefile.inc
--- src/lib/libm/compiler_rt/Makefile.inc.orig 2016-02-27 19:06:56.000000000 +0000
+++ src/lib/libm/compiler_rt/Makefile.inc 2020-12-30 10:15:24.865722208 +0000
@@ -36,5 +36,6 @@
. else
SRCS+= ${src}
COPTS.${src}+= -Wno-error=missing-prototypes
+COPTS.${src}+= -U__ARM_EABI__
. endif
.endfor
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: lib-bug-people->port-arm-maintainer
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Wed, 09 Jun 2021 01:09:08 +0000
Responsible-Changed-Why:
bring this to the attention of the right people
From: Rin Okuyama <rokuyama.rk@gmail.com>
To: "gnats-bugs@NetBSD.org" <gnats-bugs@NetBSD.org>
Cc:
Subject: Re: port-arm/55897: A mess with complex arithmetics in earmv7hf
Date: Fri, 11 Jun 2021 10:43:04 +0900
This problem, i.e., ABI mismatch for floating-point runtime routines for
hard-float arm, has been fixed by upstream by,
(1) providing floating-point runtime routines with correct calling
conventions, as well as,
(2) providing EABI runtime routines as is, at the same time.
The patch provided by submitter (adding -U__ARM_EABI__) only does (1).
So, the correct fix should be importing upstream fixes.
Although LLVM project itself has moved to MIT license, compiler_rt is
provided by dual licenses of BSD and MIT:
https://github.com/llvm/llvm-project/blob/main/compiler-rt/LICENSE.TXT
Therefore, there's no problem to merge upstream fixes into
sys/external/bsd.
The patches below are for sys/external/bsd/compiler_rt/dist, for (1) and
(2) above, and necessary style fixes:
http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch0
http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch1
http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch2
http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch3
http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch4
http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch5
Also, this patch is glue for our tree:
http://www.netbsd.org/~rin/port-arm_55897/our_tree.patch
I've confirmed that
(a) test case provided by submitter no longer fails,
(b) no regression for ATF, and
(c) no binary changes for kernels
both for GCC9 and LLVM.
I will commit these changes within few days if there's no objection.
Thanks,
rin
From: Nick Hudson <nick.hudson@gmx.co.uk>
To: gnats-bugs@netbsd.org, port-arm-maintainer@netbsd.org,
gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, alexander.i.mukhin@gmail.com
Cc:
Subject: Re: port-arm/55897: A mess with complex arithmetics in earmv7hf
Date: Sat, 12 Jun 2021 10:27:41 +0100
On 11/06/2021 02:45, Rin Okuyama wrote:
> The following reply was made to PR port-arm/55897; it has been noted by =
GNATS.
>
> From: Rin Okuyama <rokuyama.rk@gmail.com>
> To: "gnats-bugs@NetBSD.org" <gnats-bugs@NetBSD.org>
> Cc:
> Subject: Re: port-arm/55897: A mess with complex arithmetics in earmv7hf
> Date: Fri, 11 Jun 2021 10:43:04 +0900
>
> This problem, i.e., ABI mismatch for floating-point runtime routines f=
or
> hard-float arm, has been fixed by upstream by,
>
> (1) providing floating-point runtime routines with correct calling
> conventions, as well as,
> (2) providing EABI runtime routines as is, at the same time.
>
> The patch provided by submitter (adding -U__ARM_EABI__) only does (1).
> So, the correct fix should be importing upstream fixes.
>
> Although LLVM project itself has moved to MIT license, compiler_rt is
> provided by dual licenses of BSD and MIT:
>
> https://github.com/llvm/llvm-project/blob/main/compiler-rt/LICENSE.TXT
>
> Therefore, there's no problem to merge upstream fixes into
> sys/external/bsd.
>
> The patches below are for sys/external/bsd/compiler_rt/dist, for (1) a=
nd
> (2) above, and necessary style fixes:
>
> http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch0
> http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch1
> http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch2
> http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch3
> http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch4
> http://www.netbsd.org/~rin/port-arm_55897/compiler_rt.patch5
>
> Also, this patch is glue for our tree:
>
> http://www.netbsd.org/~rin/port-arm_55897/our_tree.patch
>
> I've confirmed that
>
> (a) test case provided by submitter no longer fails,
> (b) no regression for ATF, and
> (c) no binary changes for kernels
>
> both for GCC9 and LLVM.
>
> I will commit these changes within few days if there's no objection.
LGTM.
Thanks,
Nick
From: Rin Okuyama <rokuyama.rk@gmail.com>
To: Nick Hudson <nick.hudson@gmx.co.uk>, gnats-bugs@netbsd.org,
port-arm-maintainer@netbsd.org, gnats-admin@netbsd.org,
netbsd-bugs@netbsd.org, alexander.i.mukhin@gmail.com
Cc:
Subject: Re: port-arm/55897: A mess with complex arithmetics in earmv7hf
Date: Wed, 16 Jun 2021 13:58:10 +0900
On 2021/06/12 18:27, Nick Hudson wrote:
> LGTM.
Thank you for confirmation. I will commit soon.
rin
From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/55897 CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/builtins
Date: Wed, 16 Jun 2021 05:05:03 +0000
Module Name: src
Committed By: rin
Date: Wed Jun 16 05:05:03 UTC 2021
Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/builtins: int_lib.h
Log Message:
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 266891:
https://github.com/llvm/llvm-project/commit/28e1b977d4694c6b3a5c4d8107570a969be71e77#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[PATCH] builtins: remove use of __attribute__((pcs("aapcs"))) on
Windows
Windows does not honour the __attribute__((pcs)) on ARM. Although this will
result in ABI mismatches, compiler-rt should largely be unneeded for resolving
dependencies as we generate MS ABI compliant library calls now for the most
part.
llvm-svn: 266891
To generate a diff of this commit:
cvs rdiff -u -r1.1.1.4 -r1.2 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/55897 CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/builtins
Date: Wed, 16 Jun 2021 05:05:49 +0000
Module Name: src
Committed By: rin
Date: Wed Jun 16 05:05:49 UTC 2021
Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/builtins: int_lib.h
Log Message:
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 298974 for lib/builtins/int_lib.h.
https://github.com/llvm/llvm-project/commit/d8ca74176e25bd4080ee81982819e2ef7a36553f#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[Builtin] Unxfail tests for armhf
Summary:
Originally, a few tests fail for armhf target due to:
1) COMPILER_RT_ARMHF_TARGET was not set when building the lib
2) COMPILER_RT_ABI should not be defined as `__attribute__((pcs("aapcs")))` for armhf when building for both lib and tests
This address https://bugs.llvm.org//show_bug.cgi?id=32261
mulsc3_test.c is a newly exposed issue, which will be addressed separately.
Reviewers: rengolin, compnerd
Reviewed By: compnerd
Subscribers: aemerson, llvm-commits, mgorny
Differential Revision: https://reviews.llvm.org/D31448
llvm-svn: 298974
To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/55897 CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/builtins
Date: Wed, 16 Jun 2021 05:06:21 +0000
Module Name: src
Committed By: rin
Date: Wed Jun 16 05:06:21 UTC 2021
Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/builtins: int_lib.h
Log Message:
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 303138:
https://github.com/llvm/llvm-project/commit/44c45717b9e9f3dc194508d2eeeb8599a9d76949#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[PATCH] builtins: use reserved spelling (NFC)
llvm-svn: 303138
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/55897 CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/builtins
Date: Wed, 16 Jun 2021 05:06:46 +0000
Module Name: src
Committed By: rin
Date: Wed Jun 16 05:06:46 UTC 2021
Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/builtins: adddf3.c addsf3.c
ashldi3.c ashrdi3.c comparedf2.c comparesf2.c divdf3.c divsf3.c
divsi3.c extendhfsf2.c extendsfdf2.c fixdfdi.c fixdfsi.c fixsfdi.c
fixsfsi.c fixunsdfdi.c fixunsdfsi.c fixunssfdi.c fixunssfsi.c
floatdidf.c floatdisf.c floatsidf.c floatsisf.c floatundidf.c
floatundisf.c floatunsidf.c floatunsisf.c int_lib.h lshrdi3.c
muldf3.c muldi3.c mulsf3.c negdf2.c negsf2.c subdf3.c subsf3.c
truncdfhf2.c truncdfsf2.c truncsfhf2.c udivsi3.c
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm:
aeabi_cdcmpeq_check_nan.c aeabi_cfcmpeq_check_nan.c aeabi_div0.c
aeabi_drsub.c aeabi_frsub.c
Log Message:
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 303188:
https://github.com/llvm/llvm-project/commit/36ac5ddff7377586390a71cb3261f0a40d274308#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[PATCH] builtins: expand out the AEABI function stubs
These actually may change calling conventions. We cannot simply provide
function aliases as the aliased function may have a different calling
convention. Provide a forwarding function instead to permit the
compiler to synthesize the calling convention adjustment thunk.
Remove the `ARM_EABI_FNALIAS` macro as that is not safe to use.
Resolves PR33030!
llvm-svn: 303188
To generate a diff of this commit:
cvs rdiff -u -r1.1.1.3 -r1.2 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/adddf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/divdf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/extendsfdf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixdfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixdfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/subdf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/subsf3.c
cvs rdiff -u -r1.1.1.4 -r1.2 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/addsf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/comparedf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/comparesf2.c
cvs rdiff -u -r1.1.1.1 -r1.2 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/ashldi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/ashrdi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/extendhfsf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatdisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatundisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/lshrdi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/muldi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/negsf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/truncdfhf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/truncsfhf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/udivsi3.c
cvs rdiff -u -r1.1.1.2 -r1.2 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/divsf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/divsi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixsfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixsfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunsdfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunsdfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunssfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunssfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatsidf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatsisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatunsidf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatunsisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/muldf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/mulsf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/negdf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/truncdfsf2.c
cvs rdiff -u -r1.2 -r1.3 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatdidf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatundidf.c
cvs rdiff -u -r1.4 -r1.5 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h
cvs rdiff -u -r1.1.1.1 -r1.2 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_cdcmpeq_check_nan.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_cfcmpeq_check_nan.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_div0.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_drsub.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_frsub.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/55897 CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/builtins
Date: Wed, 16 Jun 2021 05:07:18 +0000
Module Name: src
Committed By: rin
Date: Wed Jun 16 05:07:18 UTC 2021
Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/builtins: floatdidf.c
Log Message:
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 303207:
https://github.com/llvm/llvm-project/commit/4a45838d10085defac0f3b3003a5263e34536f3b#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[PATCH] builtins: fix guard __AEABI__ -> __ARM_EABI__
llvm-svn: 303207
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatdidf.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/55897 CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/builtins
Date: Wed, 16 Jun 2021 05:07:49 +0000
Module Name: src
Committed By: rin
Date: Wed Jun 16 05:07:49 UTC 2021
Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/builtins: adddf3.c addsf3.c
ashldi3.c ashrdi3.c comparedf2.c comparesf2.c divdf3.c divsf3.c
divsi3.c extendhfsf2.c extendsfdf2.c fixdfdi.c fixdfsi.c fixsfdi.c
fixsfsi.c fixunsdfdi.c fixunsdfsi.c fixunssfdi.c fixunssfsi.c
floatdidf.c floatdisf.c floatsidf.c floatsisf.c floatundidf.c
floatundisf.c floatunsidf.c floatunsisf.c int_lib.h lshrdi3.c
muldf3.c muldi3.c mulsf3.c negdf2.c negsf2.c subdf3.c subsf3.c
truncdfhf2.c truncdfsf2.c truncsfhf2.c udivsi3.c
Log Message:
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 314851:
https://github.com/llvm/llvm-project/commit/0d586d06a756b126a7eb43a21ecc12bd243d7cd8#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[PATCH] [compiler-rt] Add back ARM EABI aliases where legal.
r303188 removed all the uses of aliases for EABI functions from
compiler-rt, because some of them had mismatched calling conventions.
Obviously, we can't use aliases for functions which don't have the same
calling convention, but that's only an issue for floating-point
functions with the hardfloat ABI. In other cases, the stubs increase
size and reduce performance for no benefit.
This patch adds back the aliases, with appropriate checks to make sure
they're only used in cases where the calling convention matches.
llvm-svn: 314851
To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/adddf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/addsf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/ashldi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/ashrdi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/comparedf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/comparesf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/divdf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/divsf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/divsi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/extendhfsf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/extendsfdf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixdfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixdfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixsfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixsfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunsdfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunsdfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunssfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunssfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatdisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatsidf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatsisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatundisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatunsidf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatunsisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/lshrdi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/muldf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/muldi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/mulsf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/negdf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/negsf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/subdf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/subsf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/truncdfhf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/truncdfsf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/truncsfhf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/udivsi3.c
cvs rdiff -u -r1.4 -r1.5 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatdidf.c
cvs rdiff -u -r1.3 -r1.4 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatundidf.c
cvs rdiff -u -r1.5 -r1.6 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/55897 CVS commit: src
Date: Wed, 16 Jun 2021 05:21:09 +0000
Module Name: src
Committed By: rin
Date: Wed Jun 16 05:21:09 UTC 2021
Modified Files:
src/lib/libc/compiler_rt: Makefile.inc
src/lib/libm/compiler_rt: Makefile.inc
src/sys/lib/libkern: Makefile.compiler-rt
Added Files:
src/sys/external/bsd/compiler_rt: abi.mk
Log Message:
PR port-arm/55897
Fix ABI mismatch for armhf runtime routines for floating-point arithmetics;
For hard-float arm variants, provide
(1) generic runtime routines with correct calling convention, and
(2) EABI runtime routines at the same time.
I've confirmed that no binary changes for kernels.
LGTM by skrll
To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.40 src/lib/libc/compiler_rt/Makefile.inc
cvs rdiff -u -r1.10 -r1.11 src/lib/libm/compiler_rt/Makefile.inc
cvs rdiff -u -r0 -r1.1 src/sys/external/bsd/compiler_rt/abi.mk
cvs rdiff -u -r1.12 -r1.13 src/sys/lib/libkern/Makefile.compiler-rt
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->feedback
State-Changed-By: rin@NetBSD.org
State-Changed-When: Wed, 16 Jun 2021 05:36:29 +0000
State-Changed-Why:
Should be fixed now. Can you please confirm?
(Sorry for the late response!)
From: Alexander Mukhin <alexander.i.mukhin@gmail.com>
To: gnats-bugs@netbsd.org
Cc: port-arm-maintainer@netbsd.org, netbsd-bugs@netbsd.org,
gnats-admin@netbsd.org, rin@NetBSD.org
Subject: Re: port-arm/55897 (A mess with complex arithmetics in earmv7hf)
Date: Fri, 23 Jul 2021 16:14:06 +0300
Yes, I confirm the test case no longer fails.
Thank you!
--
Alexander.
On Wed, Jun 16, 2021 at 05:36:30AM +0000, rin@NetBSD.org wrote:
> Synopsis: A mess with complex arithmetics in earmv7hf
>
> State-Changed-From-To: open->feedback
> State-Changed-By: rin@NetBSD.org
> State-Changed-When: Wed, 16 Jun 2021 05:36:29 +0000
> State-Changed-Why:
> Should be fixed now. Can you please confirm?
> (Sorry for the late response!)
>
>
>
State-Changed-From-To: feedback->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 24 Jul 2021 03:14:58 +0000
State-Changed-Why:
Confirmed fixed. Does this need to go into -9?
From: Nick Hudson <nick.hudson@gmx.co.uk>
To: gnats-bugs@netbsd.org, port-arm-maintainer@netbsd.org,
netbsd-bugs@netbsd.org, gnats-admin@netbsd.org, dholland@NetBSD.org,
alexander.i.mukhin@gmail.com
Cc:
Subject: Re: port-arm/55897 (A mess with complex arithmetics in earmv7hf)
Date: Fri, 30 Jul 2021 08:16:40 +0100
On 24/07/2021 04:14, dholland@NetBSD.org wrote:
> Confirmed fixed. Does this need to go into -9?
I'll create a pull-up request.
State-Changed-From-To: open->pending-pullups
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 07 Aug 2021 03:28:07 +0000
State-Changed-Why:
pullup-9 #1328
(thanks!)
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/55897 CVS commit: [netbsd-9] src
Date: Sun, 8 Aug 2021 10:11:40 +0000
Module Name: src
Committed By: martin
Date: Sun Aug 8 10:11:40 UTC 2021
Modified Files:
src/lib/libc/compiler_rt [netbsd-9]: Makefile.inc
src/lib/libm/compiler_rt [netbsd-9]: Makefile.inc
src/sys/external/bsd/compiler_rt/dist/lib/builtins [netbsd-9]: adddf3.c
addsf3.c ashldi3.c ashrdi3.c comparedf2.c comparesf2.c divdf3.c
divsf3.c divsi3.c extendhfsf2.c extendsfdf2.c fixdfdi.c fixdfsi.c
fixsfdi.c fixsfsi.c fixunsdfdi.c fixunsdfsi.c fixunssfdi.c
fixunssfsi.c floatdidf.c floatdisf.c floatsidf.c floatsisf.c
floatundidf.c floatundisf.c floatunsidf.c floatunsisf.c int_lib.h
lshrdi3.c muldf3.c muldi3.c mulsf3.c negdf2.c negsf2.c subdf3.c
subsf3.c truncdfhf2.c truncdfsf2.c truncsfhf2.c udivsi3.c
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm [netbsd-9]:
aeabi_cdcmpeq_check_nan.c aeabi_cfcmpeq_check_nan.c aeabi_div0.c
aeabi_drsub.c aeabi_frsub.c
src/sys/lib/libkern [netbsd-9]: Makefile.compiler-rt
Added Files:
src/sys/external/bsd/compiler_rt [netbsd-9]: abi.mk
Log Message:
Pull up following revision(s) (requested by skrll in ticket #1328):
sys/external/bsd/compiler_rt/dist/lib/builtins/negsf2.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/muldf3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/truncdfhf2.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/negsf2.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/muldf3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/floatdidf.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_cfcmpeq_check_nan.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/truncdfhf2.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/floatdidf.c: revision 1.4
sys/external/bsd/compiler_rt/dist/lib/builtins/floatdidf.c: revision 1.5
sys/external/bsd/compiler_rt/dist/lib/builtins/divdf3.c: revision 1.2
sys/external/bsd/compiler_rt/abi.mk: revision 1.1
sys/external/bsd/compiler_rt/dist/lib/builtins/divdf3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/floatunsisf.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/comparesf2.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/floatunsisf.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/comparesf2.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h: revision 1.4
sys/external/bsd/compiler_rt/dist/lib/builtins/ashrdi3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/ashldi3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/truncdfsf2.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/subdf3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h: revision 1.5
sys/external/bsd/compiler_rt/dist/lib/builtins/ashrdi3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/ashldi3.c: revision 1.3
sys/lib/libkern/Makefile.compiler-rt: revision 1.13
sys/external/bsd/compiler_rt/dist/lib/builtins/truncdfsf2.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/subdf3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h: revision 1.6
sys/external/bsd/compiler_rt/dist/lib/builtins/lshrdi3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/floatsisf.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/extendhfsf2.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/lshrdi3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/floatsisf.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/extendhfsf2.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/floatunsidf.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/floatunsidf.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/fixdfsi.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/fixdfsi.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_frsub.c: revision 1.2
lib/libm/compiler_rt/Makefile.inc: revision 1.11
sys/external/bsd/compiler_rt/dist/lib/builtins/fixunsdfsi.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/floatsidf.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/fixunsdfsi.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/divsi3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/adddf3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/floatsidf.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/divsi3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/adddf3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_div0.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/mulsf3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/mulsf3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/fixdfdi.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/fixdfdi.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/divsf3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/negdf2.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/fixunsdfdi.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/divsf3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/negdf2.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/fixunsdfdi.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/extendsfdf2.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/subsf3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/extendsfdf2.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/subsf3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/comparedf2.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/comparedf2.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/floatundisf.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/floatundisf.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/fixsfsi.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_drsub.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/fixsfsi.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/muldi3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/fixunssfsi.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_cdcmpeq_check_nan.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/muldi3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/fixunssfsi.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/floatdisf.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/floatdisf.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/addsf3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/addsf3.c: revision 1.3
lib/libc/compiler_rt/Makefile.inc: revision 1.40
sys/external/bsd/compiler_rt/dist/lib/builtins/fixunssfdi.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/fixunssfdi.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/udivsi3.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/truncsfhf2.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/floatundidf.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/fixsfdi.c: revision 1.2
sys/external/bsd/compiler_rt/dist/lib/builtins/udivsi3.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/truncsfhf2.c: revision 1.3
sys/external/bsd/compiler_rt/dist/lib/builtins/floatundidf.c: revision 1.4
sys/external/bsd/compiler_rt/dist/lib/builtins/fixsfdi.c: revision 1.3
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 266891:
https://github.com/llvm/llvm-project/commit/28e1b977d4694c6b3a5c4d8107570a969be71e77#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[PATCH] builtins: remove use of __attribute__((pcs("aapcs"))) on
Windows
Windows does not honour the __attribute__((pcs)) on ARM. Although this will
result in ABI mismatches, compiler-rt should largely be unneeded for resolving
dependencies as we generate MS ABI compliant library calls now for the most
part.
llvm-svn: 266891
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 298974 for lib/builtins/int_lib.h.
https://github.com/llvm/llvm-project/commit/d8ca74176e25bd4080ee81982819e2ef7a36553f#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[Builtin] Unxfail tests for armhf
Summary:
Originally, a few tests fail for armhf target due to:
1) COMPILER_RT_ARMHF_TARGET was not set when building the lib
2) COMPILER_RT_ABI should not be defined as `__attribute__((pcs("aapcs")))` for armhf when building for both lib and tests
This addresshttps://bugs.llvm.org//show_bug.cgi?id=32261
mulsc3_test.c is a newly exposed issue, which will be addressed separately.
Reviewers: rengolin, compnerd
Reviewed By: compnerd
Subscribers: aemerson, llvm-commits, mgorny
Differential Revision:https://reviews.llvm.org/D31448
llvm-svn: 298974
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 303138:
https://github.com/llvm/llvm-project/commit/44c45717b9e9f3dc194508d2eeeb8599a9d76949#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[PATCH] builtins: use reserved spelling (NFC)
llvm-svn: 303138
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 303188:
https://github.com/llvm/llvm-project/commit/36ac5ddff7377586390a71cb3261f0a40d274308#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[PATCH] builtins: expand out the AEABI function stubs
These actually may change calling conventions. We cannot simply provide
function aliases as the aliased function may have a different calling
convention. Provide a forwarding function instead to permit the
compiler to synthesize the calling convention adjustment thunk.
Remove the `ARM_EABI_FNALIAS` macro as that is not safe to use.
Resolves PR33030!
llvm-svn: 303188
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 303207:
https://github.com/llvm/llvm-project/commit/4a45838d10085defac0f3b3003a5263e34536f3b#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[PATCH] builtins: fix guard __AEABI__ -> __ARM_EABI__
llvm-svn: 303207
PR port-arm/55897
Cherry-pick upstream commit llvm-svn: 314851:
https://github.com/llvm/llvm-project/commit/0d586d06a756b126a7eb43a21ecc12bd243d7cd8#diff-549f1733063df365663fe375f336034e33e16d6bf2826cd4f966045aeb136007
----
[PATCH] [compiler-rt] Add back ARM EABI aliases where legal.
r303188 removed all the uses of aliases for EABI functions from
compiler-rt, because some of them had mismatched calling conventions.
Obviously, we can't use aliases for functions which don't have the same
calling convention, but that's only an issue for floating-point
functions with the hardfloat ABI. In other cases, the stubs increase
size and reduce performance for no benefit.
This patch adds back the aliases, with appropriate checks to make sure
they're only used in cases where the calling convention matches.
llvm-svn: 314851
PR port-arm/55897
Fix ABI mismatch for armhf runtime routines for floating-point arithmetics;
For hard-float arm variants, provide
(1) generic runtime routines with correct calling convention, and
(2) EABI runtime routines at the same time.
I've confirmed that no binary changes for kernels.
LGTM by skrll
To generate a diff of this commit:
cvs rdiff -u -r1.35 -r1.35.6.1 src/lib/libc/compiler_rt/Makefile.inc
cvs rdiff -u -r1.10 -r1.10.18.1 src/lib/libm/compiler_rt/Makefile.inc
cvs rdiff -u -r0 -r1.1.8.2 src/sys/external/bsd/compiler_rt/abi.mk
cvs rdiff -u -r1.1.1.3 -r1.1.1.3.34.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/adddf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/extendsfdf2.c
cvs rdiff -u -r1.1.1.4 -r1.1.1.4.34.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/addsf3.c
cvs rdiff -u -r1.1.1.1 -r1.1.1.1.40.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/ashldi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/ashrdi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatdisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatundisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/lshrdi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/muldi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/negsf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/udivsi3.c
cvs rdiff -u -r1.1.1.4 -r1.1.1.4.22.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/comparedf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/comparesf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/int_lib.h
cvs rdiff -u -r1.1.1.3 -r1.1.1.3.36.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/divdf3.c
cvs rdiff -u -r1.1.1.2 -r1.1.1.2.40.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/divsf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/divsi3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatsidf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatsisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatunsidf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatunsisf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/negdf2.c
cvs rdiff -u -r1.1.1.1 -r1.1.1.1.26.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/extendhfsf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/truncdfhf2.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/truncsfhf2.c
cvs rdiff -u -r1.1.1.3 -r1.1.1.3.22.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixdfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixdfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/subdf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/subsf3.c
cvs rdiff -u -r1.1.1.2 -r1.1.1.2.22.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixsfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixsfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunsdfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunsdfsi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunssfdi.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/fixunssfsi.c
cvs rdiff -u -r1.2 -r1.2.22.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatdidf.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/floatundidf.c
cvs rdiff -u -r1.1.1.2 -r1.1.1.2.34.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/muldf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/mulsf3.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/truncdfsf2.c
cvs rdiff -u -r1.1.1.1 -r1.1.1.1.26.1 \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_cdcmpeq_check_nan.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_cfcmpeq_check_nan.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_div0.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_drsub.c \
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm/aeabi_frsub.c
cvs rdiff -u -r1.9 -r1.9.4.1 src/sys/lib/libkern/Makefile.compiler-rt
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: pending-pullups->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 08 Aug 2021 19:22:08 +0000
State-Changed-Why:
Pullups completed; thanks all
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home