NetBSD Problem Report #56093

From www@netbsd.org  Sat Apr  3 20:09:42 2021
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id DA2DB1A9217
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  3 Apr 2021 20:09:42 +0000 (UTC)
Message-Id: <20210403200941.69A921A923B@mollari.NetBSD.org>
Date: Sat,  3 Apr 2021 20:09:41 +0000 (UTC)
From: vezhlys@gmail.com
Reply-To: vezhlys@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Update openjdk11 wrappers for removed/added tools
X-Send-Pr-Version: www-1.0

>Number:         56093
>Category:       pkg
>Synopsis:       Update openjdk11 wrappers for removed/added tools
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 03 20:10:00 +0000 2021
>Closed-Date:    Tue Apr 27 10:48:37 +0000 2021
>Last-Modified:  Tue Apr 27 20:40:01 +0000 2021
>Originator:     Andrius V
>Release:        pkgsrc-2021Q1
>Organization:
>Environment:
>Description:
JAVA_WRAPPERS list needs to be updated for lang/openjdk11, lang/adoptopenjdk11-bin, lang/openjdk-bin packages' Makefiles. Some tools were removed for various reasons and some were added after openjdk8 to facilitate new features, thus the list of them which was likely copied from previous release is incorrect. Ideally, the list should probably be synchronized with openjdk11/bin binaries. However, I prepared a patch for lang/openjdk11 with the list of those, which are still available in later releases (up to jdk16). I am also not sure why jhsdb is missing from this specific build but it may need to be added to  lang/adoptopenjdk11 and lang/openjdk-bin, those seem to have it according to PLIST.

Removed tools causing wrappers to fail on execution:
orbd
servertool
tnameserv
policytool
jhat
javah (replaced by javac -h)

Documentation for the tools can be found in below links (for most of them):
https://docs.oracle.com/en/java/javase/11/tools/
https://docs.oracle.com/en/java/javase/16/docs/specs/man/index.html

Regards,
Andrius V
>How-To-Repeat:

>Fix:
Index: lang/openjdk11/Makefile
==================================================================
--- lang/openjdk11/Makefile
+++ lang/openjdk11/Makefile
@@ -16,12 +16,15 @@
 DISTFILES=     ${DEFAULT_DISTFILES}
 EXTRACT_ONLY=  ${DISTNAME}${EXTRACT_SUFX}

 JAVA_NAME=     openjdk11
 JAVA_HOME=     ${PREFIX}/java/${JAVA_NAME}
-JAVA_WRAPPERS= jar java javac javadoc javah javap jcmd jhat jmap jps jstack \
-               keytool orbd policytool rmid rmiregistry servertool tnameserv
+JAVA_WRAPPERS=  jar jarsigner java javac javadoc javap jcmd jconsole jdb \
+               jdeprscan jdeps jfr jimage jinfo jlink jmap jmod jps \
+               jrunscript jshell jstack jstat jstatd keytool rmid \
+               rmiregistry serialver
+

 BUILD_DEPENDS+=                mozilla-rootcerts>=1.0.20140820nb2:../../security/mozilla-rootcerts

 GNU_CONFIGURE=         yes
 GNU_CONFIGURE_STRICT=  no # generates the configure script during the build

Index: lang/openjdk11/PLIST
==================================================================
--- lang/openjdk11/PLIST
+++ lang/openjdk11/PLIST
@@ -1,24 +1,33 @@
 @comment $NetBSD: PLIST,v 1.8 2021/02/01 15:51:55 ryoon Exp $
 bin/openjdk11-jar
+bin/openjdk11-jarsigner
 bin/openjdk11-java
 bin/openjdk11-javac
 bin/openjdk11-javadoc
-bin/openjdk11-javah
 bin/openjdk11-javap
 bin/openjdk11-jcmd
-bin/openjdk11-jhat
+bin/openjdk11-jconsole
+bin/openjdk11-jdb
+bin/openjdk11-jdeprscan
+bin/openjdk11-jdeps
+bin/openjdk11-jfr
+bin/openjdk11-jimage
+bin/openjdk11-jinfo
+bin/openjdk11-jlink
 bin/openjdk11-jmap
+bin/openjdk11-jmod
 bin/openjdk11-jps
+bin/openjdk11-jrunscript
+bin/openjdk11-jshell
 bin/openjdk11-jstack
+bin/openjdk11-jstat
+bin/openjdk11-jstatd
 bin/openjdk11-keytool
-bin/openjdk11-orbd
-bin/openjdk11-policytool
 bin/openjdk11-rmid
 bin/openjdk11-rmiregistry
-bin/openjdk11-servertool
-bin/openjdk11-tnameserv
+bin/openjdk11-serialver
 ${PLIST.aot}java/openjdk11/bin/jaotc${DBGEXT}
 ${PLIST.aot}java/openjdk11/bin/jaotc
 java/openjdk11/bin/jar
 java/openjdk11/bin/jar${DBGEXT}
 java/openjdk11/bin/jarsigner

>Release-Note:

>Audit-Trail:
From: "Ryo ONODERA" <ryoon@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56093 CVS commit: pkgsrc/lang
Date: Sat, 10 Apr 2021 18:21:45 +0000

 Module Name:	pkgsrc
 Committed By:	ryoon
 Date:		Sat Apr 10 18:21:45 UTC 2021

 Modified Files:
 	pkgsrc/lang/adoptopenjdk11-bin: Makefile PLIST.darwin-x86_64
 	    PLIST.linux-x86_64
 	pkgsrc/lang/openjdk-bin: Makefile PLIST.linux-x86_64 distinfo
 	pkgsrc/lang/openjdk11: Makefile PLIST

 Log Message:
 adoptopenjdk11-bin, openjdk-bin, openjdk11: Update wrappers

 Fix PR pkg/56093.
 Bump PKGREVISIONs.
 And update openjdk-bin to 16.


 To generate a diff of this commit:
 cvs rdiff -u -r1.6 -r1.7 pkgsrc/lang/adoptopenjdk11-bin/Makefile
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/lang/adoptopenjdk11-bin/PLIST.darwin-x86_64
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/lang/adoptopenjdk11-bin/PLIST.linux-x86_64
 cvs rdiff -u -r1.6 -r1.7 pkgsrc/lang/openjdk-bin/Makefile
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/lang/openjdk-bin/PLIST.linux-x86_64 \
     pkgsrc/lang/openjdk-bin/distinfo
 cvs rdiff -u -r1.31 -r1.32 pkgsrc/lang/openjdk11/Makefile
 cvs rdiff -u -r1.8 -r1.9 pkgsrc/lang/openjdk11/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 26 Apr 2021 19:06:25 +0000
State-Changed-Why:
Looks good?


From: Andrius V <vezhlys@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, 
	maya@netbsd.org
Subject: Re: pkg/56093 (Update openjdk11 wrappers for removed/added tools)
Date: Mon, 26 Apr 2021 23:17:04 +0300

 --000000000000e9b3a205c0e5d43b
 Content-Type: text/plain; charset="UTF-8"

 Hi,

 Yes, all non working obsolete tools were removed, thanks. Can be closed I
 believe.

 Regards,
 Andrius V

 On Mon, Apr 26, 2021 at 10:06 PM <maya@netbsd.org> wrote:

 > Synopsis: Update openjdk11 wrappers for removed/added tools
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: maya@NetBSD.org
 > State-Changed-When: Mon, 26 Apr 2021 19:06:25 +0000
 > State-Changed-Why:
 > Looks good?
 >
 >
 >
 >

 --000000000000e9b3a205c0e5d43b
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 <div dir=3D"ltr"><div>Hi, <br></div><div><br></div><div>Yes, all non workin=
 g obsolete tools were removed, thanks. Can be closed I believe.<br></div><d=
 iv><br></div><div>Regards,</div><div>Andrius V<br></div></div><br><div clas=
 s=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Apr 26, 202=
 1 at 10:06 PM &lt;<a href=3D"mailto:maya@netbsd.org" target=3D"_blank">maya=
 @netbsd.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
 =3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
 -left:1ex">Synopsis: Update openjdk11 wrappers for removed/added tools<br>
 <br>
 State-Changed-From-To: open-&gt;feedback<br>
 State-Changed-By: maya@NetBSD.org<br>
 State-Changed-When: Mon, 26 Apr 2021 19:06:25 +0000<br>
 State-Changed-Why:<br>
 Looks good?<br>
 <br>
 <br>
 <br>
 </blockquote></div>

 --000000000000e9b3a205c0e5d43b--

State-Changed-From-To: feedback->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Tue, 27 Apr 2021 10:48:37 +0000
State-Changed-Why:
Reported fixed.
I hesitate about pullups because the commit is going to be different for stable, and it is a non-leaf package. I get the impression that it doesn't bother many people.
Thanks for the patch.


From: Andrius V <vezhlys@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, 
	maya@netbsd.org
Subject: Re: pkg/56093 (Update openjdk11 wrappers for removed/added tools)
Date: Tue, 27 Apr 2021 23:37:05 +0300

 --000000000000563af405c0fa3a46
 Content-Type: text/plain; charset="UTF-8"

 Yes, I think it's fine to leave it for the next quarterly release. All
 those tools are accessible anyway (just not in PATH) and yes, since it was
 not noticed (or was ignored) for quite some time, probably it is not
 exactly a big deal, just something to take in mind for the possible future
 java upgrades (new LTS release is coming this autumn or those up to date
 Linux only packages).

 On Tue, Apr 27, 2021 at 1:48 PM <maya@netbsd.org> wrote:

 > Synopsis: Update openjdk11 wrappers for removed/added tools
 >
 > State-Changed-From-To: feedback->closed
 > State-Changed-By: maya@NetBSD.org
 > State-Changed-When: Tue, 27 Apr 2021 10:48:37 +0000
 > State-Changed-Why:
 > Reported fixed.
 > I hesitate about pullups because the commit is going to be different for
 > stable, and it is a non-leaf package. I get the impression that it doesn't
 > bother many people.
 > Thanks for the patch.
 >
 >
 >
 >

 --000000000000563af405c0fa3a46
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 <div dir=3D"ltr">Yes, I think it&#39;s fine to leave it for the next quarte=
 rly release. All those tools are accessible anyway (just not in PATH) and y=
 es, since it was not noticed (or was ignored) for quite some time, probably=
  it is not exactly a big deal, just something to take in mind for the possi=
 ble future java upgrades (new LTS release is coming this autumn or those up=
  to date Linux only packages).<br></div><br><div class=3D"gmail_quote"><div=
  dir=3D"ltr" class=3D"gmail_attr">On Tue, Apr 27, 2021 at 1:48 PM &lt;<a hr=
 ef=3D"mailto:maya@netbsd.org" target=3D"_blank">maya@netbsd.org</a>&gt; wro=
 te:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px =
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Synopsis: Up=
 date openjdk11 wrappers for removed/added tools<br>
 <br>
 State-Changed-From-To: feedback-&gt;closed<br>
 State-Changed-By: maya@NetBSD.org<br>
 State-Changed-When: Tue, 27 Apr 2021 10:48:37 +0000<br>
 State-Changed-Why:<br>
 Reported fixed.<br>
 I hesitate about pullups because the commit is going to be different for st=
 able, and it is a non-leaf package. I get the impression that it doesn&#39;=
 t bother many people.<br>
 Thanks for the patch.<br>
 <br>
 <br>
 <br>
 </blockquote></div>

 --000000000000563af405c0fa3a46--

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.