NetBSD Problem Report #56114

From tsutsui@ceres.dti.ne.jp  Sat Apr 17 13:47:42 2021
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B47041A923C
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 17 Apr 2021 13:47:41 +0000 (UTC)
Message-Id: <202104171347.13HDlWYL026575@ceres.dti.ne.jp>
Date: Sat, 17 Apr 2021 22:47:32 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: 2021Q1 gsettings in glib2 refers /var/lib/dbus, not /var/db/dbus
X-Send-Pr-Version: 3.95

>Number:         56114
>Category:       pkg
>Synopsis:       2021Q1 gsettings in glib2 refers /var/lib/dbus, not /var/db/dbus
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 17 13:50:00 +0000 2021
>Closed-Date:    Sat Apr 24 15:56:18 +0000 2021
>Last-Modified:  Sat Apr 24 15:56:18 +0000 2021
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.1 and pkgsrc-2021Q1
>Organization:
>Environment:
System: NetBSD mirage 9.1 NetBSD 9.1 (GENERIC) #0: Sun Oct 18 19:24:30 UTC 2020 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
gsettings from glib2-2.66.8 in pkgsrc-2021Q1 refers /var/lib/dbus:
---
% ktrace gsettings set org.freedesktop.ibus.general.hotkey triggers "[]"
% kdump

[...]

  2828      4 gsettings CALL  __stat50(0x7252743802c0,0x7252707dfca0)
  2828      4 gsettings NAMI  "/home/mikutter/.cache/bus"
  2828      4 gsettings RET   __stat50 -1 errno 2 No such file or directory
  2828      4 gsettings CALL  issetugid
  2828      4 gsettings RET   issetugid 0
  2828      4 gsettings CALL  open(0x72527455353e,0,0)
  2828      4 gsettings NAMI  "/var/lib/dbus/machine-id"
  2828      4 gsettings RET   open -1 errno 2 No such file or directory

---

while dbus in pkgsrc-2021Q1 still refers /var/db/dbus
(changed to refer /var/lib/dbus after 2021Q1 branch):
 http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/sysutils/dbus/Makefile#rev1.124
 https://mail-index.netbsd.org/pkgsrc-changes/2021/03/29/msg231497.html
---
dbus: switch from pkgsrc-only var/db/dbus to default var/lib/dbus

This path is what other code, notably glib2, expects.
---

Note gsettings from glib2-2.66.4 in pkgsrc-2020Q4 refers /var/db/dbus:
---
 10776      4 gsettings CALL  __stat50(0xb0c36260,0xb03dfd7c)
 10776      4 gsettings NAMI  "/home/tsutsui/.cache/bus"
 10776      4 gsettings RET   __stat50 -1 errno 2 No such file or directory
 10776      4 gsettings CALL  issetugid
 10776      4 gsettings RET   issetugid 0
 10776      4 gsettings CALL  open(0xb126154a,0,0xb0c380a0)
 10776      4 gsettings NAMI  "/var/db/dbus/machine-id"
 10776      4 gsettings RET   open 10/0xa
 10776      4 gsettings CALL  __fstat50(0xa,0xb03dfc58)
 10776      4 gsettings RET   __fstat50 0
 10776      4 gsettings CALL  read(0xa,0xb0c2cae0,0x21)
 10776      4 gsettings GIO   fd 10 read 33 bytes
--- 

BTW, glib2 was reverted from 2.68.8 to 2.68.0 after 2021Q1 branch??
 https://mail-index.netbsd.org/pkgsrc-changes/2021/03/30/msg231523.html

>How-To-Repeat:
See above.

>Fix:
No idea.
- patch glib2 in pkgsrc-2021Q1 (2.68.8? 2.68.0?) to refer /var/db/dbus?
- pull all /var/db -> /var/lib changes from HEAD to 2021Q1?
 https://mail-index.netbsd.org/pkgsrc-changes/2021/03/29/msg231497.html
 https://mail-index.netbsd.org/pkgsrc-changes/2021/03/30/msg231547.html
 https://mail-index.netbsd.org/pkgsrc-changes/2021/03/30/msg231548.html
 https://mail-index.netbsd.org/pkgsrc-changes/2021/03/30/msg231550.html
 https://mail-index.netbsd.org/pkgsrc-changes/2021/03/30/msg231566.html
 https://mail-index.netbsd.org/pkgsrc-changes/2021/03/30/msg231569.html
 (not sure if these are enough)

---
Izumi Tsutsui

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/56114: 2021Q1 gsettings in glib2 refers /var/lib/dbus, not
 /var/db/dbus
Date: Sat, 17 Apr 2021 16:00:59 +0200

 On Sat, Apr 17, 2021 at 01:50:00PM +0000, Izumi Tsutsui wrote:
 > >Synopsis:       2021Q1 gsettings in glib2 refers /var/lib/dbus, not /var/db/dbus

 Yes, that's annoying, that's why I changed it in dbus.  I don't think
 I'll submit a pullup request though, since it affected quite a number
 of packages.

 > BTW, glib2 was reverted from 2.68.8 to 2.68.0 after 2021Q1 branch??
 >  https://mail-index.netbsd.org/pkgsrc-changes/2021/03/30/msg231523.html

 No, that's an update from 2.66.8 to 2.68.0.
  Thomas

From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@netbsd.org
Cc: wiz@NetBSD.org, tsutsui@ceres.dti.ne.jp
Subject: Re: pkg/56114: 2021Q1 gsettings in glib2 refers /var/lib/dbus, not/var/db/dbus
Date: Sat, 17 Apr 2021 23:18:50 +0900

 >  > >Synopsis:       2021Q1 gsettings in glib2 refers /var/lib/dbus, not /var/db/dbus
 >  
 >  Yes, that's annoying, that's why I changed it in dbus.  I don't think
 >  I'll submit a pullup request though, since it affected quite a number
 >  of packages.

 Anyway, at least ibus in 2021Q1 doen't work properly (in my liveimage).
 How can we fix it in the release branch?

 >  > BTW, glib2 was reverted from 2.68.8 to 2.68.0 after 2021Q1 branch??
 >  >  https://mail-index.netbsd.org/pkgsrc-changes/2021/03/30/msg231523.html
 >  
 >  No, that's an update from 2.66.8 to 2.68.0.

 Ah, my bad. I misread the "revert to adam's commit" message.

 ---
 Izumi Tsutsui

From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@netbsd.org
Cc: wiz@NetBSD.org, tsutsui@ceres.dti.ne.jp
Subject: Re: pkg/56114: 2021Q1 gsettings in glib2 refers /var/lib/dbus, not/var/db/dbus
Date: Sat, 17 Apr 2021 23:45:46 +0900

 > >  I'll submit a pullup request though, since it affected quite a number
 > >  of packages.
 > 
 > Anyway, at least ibus in 2021Q1 doen't work properly (in my liveimage).
 > How can we fix it in the release branch?

 This is caused by missed reverting Makefile rev 1.277:
  http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/glib2/Makefile#rev1.277
  http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/glib2/Makefile.diff?r1=1.276&r2=1.277
  https://mail-index.netbsd.org/pkgsrc-changes/2021/03/23/msg231355.html

 ---
 Izumi Tsutsui

From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@netbsd.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: Re: pkg/56114: 2021Q1 gsettings in glib2 refers /var/lib/dbus, not/var/db/dbus
Date: Sun, 18 Apr 2021 12:53:08 +0900

 >  This is caused by missed reverting Makefile rev 1.277:
 >   http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/glib2/Makefile#rev1.277
 >   http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/glib2/Makefile.diff?r1=1.276&r2=1.277
 >   https://mail-index.netbsd.org/pkgsrc-changes/2021/03/23/msg231355.html

 The following fix (properly revert Makefile r1.277 for 2.68.0 -> 2.66.8
 and bump PKGREVISION to denote incompatible changes) for 2021Q1 solves
 the problem.

 ---
 Index: devel/glib2/Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/glib2/Makefile,v
 retrieving revision 1.277
 diff -u -p -r1.277 Makefile
 --- devel/glib2/Makefile	22 Mar 2021 06:54:19 -0000	1.277
 +++ devel/glib2/Makefile	18 Apr 2021 03:49:11 -0000
 @@ -1,6 +1,7 @@
  # $NetBSD: Makefile,v 1.277 2021/03/22 06:54:19 adam Exp $

  .include "Makefile.common"
 +PKGREVISION=1

  CATEGORIES=	devel gnome
  COMMENT=	Some useful routines for C programming (glib2)
 @@ -43,6 +44,7 @@ SUBST_CLASSES+=		dbusdb
  SUBST_MESSAGE.dbusdb=	Adjust dbus machine uuid path to dbus package
  SUBST_STAGE.dbusdb=	pre-configure
  SUBST_FILES.dbusdb=	gio/gdbusconnection.c
 +SUBST_FILES.dbusdb=	gio/gdbusprivate.c
  SUBST_FILES.dbusdb+=	po/*.po
  SUBST_SED.dbusdb=	-e 's,/var/lib/dbus,${VARBASE}/db/dbus,g'



 ---
 Izumi Tsutsui

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/56114: 2021Q1 gsettings in glib2 refers /var/lib/dbus,
 not/var/db/dbus
Date: Sun, 18 Apr 2021 09:11:02 +0200

 On Sun, Apr 18, 2021 at 03:55:01AM +0000, Izumi Tsutsui wrote:
 >  The following fix (properly revert Makefile r1.277 for 2.68.0 -> 2.66.8
 >  and bump PKGREVISION to denote incompatible changes) for 2021Q1 solves
 >  the problem.

 Good catch! Please send this to the pkgsrc-releng team for pullup.

 Details for that are here:

 https://www.netbsd.org/developers/releng/pullups.html

 but basically it's just sending the patch to pullup-pkgsrc@

 Cheers,
  Thomas


State-Changed-From-To: open->pending-pullups
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Wed, 21 Apr 2021 15:44:03 +0000
State-Changed-Why:
[pullup-pkgsrc #6449]


From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56114 CVS commit: [pkgsrc-2021Q1] pkgsrc/devel/glib2
Date: Sat, 24 Apr 2021 13:09:41 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Sat Apr 24 13:09:41 UTC 2021

 Modified Files:
 	pkgsrc/devel/glib2 [pkgsrc-2021Q1]: Makefile

 Log Message:
 Pullup ticket #6449 - requested by tsutsui
 devel/glib2: fix for PR pkg/56114

 (via patch)


 To generate a diff of this commit:
 cvs rdiff -u -r1.277 -r1.277.2.1 pkgsrc/devel/glib2/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sat, 24 Apr 2021 15:56:18 +0000
State-Changed-Why:
Pulled up to pkgsrc-2021Q1.


>Unformatted:

Home	PR Database Search