NetBSD Problem Report #56146

From www@netbsd.org  Tue May  4 21:40:27 2021
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 86F631A9241
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  4 May 2021 21:40:27 +0000 (UTC)
Message-Id: <20210504214025.DFACA1A9244@mollari.NetBSD.org>
Date: Tue,  4 May 2021 21:40:25 +0000 (UTC)
From: jbglaw@lug-owl.de
Reply-To: jbglaw@lug-owl.de
To: gnats-bugs@NetBSD.org
Subject: mvme68k: sys/arch/mvme68k/stand/wrtvid/wrtvid.c:86:9: error: unknown type name 'uint8_t'
X-Send-Pr-Version: www-1.0

>Number:         56146
>Category:       port-mvme68k
>Synopsis:       mvme68k: sys/arch/mvme68k/stand/wrtvid/wrtvid.c:86:9: error: unknown type name 'uint8_t'
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-mvme68k-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 04 21:45:00 +0000 2021
>Closed-Date:    Sun May 09 09:08:35 +0000 2021
>Last-Modified:  Sun May 09 09:08:35 +0000 2021
>Originator:     Jan-Benedict Glaw
>Release:        HEAD (github mirror, as of b8c576565d95bb954b2dc0e3fbd5a2a56c594810)
>Organization:
>Environment:
Linux toolchaintest-host 5.9.0-2-amd64 #1 SMP Debian 5.9.6-1 (2020-11-08) x86_64 GNU/Linux
>Description:
I did:

./build.sh -U -O /var/lib/laminar/run/netbsd-mvme68k-m68k/9/obj -m mvme68k -a m68k tools

./build.sh -U -u -O /var/lib/laminar/run/netbsd-mvme68k-m68k/9/obj -m mvme68k -a m68k release

Breaks at:

cc -O   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -c -o wrtvid.lo.o    /var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c:86:9: error: unknown type name 'uint8_t'; did you mean 'u_int8_t'?
   86 | write32(uint8_t *vp, uint32_t value)
      |         ^~~~~~~
      |         u_int8_t
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c:86:22: error: unknown type name 'uint32_t'; did you mean 'u_int32_t'?
   86 | write32(uint8_t *vp, uint32_t value)
      |                      ^~~~~~~~
      |                      u_int32_t
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c:99:9: error: unknown type name 'uint8_t'; did you mean 'u_int8_t'?
   99 | write16(uint8_t *vp, uint16_t value)
      |         ^~~~~~~
      |         u_int8_t
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c:99:22: error: unknown type name 'uint16_t'; did you mean 'u_int16_t'?
   99 | write16(uint8_t *vp, uint16_t value)
      |                      ^~~~~~~~
      |                      u_int16_t
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c: In function 'main':
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c:110:2: error: unknown type name 'uint16_t'; did you mean 'u_int16_t'? 
  110 |  uint16_t len;
      |  ^~~~~~~~
      |  u_int16_t
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c:111:2: error: unknown type name 'uint8_t'; did you mean 'u_int8_t'?
  111 |  uint8_t *vid;
      |  ^~~~~~~
      |  u_int8_t
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c:138:9: error: 'uint16_t' undeclared (first use in this function); did you mean 'u_int16_t'?
  138 |  len = (uint16_t)((st.st_size + 255) / 256);
      |         ^~~~~~~~
      |         u_int16_t
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c:138:9: note: each undeclared identifier is reported only once for each function it appears in
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c:154:2: warning: implicit declaration of function 'write32'; did you mean 'write'? [-Wimplicit-func
tion-declaration]
  154 |  write32(&vid[VID_OSS_OFF], is_disk ? VID_OSS_DISK : VID_OSS_TAPE);
      |  ^~~~~~~
      |  write
/var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c:155:2: warning: implicit declaration of function 'write16'; did you mean 'write'? [-Wimplicit-function-declaration]
  155 |  write16(&vid[VID_OSL_OFF], len);
      |  ^~~~~~~
      |  write

*** Failed target:  wrtvid.lo
*** Failed command: cc -O -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -c -o wrtvid.lo.o /var/lib/laminar/run/netbsd-mvme68k-m68k/9/NetBSD-src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c
*** Error code 1


Probably caused by:

commit a07f7c80690d0af05ca7630aebc638f51f3185e1
Author: tsutsui <tsutsui@NetBSD.org>
Date:   Sat Jan 12 09:54:21 2008 +0000

    Misc cleanup:
    - KNF, ANSIfy, remove __P()
    - use __func__ to print function names
    - use __arraycount()
    - include "ioconf.h" for struct cfdriver
    - u_intNN_t -> uintNN_t
    - wrap long lines
    etc.






Though I wonder why NetBSD's daily build checks didn't catch this?
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56146 CVS commit: src
Date: Thu, 6 May 2021 13:23:36 +0000

 Module Name:	src
 Committed By:	rin
 Date:		Thu May  6 13:23:36 UTC 2021

 Modified Files:
 	src/share/mk: bsd.own.mk
 	src/sys/arch/mvme68k/stand: Makefile Makefile.booters
 	src/sys/arch/mvme68k/stand/wrtvid: Makefile wrtvid.c
 	src/tools: Makefile
 Added Files:
 	src/tools/mvme68k-wrtvid: Makefile

 Log Message:
 PR port-mvme68k/56146

 Build wrtvid as tools.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1246 -r1.1247 src/share/mk/bsd.own.mk
 cvs rdiff -u -r1.6 -r1.7 src/sys/arch/mvme68k/stand/Makefile
 cvs rdiff -u -r1.27 -r1.28 src/sys/arch/mvme68k/stand/Makefile.booters
 cvs rdiff -u -r1.12 -r1.13 src/sys/arch/mvme68k/stand/wrtvid/Makefile
 cvs rdiff -u -r1.9 -r1.10 src/sys/arch/mvme68k/stand/wrtvid/wrtvid.c
 cvs rdiff -u -r1.208 -r1.209 src/tools/Makefile
 cvs rdiff -u -r0 -r1.1 src/tools/mvme68k-wrtvid/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: rin@NetBSD.org
State-Changed-When: Thu, 06 May 2021 13:26:52 +0000
State-Changed-Why:
Can you try latest HEAD?

Please make sure to do ``./build.sh tools'' again.


From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: gnats-bugs@netbsd.org
Cc: port-mvme68k-maintainer@netbsd.org, netbsd-bugs@netbsd.org,
	gnats-admin@netbsd.org, rin@NetBSD.org
Subject: Re: port-mvme68k/56146 (mvme68k:
 sys/arch/mvme68k/stand/wrtvid/wrtvid.c:86:9: error: unknown type name
 'uint8_t')
Date: Sat, 8 May 2021 14:10:35 +0200

 --fhufcwosttcadkus
 Content-Type: text/plain; charset=utf-8
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable

 On Thu, 2021-05-06 13:26:52 +0000, rin@NetBSD.org <rin@NetBSD.org> wrote:
 > Synopsis: mvme68k: sys/arch/mvme68k/stand/wrtvid/wrtvid.c:86:9: error: un=
 known type name 'uint8_t'
 >=20
 > State-Changed-From-To: open->feedback
 > State-Changed-By: rin@NetBSD.org
 > State-Changed-When: Thu, 06 May 2021 13:26:52 +0000
 > State-Changed-Why:
 > Can you try latest HEAD?
 >=20
 > Please make sure to do ``./build.sh tools'' again.

 I started a fresh build, can be observed at
 http://toolchain.lug-owl.de:8080/jobs/netbsd-mvme68k-m68k/10 .

 Thanks a lot!

 Jan-Benedict

 --=20

 --fhufcwosttcadkus
 Content-Type: application/pgp-signature; name="signature.asc"

 -----BEGIN PGP SIGNATURE-----

 iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCYJZ/twAKCRAdvV51g5nh
 u4HHAJ9lxJmRZU6dCmyjnvLD0gSYF2xpIQCfZjm+kEuWELYQDsRvtA3052fBn4k=
 =La0/
 -----END PGP SIGNATURE-----

 --fhufcwosttcadkus--

State-Changed-From-To: feedback->closed
State-Changed-By: rin@NetBSD.org
State-Changed-When: Sun, 09 May 2021 09:08:35 +0000
State-Changed-Why:
Confirmed fixed. Thanks for report.


>Unformatted:

Home	PR Database Search