NetBSD Problem Report #56156

From www@netbsd.org  Fri May  7 16:23:06 2021
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BB9781A9262
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  7 May 2021 16:23:05 +0000 (UTC)
Message-Id: <20210507162304.6515A1A9263@mollari.NetBSD.org>
Date: Fri,  7 May 2021 16:23:04 +0000 (UTC)
From: scole_mail@gmx.com
Reply-To: scole_mail@gmx.com
To: gnats-bugs@NetBSD.org
Subject: print/electrix can no longer open pdf files
X-Send-Pr-Version: www-1.0

>Number:         56156
>Category:       pkg
>Synopsis:       print/electrix can no longer open pdf files
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ryoon
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 07 16:25:00 +0000 2021
>Closed-Date:    Tue Jul 06 23:47:35 +0000 2021
>Last-Modified:  Tue Jul 06 23:47:35 +0000 2021
>Originator:     scole_mail
>Release:        pkgsrc-2021Q1
>Organization:
none
>Environment:
NetBSD dstar.dstar.net 9.1_STABLE NetBSD 9.1_STABLE (GENERIC) #0: Fri Apr 30 09:44:29 PDT 2021  scole@dstar.dstar.net:/home/scole/nbsd/cvs/9_0/obj/sys/arch/amd64/compile/GENERIC amd64
>Description:
After upgrading to pkgsrc to 2021Q1, electrix-0.2.0nb72 can no longer open pdf files.  I get an error like
 "File type is not supported"
when trying to a view a pdf file.

From the configure stage, the check for the PDF viewing feature is failing now:
....
Checking for 'gcc' (c compiler)          : /usr/pkgsrc/print/electrix/work/.cwrapper/bin/gcc 
Checking for program glib-genmarshal     : /usr/pkg/bin/glib-genmarshal 
Checking for program perl                : /usr/pkgsrc/print/electrix/work/.tools/bin/perl 
Checking for 'glib-mkenums'              : /usr/pkg/bin/glib-mkenums 
Checking for program glib-compile-schemas : /usr/pkg/bin/glib-compile-schemas 
Checking for program pkg-config           : /usr/pkgsrc/print/electrix/work/.tools/bin/pkg-config 
Checking for 'gtk+-2.0' >= 2.20.0         : yes 
Checking for 'cairo'                      : yes 
Checking for feature PDF                  : not available 
Checking for feature PS                   : enabled 
Checking for feature NLS                  : enabled 
Checking for feature D-Bus                : enabled 
'configure' finished successfully (0.421s)

Apparently, there is a check in wscript for a "poppler-cairo" library, and it doesn't find it:
...
      conf.check_cfg (package = 'poppler-cairo', uselib_store = 'POPPLER_CAIRO', 
                      args = '--cflags --libs')

I don't understand all the nuance of poppler and pkgsrc, but there is a line about poppler-cairo in
pkgsrc/print/poppler/Makefile:7:PKGCONFIG_OVERRIDE+=	${WRKSRC}/poppler-cairo.pc.cmake

Here is a kludgy patch that allowed PDF support to be built by not looking for the poppler-cairo library since it might be included in the poppler package already:

--- work/electrix-0.2.0/wscript 2011-11-06 08:55:13.000000000 -0800
+++ /tmp/wscript        2021-05-07 09:12:41.292986686 -0700
@@ -47,11 +47,12 @@
     try:
       conf.check_cfg (package = 'poppler-glib', uselib_store = 'POPPLER_GLIB', 
                       atleast_version='0.12.0', args = '--cflags --libs')
-      conf.check_cfg (package = 'poppler-cairo', uselib_store = 'POPPLER_CAIRO', 
-                      args = '--cflags --libs')
+      #conf.check_cfg (package = 'poppler-cairo', uselib_store = 'POPPLER_CAIRO', 
+      #                args = '--cflags --libs')
     except:
       pass
-    if conf.env['HAVE_POPPLER_GLIB' and 'HAVE_POPPLER_CAIRO']:
+    #if conf.env['HAVE_POPPLER_GLIB' and 'HAVE_POPPLER_CAIRO']:
+    if conf.env['HAVE_POPPLER_GLIB']:
       message = 'enabled'
       conf.define ('ENABLE_PDF', 1)
       conf.env['ENABLE_PDF'] = 1

>How-To-Repeat:
install electrix, try to open a pdf
>Fix:
adjust electrix wscript/configure or PKGCONFIG_OVERRIDE in pkgsrc/print/poppler somehow to not check for poppler-cairo or actually check and find it

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->ryoon
Responsible-Changed-By: ryoon@NetBSD.org
Responsible-Changed-When: Fri, 07 May 2021 17:35:41 +0000
Responsible-Changed-Why:
I will take this.


From: "Ryo ONODERA" <ryoon@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56156 CVS commit: pkgsrc/print/electrix
Date: Fri, 7 May 2021 17:41:49 +0000

 Module Name:	pkgsrc
 Committed By:	ryoon
 Date:		Fri May  7 17:41:49 UTC 2021

 Modified Files:
 	pkgsrc/print/electrix: Makefile distinfo
 Added Files:
 	pkgsrc/print/electrix/patches: patch-wscript

 Log Message:
 electrix: Fix PDF support with recent print/poppler

 Fix PR kern/56156.
 poppler-cairo.pc is already removed from print/poppler.
 Remove poppler-cairo detection and use from WAF wscript.
 Bump PKGREVISION.


 To generate a diff of this commit:
 cvs rdiff -u -r1.81 -r1.82 pkgsrc/print/electrix/Makefile
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/print/electrix/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/print/electrix/patches/patch-wscript

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: ryoon@NetBSD.org
State-Changed-When: Fri, 07 May 2021 17:52:46 +0000
State-Changed-Why:
I have commited modified your patch.
Could you confirm?


From: scole_mail <scole_mail@gmx.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/56156 (print/electrix can no longer open pdf files)
Date: Fri, 07 May 2021 15:43:42 -0700

 ryoon@NetBSD.org writes:

 > Synopsis: print/electrix can no longer open pdf files
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: ryoon@NetBSD.org
 > State-Changed-When: Fri, 07 May 2021 17:52:46 +0000
 > State-Changed-Why:
 > I have commited modified your patch.
 > Could you confirm?

 I updated with your changes for poppler and electrix, and was able to
 view pdf files again.

 Thank you very much for the quick response.

State-Changed-From-To: feedback->open
State-Changed-By: scole@NetBSD.org
State-Changed-When: Mon, 05 Jul 2021 07:46:46 -0700
State-Changed-Why:
feedback provided


From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/56156 (print/electrix can no longer open pdf files)
Date: Tue, 6 Jul 2021 16:23:43 +0000

 On Mon, Jul 05, 2021 at 02:46:46PM +0000, scole@NetBSD.org wrote:
  > Synopsis: print/electrix can no longer open pdf files
  > 
  > State-Changed-From-To: feedback->open
  > State-Changed-By: scole@NetBSD.org
  > State-Changed-When: Mon, 05 Jul 2021 07:46:46 -0700
  > State-Changed-Why:
  > feedback provided

 Looks to me like the changes were committed, so shouldn't the state be
 "closed"? 

 -- 
 David A. Holland
 dholland@netbsd.org

From: scole_mail <scole_mail@gmx.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/56156 (print/electrix can no longer open pdf files)
Date: Tue, 06 Jul 2021 09:47:33 -0700

 David Holland <dholland-pbugs@netbsd.org> writes:
 >
 >  Looks to me like the changes were committed, so shouldn't the state be
 >  "closed"?
 >

 =46rom my perspective (the submitter), closing it is fine with me.

 I just moved it to "open" to disable email reminders about missing
 feedback and wasn't certain if was left open for any other particular
 reason...

 Thanks

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 06 Jul 2021 23:47:35 +0000
State-Changed-Why:
confirmed fixed, thanks.

around here it's usually safe to assume that anything left open was
left open by accident.


>Unformatted:

Home	PR Database Search