NetBSD Problem Report #56240

From www@netbsd.org  Mon Jun  7 08:58:00 2021
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 0BDCE1A921F
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  7 Jun 2021 08:58:00 +0000 (UTC)
Message-Id: <20210607085758.E05F61A9239@mollari.NetBSD.org>
Date: Mon,  7 Jun 2021 08:57:58 +0000 (UTC)
From: prlw1@cam.ac.uk
Reply-To: prlw1@cam.ac.uk
To: gnats-bugs@NetBSD.org
Subject: octave 6.2.0 fails to build on NetBSD-current
X-Send-Pr-Version: www-1.0

>Number:         56240
>Category:       pkg
>Synopsis:       octave 6.2.0 fails to build on NetBSD-current
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 07 09:00:01 +0000 2021
>Closed-Date:    Sat Jun 19 10:46:50 +0000 2021
>Last-Modified:  Sat Jun 19 10:46:50 +0000 2021
>Originator:     Patrick Welche
>Release:        pkgsrc of 3 June 2021  (no octave change 7 June)
>Organization:
>Environment:
NetBSD-9.99.83/amd64
>Description:
octave 6.2.0 build fails with

  CXX      libinterp/corefcn/libcorefcn_la-getrusage.lo
libinterp/corefcn/file-io.cc: In function 'octave::stream do_stream_open(const string&, const string&, const string&, std::string, int&)':
libinterp/corefcn/file-io.cc:409:37: error: invalid conversion from 'void*' to 'iconv_t' {aka '__tag_iconv_t*'} [-fpermissive]
  409 |         octave_iconv_close_wrapper (codec);
      |                                     ^~~~~
      |                                     |
      |                                     void*
In file included from libinterp/corefcn/file-io.cc:56:
./liboctave/wrappers/iconv-wrappers.h:39:37: note:   initializing argument 1 of 'int octave_iconv_close_wrapper(iconv_t)'
   39 | octave_iconv_close_wrapper (iconv_t cd);
      |                             ~~~~~~~~^~
  CXX      libinterp/corefcn/libcorefcn_la-givens.lo
  CXX      libinterp/corefcn/libcorefcn_la-gl-render.lo
  CXX      libinterp/corefcn/libcorefcn_la-gl2ps-print.lo
gmake[2]: *** [Makefile:18865: libinterp/corefcn/libcorefcn_la-file-io.lo] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[2]: Leaving directory '/tmp/pkgsrc/math/octave/work.x86_64/octave-6.2.0'
gmake[1]: *** [Makefile:27517: all-recursive] Error 1
gmake[1]: Leaving directory '/tmp/pkgsrc/math/octave/work.x86_64/octave-6.2.0'
gmake: *** [Makefile:11142: all] Error 2
*** Error code 2

>How-To-Repeat:
cd /usr/pkgsrc/math/octave
make
>Fix:

>Release-Note:

>Audit-Trail:
From: Niclas Rosenvik <nros@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/56240: octave 6.2.0 fails to build on NetBSD-current
Date: Mon, 7 Jun 2021 13:03:31 +0200

 Just looked around a little. Does it compile correctly if you compile
 without patch-liboctave_wrapper_iconv-wrappers.h ?
 They seem to have fixed the iconv_t conflict:
 https://savannah.gnu.org/bugs/?func=detailitem&item_id=60162
 I think our patch reintroduces it.

From: "Niclas Rosenvik" <nros@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56240 CVS commit: pkgsrc/math/octave
Date: Mon, 14 Jun 2021 22:16:33 +0000

 Module Name:	pkgsrc
 Committed By:	nros
 Date:		Mon Jun 14 22:16:33 UTC 2021

 Modified Files:
 	pkgsrc/math/octave: Makefile PLIST distinfo
 Added Files:
 	pkgsrc/math/octave/patches: patch-liboctave_wrappers_iconv-wrappers.c
 Removed Files:
 	pkgsrc/math/octave/patches: patch-libinterp_corefcn_input.cc
 	    patch-liboctave_wrappers_iconv-wrappers.h

 Log Message:
 unbreak octave on NetBSD

 Change the way iconv_t void* conflict is handled
 using a patch from upstream to fix PR pkg/56240 .
 Due to the above remove
 patch-libinterp_corefcn_input.cc and
 patch-liboctave_wrappers_iconv-wrappers.h .
 Execute autoconf in the configuration step so that
 patch-configure.ac and patch-m4_acinclude.m4 is
 actually used.
 Change the PLIST so that -gnu is not used
 references in patch-m4_acinclude.m4 mentions this.
 Explicitly don't generate any docs since
 generation octave.pdf breaks and it already exists.
 Install info and man pages manually since they are
 not installed due to docs not being generated.
 Bump pkgrevision due to PLIST change.


 To generate a diff of this commit:
 cvs rdiff -u -r1.220 -r1.221 pkgsrc/math/octave/Makefile
 cvs rdiff -u -r1.35 -r1.36 pkgsrc/math/octave/PLIST
 cvs rdiff -u -r1.59 -r1.60 pkgsrc/math/octave/distinfo
 cvs rdiff -u -r1.2 -r0 \
     pkgsrc/math/octave/patches/patch-libinterp_corefcn_input.cc
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/math/octave/patches/patch-liboctave_wrappers_iconv-wrappers.c
 cvs rdiff -u -r1.1 -r0 \
     pkgsrc/math/octave/patches/patch-liboctave_wrappers_iconv-wrappers.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Fri, 18 Jun 2021 22:03:52 +0000
State-Changed-Why:
fixed?


State-Changed-From-To: feedback->closed
State-Changed-By: prlw1@NetBSD.org
State-Changed-When: Sat, 19 Jun 2021 10:46:50 +0000
State-Changed-Why:
Fixed by nros@ - thanks!


>Unformatted:

Home	PR Database Search