NetBSD Problem Report #56599

From www@netbsd.org  Mon Jan  3 00:42:30 2022
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 476901A9239
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  3 Jan 2022 00:42:30 +0000 (UTC)
Message-Id: <20220103004229.623961A923A@mollari.NetBSD.org>
Date: Mon,  3 Jan 2022 00:42:29 +0000 (UTC)
From: uwe@stderr.spb.ru
Reply-To: uwe@stderr.spb.ru
To: gnats-bugs@NetBSD.org
Subject: librump has unresolved symbols from rumpns
X-Send-Pr-Version: www-1.0

>Number:         56599
>Category:       kern
>Synopsis:       librump has unresolved symbols from rumpns
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 03 00:45:00 +0000 2022
>Last-Modified:  Sun Apr 23 09:55:01 +0000 2023
>Originator:     Valery Ushakov
>Release:        NetBSD-9.99.92
>Organization:
>Environment:
NetBSD nb 9.99.92 NetBSD 9.99.92 (GENERIC) #0: Thu Nov 18 15:58:42 MSK 2021  uwe@majava:/home/uwe/work/netbsd/cvs/src/sys/arch/amd64/compile/GENERIC amd64
>Description:
librump should be self-contained w.r.t. symbols in rumpns namespace,
i.e.

  $ nm -u /usr/lib/librump.so | grep rumpns
  $

should be empty.  But on current we have quite a few dependencies
that snuck in:

  $ nm -u librump.so | grep rumpns
                   U rumpns_dead_vnodeop_p
                   U rumpns_fs_filtops
                   U rumpns_holdrelel
                   U rumpns_pnbuf_cache
                   U rumpns_ubc_uiomove
                   U rumpns_uvm_vnodeops
                   U rumpns_vhold
                   U rumpns_vn_lock

I haven't checked all of these, but e.g. 

  sys_descrip.c,v 1.38 2021/09/11 10:09:13 riastradh
  vnode_if.c,v 1.115 2021/10/20 03:13:14 thorpej

are some of the offenders.

We probably get away with it b/c most rump tests in the tree link with
-lrumpvfs.  Linking them statically will probably fail b/c of
cross-lib dependencies (I haven't tried).

I noticed this b/c I'm rumpifying wscons vt100 emulation and it's
self-contained and should not need anything besides -lrump -lrumpuser,
but I have to also link with -lrumpvfs -lrumpvfs_nofifofs

>How-To-Repeat:
$ nm -u librump.so | grep rumpns

>Fix:

>Release-Note:

>Audit-Trail:

From: Valery Ushakov <uwe@stderr.spb.ru>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/56599: librump has unresolved symbols from rumps
Date: Mon, 3 Jan 2022 13:21:43 +0300

 From a quick look

 * rumpns_dead_vnodeop_p, rumpns_fs_filtops, rumpns_holdrelel, rumpns_vhold

   sys/kern/vnode_if.c
   revision 1.115
   date: 2021-10-20 06:13:14 +0300;  author: thorpej;  state: Exp;  lines: +217 -6;  commitid: XpjA545zNtExUudD;
   Regen for: Overhaul of the EVFILT_VNODE kevent(2) filter:


 * rumpns_pnbuf_cache

   sys/kern/vfs_init.c
   revision 1.49
   date: 2019-03-28 21:12:24 +0300;  author: maxv;  state: Exp;  lines: +4 -2;  commitid: vnTt10POeShq0ahB;
   branches:  1.49.6;
   Move pnbuf_cache into vfs_init.c, where it belongs.


 * rumpns_ubc_uiomove

   sys/kern/kern_ksyms.c
   revision 1.103
   date: 2021-09-11 13:09:31 +0300;  author: riastradh;  state: Exp;  lines: +437 -161;  commitid: wn64oCdGYyW8tw8D;
   ksyms(4): Take a complete snapshot on each open.


 * rumpns_uvm_vnodeops

   TODO: sys/rump/librump/rumpkern/vm.c - fallout from some macro change?


 * rumpns_vn_lock

   sys_descrip.c,v 1.38 2021/09/11 10:09:13 riastradh

From: "Valeriy E. Ushakov" <uwe@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56599 CVS commit: src
Date: Sun, 23 Apr 2023 02:01:33 +0000

 Module Name:	src
 Committed By:	uwe
 Date:		Sun Apr 23 02:01:33 UTC 2023

 Modified Files:
 	src: build.sh

 Log Message:
 build.sh: tweak rumptest and RUMP_LIBSETS

 Use --no-whole-archive to keep us as honest as currently possible.
 PR kern/56599


 To generate a diff of this commit:
 cvs rdiff -u -r1.366 -r1.367 src/build.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Valeriy E. Ushakov" <uwe@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56599 CVS commit: src
Date: Sun, 23 Apr 2023 09:54:15 +0000

 Module Name:	src
 Committed By:	uwe
 Date:		Sun Apr 23 09:54:15 UTC 2023

 Modified Files:
 	src: build.sh

 Log Message:
 build.sh: drop -lrumpdev hack introduced in previous

 The existing trick in sys/rump/librump/rumpdev/rump_dev.c was not
 updated after the renames in the kernel.  kudos to riastradh.

 PR kern/56599


 To generate a diff of this commit:
 cvs rdiff -u -r1.367 -r1.368 src/build.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search