NetBSD Problem Report #56633

From www@netbsd.org  Sun Jan 16 19:42:29 2022
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 582E71A9239
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 16 Jan 2022 19:42:29 +0000 (UTC)
Message-Id: <20220116194227.F030E1A923A@mollari.NetBSD.org>
Date: Sun, 16 Jan 2022 19:42:27 +0000 (UTC)
From: pekdon@gmail.com
Reply-To: pekdon@gmail.com
To: gnats-bugs@NetBSD.org
Subject: ffmpeg4 fails to build on Solaris 10
X-Send-Pr-Version: www-1.0

>Number:         56633
>Category:       pkg
>Synopsis:       ffmpeg4 fails to build on Solaris 10
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    solaris-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 16 19:45:00 +0000 2022
>Closed-Date:    Mon May 23 00:36:24 +0000 2022
>Last-Modified:  Mon May 23 00:36:24 +0000 2022
>Originator:     Claes Nästén
>Release:        trunk 2022-01-01
>Organization:
>Environment:
SunOS 5.10 i86pc i386 i86pc
>Description:
Building ffmpeg4 fails on Solaris 10, due to missing -lrt AND if using mksh as shell the version setup fails causing .so. files to be created instead of .so.X.X.X
>How-To-Repeat:
Build ffmpeg4 on Solaris 10.
>Fix:
Diff:

--- a/multimedia/ffmpeg4/Makefile.common
+++ b/multimedia/ffmpeg4/Makefile.common
@@ -32,6 +32,7 @@ CONFIGURE_ARGS+=      --incdir=${PREFIX}/include/ffmpeg4
 CONFIGURE_ARGS+=       --libdir=${PREFIX}/lib/ffmpeg4
 CONFIGURE_ARGS+=       --shlibdir=${PREFIX}/lib/ffmpeg4
 LDFLAGS+=              ${COMPILER_RPATH_FLAG}${PREFIX}/lib/ffmpeg4
+LDFLAGS.SunOS+=                -lrt

 .if !empty(MACHINE_PLATFORM:MDarwin-1[2-9].*-*) || !empty(MACHINE_PLATFORM:MDarwin-2*)
 CONFIGURE_ARGS+=       --enable-opencl
@@ -73,6 +74,7 @@ REPLACE_PERL+=        doc/texi2pod.pl
 REPLACE_SH+=   configure
 REPLACE_SH+=   ffbuild/pkgconfig_generate.sh
 REPLACE_SH+=   ffbuild/version.sh
+REPLACE_SH+=   ffbuild/libversion.sh

 PLIST_SRC+=    ${PKGDIR}/PLIST


And the file patches/patch-ffbuild_libversion.sh

$NetBSD$

--- ffbuild/libversion.sh.orig  2021-10-21 17:06:35.000000000 +0000
+++ ffbuild/libversion.sh
@@ -1,3 +1,5 @@
+#!/bin/sh
+
 toupper(){
     echo "$@" | tr abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ
 }

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Wed, 19 Jan 2022 10:46:06 +0000
Responsible-Changed-Why:
A SunOS problem.


From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56633 CVS commit: pkgsrc/multimedia/ffmpeg4
Date: Mon, 23 May 2022 00:35:02 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Mon May 23 00:35:02 UTC 2022

 Modified Files:
 	pkgsrc/multimedia/ffmpeg4: Makefile.common distinfo
 Added Files:
 	pkgsrc/multimedia/ffmpeg4/patches: patch-ffbuild_libversion.sh

 Log Message:
 multimedia/ffmpeg4: solaris build fixes from Claes Nästén in PR 56633


 To generate a diff of this commit:
 cvs rdiff -u -r1.27 -r1.28 pkgsrc/multimedia/ffmpeg4/Makefile.common
 cvs rdiff -u -r1.26 -r1.27 pkgsrc/multimedia/ffmpeg4/distinfo
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/multimedia/ffmpeg4/patches/patch-ffbuild_libversion.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 23 May 2022 00:36:24 +0000
State-Changed-Why:
committed, thanks


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.