NetBSD Problem Report #56875

From www@netbsd.org  Fri Jun 10 01:03:38 2022
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id A01631A921F
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 10 Jun 2022 01:03:38 +0000 (UTC)
Message-Id: <20220610010307.1EC7D1A923C@mollari.NetBSD.org>
Date: Fri, 10 Jun 2022 01:03:07 +0000 (UTC)
From: tgl@sss.pgh.pa.us
Reply-To: tgl@sss.pgh.pa.us
To: gnats-bugs@NetBSD.org
Subject: too-short timeout in tests/crypto/libcrypto/t_libcrypto.sh
X-Send-Pr-Version: www-1.0

>Number:         56875
>Category:       misc
>Synopsis:       too-short timeout in tests/crypto/libcrypto/t_libcrypto.sh
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 10 01:05:00 +0000 2022
>Closed-Date:    Fri Jun 10 06:05:00 +0000 2022
>Last-Modified:  Fri Jun 10 06:05:00 +0000 2022
>Originator:     Tom Lane
>Release:        HEAD/202206081310Z
>Organization:
PostgreSQL Global Development Group
>Environment:
NetBSD sss2.sss.pgh.pa.us 9.99.97 NetBSD 9.99.97 (SD0) #3: Thu Jun  9 15:19:02 EDT 2022  tgl@nuc1.sss.pgh.pa.us:/home/tgl/netbsd-H-202206081310Z/obj.hppa/sys/arch/hppa/compile/SD0 hppa
>Description:
The crypto/libcrypto/t_libcrypto test program sets a 720-second timeout for its bignum test step.  Slow as that sounds, it's not enough for older and slower machines.  On my HPPA 9000/360, I observe that the test step takes 1550 seconds.  I'd argue for setting the timeout well above that, since (a) this is one of the faster models of that arch, and (b) ATF tests shouldn't really assume that they'll get 100% of the CPU for long stretches.

>How-To-Repeat:
$ cd /usr/tests
$ atf-run crypto/libcrypto/t_libcrypto

>Fix:
Something like this:

Index: tests/crypto/libcrypto/t_libcrypto.sh
===================================================================
RCS file: /cvsroot/src/tests/crypto/libcrypto/t_libcrypto.sh,v
retrieving revision 1.7
diff -u -r1.7 t_libcrypto.sh
--- tests/crypto/libcrypto/t_libcrypto.sh       11 Apr 2020 16:55:33 -0000      1.7
+++ tests/crypto/libcrypto/t_libcrypto.sh       10 Jun 2022 00:50:08 -0000
@@ -39,7 +39,7 @@
 bn_head()
 {
        atf_set "descr" "Checks BIGNUM library"
-       atf_set "timeout" "720"
+       atf_set "timeout" "3600"
 }
 bn_body()
 {

although I think a good argument could be made for setting it to 2 hours (7200s) not 1.

>Release-Note:

>Audit-Trail:
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56875 CVS commit: src/tests/crypto/libcrypto
Date: Fri, 10 Jun 2022 05:59:12 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Fri Jun 10 05:59:12 UTC 2022

 Modified Files:
 	src/tests/crypto/libcrypto: t_libcrypto.sh

 Log Message:
 PR 56875: Bump timeout for the bignumber test to 2h, as suggested
 by Tom Lane to give slower architectures a chance to complete it.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 src/tests/crypto/libcrypto/t_libcrypto.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Fri, 10 Jun 2022 06:05:00 +0000
State-Changed-Why:
Bumped the timeout as suggested


>Unformatted:

Home	PR Database Search