NetBSD Problem Report #57062

From www@netbsd.org  Mon Oct 17 15:39:14 2022
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 9C6921A921F
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 17 Oct 2022 15:39:14 +0000 (UTC)
Message-Id: <20221017153913.4846B1A9239@mollari.NetBSD.org>
Date: Mon, 17 Oct 2022 15:39:13 +0000 (UTC)
From: andrew.cagney@gmail.com
Reply-To: andrew.cagney@gmail.com
To: gnats-bugs@NetBSD.org
Subject: master is not a valid tag name, use an explicit commit hash
X-Send-Pr-Version: www-1.0

>Number:         57062
>Category:       pkg
>Synopsis:       master is not a valid tag name, use an explicit commit hash
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 17 15:40:01 +0000 2022
>Closed-Date:    Sat May 13 02:43:30 +0000 2023
>Last-Modified:  Sat May 13 02:43:30 +0000 2023
>Originator:     cagney
>Release:        pkgsrc-2022Q3
>Organization:
>Environment:
NetBSD arm64 9.2_STABLE NetBSD 9.2_STABLE 
>Description:
The file mk/fetch/github.mk contains the check:

.  if !empty(GITHUB_TAG:Mmaster)
PKG_FAIL_REASON+=       "master is not a valid tag name, use an explicit commit hash"
.  endif

It should be updated, or perhaps replaced by documentation explaining that it really needs to be a "tag" (hence the suffix) and not a branch.

(I suspect adding GITHUB_TAG=main NO_CHECKSUM=yes to the package Makefile is frowned upon)


>How-To-Repeat:
make GITHUB_TAG=main

>Fix:

>Release-Note:

>Audit-Trail:
From: Benny Siegert <bsiegert@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/57062: master is not a valid tag name, use an explicit commit hash
Date: Mon, 17 Oct 2022 18:32:42 +0200

 On Mon, Oct 17, 2022 at 5:40 PM <andrew.cagney@gmail.com> wrote:
 > It should be updated, or perhaps replaced by documentation explaining that it really needs to be a "tag" (hence the suffix) and not a branch.
 >
 > (I suspect adding GITHUB_TAG=main NO_CHECKSUM=yes to the package Makefile is frowned upon)

 Well, the message already says it should be a commit hash. A commit
 hash refers to a single given commit. Putting in a branch is asking
 for all kinds of trouble.

 That said, the code should probably also recognize main instead of master.

 -- 
 Benny

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57062 CVS commit: pkgsrc/mk/fetch
Date: Fri, 12 May 2023 20:09:09 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Fri May 12 20:09:09 UTC 2023

 Modified Files:
 	pkgsrc/mk/fetch: github.mk

 Log Message:
 mk/fetch/github.mk: reject "main" as well as "master", and clarify

 PR 57062 from Andrew Cagney


 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.16 pkgsrc/mk/fetch/github.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 13 May 2023 02:43:30 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

Home	PR Database Search