NetBSD Problem Report #57218

From kimmo@suominen.org  Sat Feb  4 04:22:25 2023
Return-Path: <kimmo@suominen.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 1F6C31A9239
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  4 Feb 2023 04:22:25 +0000 (UTC)
Message-Id: <20230204042221.85C3D1B737@equinoxe.x.gw.fi>
Date: Sat,  4 Feb 2023 06:22:21 +0200 (EET)
From: kim@netbsd.org (Kimmo Suominen)
To: gnats-bugs@NetBSD.org
Subject: git-contrib tries to download more files during "make install"
X-Send-Pr-Version: 3.95

>Number:         57218
>Category:       pkg
>Synopsis:       git-contrib tries to download more files during "make install"
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 04 04:25:00 +0000 2023
>Last-Modified:  Wed May 10 02:10:01 +0000 2023
>Originator:     Kimmo Suominen
>Release:        NetBSD 9.3_STABLE
>Organization:
>Environment:
System: NetBSD equinoxe.x.gw.fi 9.3_STABLE NetBSD 9.3_STABLE (GENERIC) #0: Tue Dec 20 09:58:01 UTC 2022 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
	> make install
	=> Bootstrap dependency digest>=20211023: found digest-20220214
	===> Checking for vulnerabilities in git-contrib-2.39.1
	===> Installing for git-contrib-2.39.1
	=> Generating pre-install file lists
	/usr/pkg/bin/gmake -C ../../ GIT-VERSION-FILE
	gmake[1]: Entering directory '/tmp/kim/pkgsrc/devel/git-contrib/work/git-2.39.1'
	gmake[1]: 'GIT-VERSION-FILE' is up to date.
	gmake[1]: Leaving directory '/tmp/kim/pkgsrc/devel/git-contrib/work/git-2.39.1'
	install -d -m 755 /tmp/kim/pkgsrc/devel/git-contrib/work/.destdir/usr/pkg/libexec/git-core
	install -m 755 git-subtree /tmp/kim/pkgsrc/devel/git-contrib/work/.destdir/usr/pkg/libexec/git-core
	asciidoc -b docbook -d manpage -f ../../Documentation/asciidoc.conf \
		-agit_version=2.39.1  git-subtree.txt
	xmlto -m ../../Documentation/manpage-normal.xsl  man git-subtree.xml
	xmlto: /tmp/kim/pkgsrc/devel/git-contrib/work/git-2.39.1/contrib/subtree/git-subtree.xml does not validate (status 3)
	xmlto: Fix document syntax or use --skip-validation option
	I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd
	/tmp/kim/pkgsrc/devel/git-contrib/work/git-2.39.1/contrib/subtree/git-subtree.xml:2: warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
	D DocBook XML V4.5//EN" "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
										       ^
	I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd
	warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
	validity error : Could not load the external subset "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
	Document /tmp/kim/pkgsrc/devel/git-contrib/work/git-2.39.1/contrib/subtree/git-subtree.xml does not validate
	gmake: *** [Makefile:83: git-subtree.1] Error 13
	*** Error code 2
>How-To-Repeat:
	Try to build git-contrib or anything that depends on it (e.g. git).
>Fix:


>Audit-Trail:
From: Kimmo Suominen <kim@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/57218: git-contrib tries to download more files during "make install"
Date: Sat, 4 Feb 2023 06:45:48 +0200

 Maybe this is an issue with asciidoc, as building tig fails with a
 similar message:

 ===> Building for tig-2.5.7
 gmake: Nothing to be done for 'all'.
   ASCIIDOC  doc/manual.xml
      XMLTO  doc/manual.html-chunked
 xmlto: /tmp/kim/pkgsrc/devel/tig/work/tig-2.5.7/doc/manual.xml does
 not validate (status 3)
 xmlto: Fix document syntax or use --skip-validation option
 I/O error : Attempt to load network entity
 http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd
 /tmp/kim/pkgsrc/devel/tig/work/tig-2.5.7/doc/manual.xml:2: warning:
 failed to load external entity "http://www.oasis-open.org/docb
 ook/xml/4.5/docbookx.dtd"
 D DocBook XML V4.5//EN" "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
                                                                                ^
 I/O error : Attempt to load network entity
 http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd
 warning: failed to load external entity
 "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
 validity error : Could not load the external subset
 "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
 Document /tmp/kim/pkgsrc/devel/tig/work/tig-2.5.7/doc/manual.xml does
 not validate
 gmake: *** [Makefile:445: doc/manual.html-chunked] Error 13
 rm doc/manual.xml
 *** Error code 2

From: Jonathan Perkin <jperkin@mnx.io>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/57218: git-contrib tries to download more files during "make
 install"
Date: Sat, 4 Feb 2023 07:57:36 +0000

 cvs up, this was a bug in the libxml2 update, I fixed it a while back.

 -- 
 Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
 Open Source Complete Cloud   www.tritondatacenter.com

From: Kimmo Suominen <kim@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/57218: git-contrib tries to download more files during "make install"
Date: Sat, 4 Feb 2023 11:24:51 +0200

 I ran "cvs up" just before running the build.

 Why is it not pulled in automatically? Was a revump missed for dependencies?

 On Sat, 4 Feb 2023 at 10:15, Jonathan Perkin <jperkin@mnx.io> wrote:
 >
 > The following reply was made to PR pkg/57218; it has been noted by GNATS.
 >
 > From: Jonathan Perkin <jperkin@mnx.io>
 > To: gnats-bugs@netbsd.org
 > Cc:
 > Subject: Re: pkg/57218: git-contrib tries to download more files during "make
 >  install"
 > Date: Sat, 4 Feb 2023 07:57:36 +0000
 >
 >  cvs up, this was a bug in the libxml2 update, I fixed it a while back.
 >
 >  --
 >  Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
 >  Open Source Complete Cloud   www.tritondatacenter.com
 >

From: "Kimmo Suominen" <kim@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57218 CVS commit: pkgsrc/devel/tig
Date: Sat, 4 Feb 2023 09:25:50 +0000

 Module Name:	pkgsrc
 Committed By:	kim
 Date:		Sat Feb  4 09:25:50 UTC 2023

 Modified Files:
 	pkgsrc/devel/tig: Makefile distinfo
 	pkgsrc/devel/tig/patches: patch-Makefile

 Log Message:
 tig: Run xmlto with "--skip-validation"

 Workaround for PR pkg/57218


 To generate a diff of this commit:
 cvs rdiff -u -r1.24 -r1.25 pkgsrc/devel/tig/Makefile
 cvs rdiff -u -r1.19 -r1.20 pkgsrc/devel/tig/distinfo
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/devel/tig/patches/patch-Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Kimmo Suominen" <kim@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57218 CVS commit: pkgsrc/devel/git-contrib
Date: Sat, 4 Feb 2023 09:27:15 +0000

 Module Name:	pkgsrc
 Committed By:	kim
 Date:		Sat Feb  4 09:27:15 UTC 2023

 Modified Files:
 	pkgsrc/devel/git-contrib: Makefile

 Log Message:
 git-contrib: Run xmlto with "--skip-validation"

 Workaround for PR pkg/57218


 To generate a diff of this commit:
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/devel/git-contrib/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Benny Siegert <bsiegert@gmail.com>
To: Kimmo Suominen <kim@netbsd.org>
Cc: gnats-bugs@netbsd.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org, 
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/57218: git-contrib tries to download more files during "make install"
Date: Sat, 4 Feb 2023 10:43:05 +0100

 On Sat, Feb 4, 2023 at 10:25 AM Kimmo Suominen <kim@netbsd.org> wrote:
 > I ran "cvs up" just before running the build.
 >
 > Why is it not pulled in automatically? Was a revump missed for dependencies?

 Would it make sense to file a pullup for the workarounds that you added?

 -- 
 Benny

From: Kimmo Suominen <kim@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/57218: git-contrib tries to download more files during "make install"
Date: Sat, 4 Feb 2023 11:43:42 +0200

 It would appear I already had the latest libxml2 installed as well:

 equinoxe[nb9-amd64]:~> pkg_info libxml2
 Information for libxml2-2.10.3nb2:

 I have the following settings:

 ; grep SYSCONF /etc/mk.conf
 PKG_SYSCONFBASE=        /etc    # keep configs in /etc
 PKG_SYSCONFDIR.bind=            ${PKG_SYSCONFBASE}/bind
 PKG_SYSCONFDIR.xmlcatmgr=       ${LOCALBASE}/etc

From: Kimmo Suominen <kim@netbsd.org>
To: Benny Siegert <bsiegert@gmail.com>
Cc: gnats-bugs@netbsd.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org, 
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/57218: git-contrib tries to download more files during "make install"
Date: Sat, 4 Feb 2023 11:47:16 +0200

 On Sat, 4 Feb 2023 at 11:43, Benny Siegert <bsiegert@gmail.com> wrote:
 > On Sat, Feb 4, 2023 at 10:25 AM Kimmo Suominen <kim@netbsd.org> wrote:
 > > I ran "cvs up" just before running the build.
 > > Why is it not pulled in automatically? Was a revump missed for dependencies?
 >
 > Would it make sense to file a pullup for the workarounds that you added?

 Possibly, but I feel like I don't quite yet understand what failed exactly.

 Adding "--skip-validation" to all xmlto invocations feels wrong, but I
 saw that e.g. git-base already did that, so I just copied the
 workaround to get the packages to build.

 It sounds like libxml2 might need someone more knowledgeable to look at it.

 + Kimmo

From: Jonathan Perkin <jperkin@mnx.io>
To: Kimmo Suominen <kim@netbsd.org>
Cc: gnats-bugs@netbsd.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/57218: git-contrib tries to download more files during "make
 install"
Date: Sat, 4 Feb 2023 12:07:14 +0000

 * On 2023-02-04 at 09:25 GMT, Kimmo Suominen wrote:

 >Why is it not pulled in automatically? Was a revump missed for dependencies?

 I don't know, I thought in my testing that just rebuilding libxml2 was 
 enough to fix the problem, but perhaps xmlto needs a rebuild too?  The 
 problem went away in my bulk builds where everything is rebuilt.

 Or maybe this is a different problem caused by the libxml2 update.

 -- 
 Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
 Open Source Complete Cloud   www.tritondatacenter.com

From: Jonathan Perkin <jperkin@mnx.io>
To: Benny Siegert <bsiegert@gmail.com>
Cc: Kimmo Suominen <kim@netbsd.org>, gnats-bugs@netbsd.org,
	pkg-manager@netbsd.org, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/57218: git-contrib tries to download more files during "make
 install"
Date: Sat, 4 Feb 2023 12:02:52 +0000

 * On 2023-02-04 at 09:43 GMT, Benny Siegert wrote:

 >On Sat, Feb 4, 2023 at 10:25 AM Kimmo Suominen <kim@netbsd.org> wrote:
 >> I ran "cvs up" just before running the build.
 >>
 >> Why is it not pulled in automatically? Was a revump missed for dependencies?
 >
 >Would it make sense to file a pullup for the workarounds that you added?

 No, these are wrong, the libxml2 update broke many many packages, the 
 fix is to rebuild libxml2, not add workarounds to loads and loads of 
 packages.

 -- 
 Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
 Open Source Complete Cloud   www.tritondatacenter.com

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/57218: git-contrib tries to download more files during "make
 install"
Date: Tue, 9 May 2023 21:48:54 +0000

 On Sat, Feb 04, 2023 at 12:10:01PM +0000, Jonathan Perkin wrote:
  > > Why is it not pulled in automatically? Was a revump missed for
  > > dependencies?
  >  
  >  I don't know, I thought in my testing that just rebuilding libxml2 was 
  >  enough to fix the problem, but perhaps xmlto needs a rebuild too?  The 
  >  problem went away in my bulk builds where everything is rebuilt.
  >  
  >  Or maybe this is a different problem caused by the libxml2 update.

 Did we figure this out? It seems like we should revert the workarounds
 if they aren't needed.

 -- 
 David A. Holland
 dholland@netbsd.org

From: Kimmo Suominen <kim@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/57218: git-contrib tries to download more files during "make install"
Date: Wed, 10 May 2023 05:07:31 +0300

 I think what should happen is to restore the use of
 SGML_DEFAULT_CATALOG and XML_DEFAULT_CATALOG values in
 textproc/libxml2, so that these locations would again be managed
 ("owned") by the textproc/xmlcatmgr package.

 Currently there is a "happy accident" when textproc/libxml2 and
 textproc/xmlcatmgr use the same PKG_SYSCONFDIR. If they don't, we get
 the issues outlined in this ticket.

 The offending changes are:
 - parts of revision 1.166 of textproc/libxml2/Makefile
 - the removal of textproc/libxml2/patches/patch-catalog.c
 - the removal of textproc/libxml2/patches/patch-xmlcatalog.c

 Ref: https://github.com/NetBSD/pkgsrc/commit/5140dc78e337848e6adc257062121d056e0ba445

 Kind regards,
 + Kimmo

Home	PR Database Search