NetBSD Problem Report #57262

From www@netbsd.org  Tue Mar  7 08:36:20 2023
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id DD09B1A9239
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  7 Mar 2023 08:36:19 +0000 (UTC)
Message-Id: <20230307083548.92ED71A923B@mollari.NetBSD.org>
Date: Tue,  7 Mar 2023 08:35:48 +0000 (UTC)
From: george@galis.org
Reply-To: george@galis.org
To: gnats-bugs@NetBSD.org
Subject: aarch64 audio/rubberband has broken PLIST
X-Send-Pr-Version: www-1.0

>Number:         57262
>Category:       pkg
>Synopsis:       aarch64 audio/rubberband has broken PLIST
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 07 08:40:00 +0000 2023
>Closed-Date:    Fri Dec 15 13:56:21 +0000 2023
>Last-Modified:  Fri Dec 15 13:56:21 +0000 2023
>Originator:     George Georgalis
>Release:        pkgsrc-2022Q4 current, 6 March 2023
>Organization:
>Environment:
Darwin AAAA.asus 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:39:35 PST 2023; root:xnu-8792.81.3~2/RELEASE_ARM64_T8103 arm64
>Description:
the macos linker creates libs with a different extension vs NetBSD or Linux (etc), the audio/rubberband build fails on mac because the PLIST contains .so shared libs, but on Darwin/11.3/arm64, shared libs are .dylib dynamic libs, so ld gives them a different name.

not sure how this should be fixed. This nominal diff will allow the build to complete and install a working rubberband binary on mac, however it will break other arch, eg NetBSD 9.0/x86_64

/opt/pkgsrc-current/audio/rubberband diff -U 0 PLIST~ PLIST
--- PLIST~ 2023-03-06 01:15:00
+++ PLIST 2023-03-05 22:31:30
@@ -6 +6 @@
-lib/ladspa/ladspa-rubberband.so
+lib/ladspa/ladspa-rubberband.dylib
@@ -13 +13 @@
-lib/vamp/vamp-rubberband.so
+lib/vamp/vamp-rubberband.dylib

>How-To-Repeat:
bootstrap pkgsrc current on Darwin/11.3/arm64 and attempt to install audio/rubberband, the error indicates extra .dynlib files and missing .so files in the PLIST, even though the PLIST is correct on NetBSD.
>Fix:

>Release-Note:

>Audit-Trail:
From: George Georgalis <george@galis.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/57262: aarch64 audio/rubberband has broken PLIST
Date: Tue, 7 Mar 2023 14:12:05 -0800

 --00000000000062036905f656b443
 Content-Type: multipart/alternative; boundary="00000000000062036705f656b441"

 --00000000000062036705f656b441
 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 Upstream seems to have resolved the issue.
 The attached patch bumps rubberband>=3D1.8.1 to 3.1.2
 also patch-meson.build should be removed, that also
 was addressed upstream. This patch to current
 builds on NetBSD 9.3 amd64, and MacOS Ventura 13.2.1 aarch64 (M1)

 -George



 On Tue, Mar 7, 2023 at 12:40=E2=80=AFAM <gnats-admin@netbsd.org> wrote:

 > Thank you very much for your problem report.
 > It has the internal identification `pkg/57262'.
 > The individual assigned to look at your
 > report is: pkg-manager.
 >
 > >Category:       pkg
 > >Responsible:    pkg-manager
 > >Synopsis:       aarch64 audio/rubberband has broken PLIST
 > >Arrival-Date:   Tue Mar 07 08:40:00 +0000 2023
 >
 >

 --=20
 George Georgalis, (415) 894-2710, http://www.galis.org/

 --00000000000062036705f656b441
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 <div dir=3D"ltr"><div>Upstream seems to have resolved the issue.</div><div>=
 The attached patch bumps rubberband&gt;=3D1.8.1 to 3.1.2</div><div>also pat=
 ch-meson.build should be removed, that also</div><div>was addressed upstrea=
 m. This patch to current</div><div>builds on NetBSD 9.3 amd64, and MacOS Ve=
 ntura 13.2.1 aarch64 (M1)</div><div><br></div><div>-George<br></div><div><b=
 r></div><div><br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr=
 " class=3D"gmail_attr">On Tue, Mar 7, 2023 at 12:40=E2=80=AFAM &lt;<a href=
 =3D"mailto:gnats-admin@netbsd.org">gnats-admin@netbsd.org</a>&gt; wrote:<br=
 ></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;=
 border-left:1px solid rgb(204,204,204);padding-left:1ex">Thank you very muc=
 h for your problem report.<br>
 It has the internal identification `pkg/57262&#39;.<br>
 The individual assigned to look at your<br>
 report is: pkg-manager. <br>
 <br>
 &gt;Category:=C2=A0 =C2=A0 =C2=A0 =C2=A0pkg<br>
 &gt;Responsible:=C2=A0 =C2=A0 pkg-manager<br>
 &gt;Synopsis:=C2=A0 =C2=A0 =C2=A0 =C2=A0aarch64 audio/rubberband has broken=
  PLIST<br>
 &gt;Arrival-Date:=C2=A0 =C2=A0Tue Mar 07 08:40:00 +0000 2023<br>
 <br>
 </blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g=
 mail_signature">George Georgalis, (415) 894-2710, <a href=3D"http://www.gal=
 is.org/" target=3D"_blank">http://www.galis.org/</a><br><br></div>

 --00000000000062036705f656b441--
 --00000000000062036905f656b443
 Content-Type: application/octet-stream; name="diff-rb-3.1.2.patch"
 Content-Disposition: attachment; filename="diff-rb-3.1.2.patch"
 Content-Transfer-Encoding: base64
 Content-ID: <f_leyt2cex0>
 X-Attachment-Id: f_leyt2cex0

 PyB3b3JrCkluZGV4OiBNYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zzcm9vdC9wa2dz
 cmMvYXVkaW8vcnViYmVyYmFuZC9NYWtlZmlsZSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMApk
 aWZmIC1yMS4xMCBNYWtlZmlsZQozLDRjMyw0CjwgRElTVE5BTUU9CXJ1YmJlcmJhbmQtMS45LjIK
 PCBQS0dSRVZJU0lPTj0JMgotLS0KPiBESVNUTkFNRT0JcnViYmVyYmFuZC0zLjEuMgo+IFBLR1JF
 VklTSU9OPQkKSW5kZXg6IFBMSVNUCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L3BrZ3Ny
 Yy9hdWRpby9ydWJiZXJiYW5kL1BMSVNULHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjUKZGlmZiAt
 cjEuNSBQTElTVAoyYTMKPiBiaW4vcnViYmVyYmFuZC1yMwoxMGMxMQo8IGxpYi9saWJydWJiZXJi
 YW5kLnNvLjIuMS40Ci0tLQo+IGxpYi9saWJydWJiZXJiYW5kLnNvLjIuMi4xCkluZGV4OiBidWls
 ZGxpbmszLm1rCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L3BrZ3NyYy9hdWRpby9ydWJi
 ZXJiYW5kL2J1aWxkbGluazMubWssdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNApkaWZmIC1yMS40
 IGJ1aWxkbGluazMubWsKOCw5YzgsOQo8IEJVSUxETElOS19BUElfREVQRU5EUy5ydWJiZXJiYW5k
 Kz0JcnViYmVyYmFuZD49MS44LjEKPCBCVUlMRExJTktfQUJJX0RFUEVORFMucnViYmVyYmFuZD89
 CXJ1YmJlcmJhbmQ+PTEuOS4ybmIyCi0tLQo+IEJVSUxETElOS19BUElfREVQRU5EUy5ydWJiZXJi
 YW5kKz0JcnViYmVyYmFuZD49My4xLjIKPiAjQlVJTERMSU5LX0FCSV9ERVBFTkRTLnJ1YmJlcmJh
 bmQ/PQlydWJiZXJiYW5kPj0zLjEuMm5iMQpJbmRleDogZGlzdGluZm8KPT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg
 ZmlsZTogL2N2c3Jvb3QvcGtnc3JjL2F1ZGlvL3J1YmJlcmJhbmQvZGlzdGluZm8sdgpyZXRyaWV2
 aW5nIHJldmlzaW9uIDEuNwpkaWZmIC1yMS43IGRpc3RpbmZvCjMsNmMzLDUKPCBCTEFLRTJzIChy
 dWJiZXJiYW5kLTEuOS4yLnRhci5iejIpID0gOGZjNjcwYzZkNmNiMzM5NDk4MGM5ZTVhN2Q1Njkz
 ODEzZjBlODY2MWNjOTc5ODVjYmRiZGU5ZjhiOTRlYTAwNgo8IFNIQTUxMiAocnViYmVyYmFuZC0x
 LjkuMi50YXIuYnoyKSA9IGIxYzc2M2FiMmE0MjhhYTJmMWY4ZTVkMGJlNmU5ZWI2Njk4MDgwNTll
 ZTUzODllOTRmMTJkZTI1ZjFhMDVjZDg5MDIyNjU2ZDk4OTA2YzkwYjYxNjc3M2RhMTFhYjFmNTk2
 YWUyYzVhOWQzMDAxMThlODgwNDllMTQ0MzEyMWYyCjwgU2l6ZSAocnViYmVyYmFuZC0xLjkuMi50
 YXIuYnoyKSA9IDE2NDE3OCBieXRlcwo8IFNIQTEgKHBhdGNoLW1lc29uLmJ1aWxkKSA9IGEyNjdk
 OWYxNTA0OTFmMzgxZTNiZmQ1NDYzMzRjMTU5OTFhOWVlMDYKLS0tCj4gQkxBS0UycyAocnViYmVy
 YmFuZC0zLjEuMi50YXIuYnoyKSA9IDVmYzExZjg5NDk5NjE0ZDEwYzJlYWI0YzA4MTk5MTNjZmFl
 ODM5MzdiNzBjZGJkMjBhYjUwZDRjYTQ1MTg1ZTcKPiBTSEE1MTIgKHJ1YmJlcmJhbmQtMy4xLjIu
 dGFyLmJ6MikgPSBiMjE2MDVhMGNmODgyZTM0ZmMyZWFkYTM4YTQ0NjIyMDI1N2U0YjA2NzQ3NWUz
 NmRmZWVmMDBkNDkxNDI1YWQ1MTM5OGZiYjQ5NzczZGJkMTYyNjgzNTMxYjcwZjdjODY0YWIwMmJm
 Zjc0NGQ3ZTBkZGU3ZWQxZDY0YWExZDMyNwo+IFNpemUgKHJ1YmJlcmJhbmQtMy4xLjIudGFyLmJ6
 MikgPSAyMTgzNjEgYnl0ZXMK
 --00000000000062036905f656b443--

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/57262: aarch64 audio/rubberband has broken PLIST
Date: Wed, 8 Mar 2023 09:05:17 +0100

 I've updated rubberband to 3.1.2. Can I close this ticket now?

 Thanks,
  Thomas

From: George Georgalis <george@galis.org>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/57262: aarch64 audio/rubberband has broken PLIST
Date: Wed, 8 Mar 2023 19:41:28 -0800

 Although my patch appeared to be successful on Darwin,
 that may have been due to unclean workflow.
 Thanks for the rubberband bump in current,
 however the problem is not solved.
 Darwin aarch64 fails PLIST.
 What best to do about it is unclear,
 this package lib files don't begin with lib
 so the pkgsrc/mk/plist/shlib-dylib.awk fix doesn't apply...
 there is a thread in pkgsrc-users, no solution yet.

 On Wed, Mar 8, 2023 at 12:10=E2=80=AFAM Thomas Klausner <wiz@netbsd.org> wr=
 ote:
 >
 > The following reply was made to PR pkg/57262; it has been noted by GNATS.
 >
 > From: Thomas Klausner <wiz@NetBSD.org>
 > To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
 > Cc:
 > Subject: Re: pkg/57262: aarch64 audio/rubberband has broken PLIST
 > Date: Wed, 8 Mar 2023 09:05:17 +0100
 >
 >  I've updated rubberband to 3.1.2. Can I close this ticket now?
 >
 >  Thanks,
 >   Thomas
 >


 --=20
 George Georgalis, (415) 894-2710, http://www.galis.org/

From: "Amitai Schleier" <schmonz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57262 CVS commit: pkgsrc/audio/rubberband
Date: Fri, 15 Dec 2023 13:53:13 +0000

 Module Name:	pkgsrc
 Committed By:	schmonz
 Date:		Fri Dec 15 13:53:13 UTC 2023

 Modified Files:
 	pkgsrc/audio/rubberband: Makefile PLIST

 Log Message:
 rubberband: fix macOS PLIST, closing PR pkg/57262.


 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.16 pkgsrc/audio/rubberband/Makefile
 cvs rdiff -u -r1.6 -r1.7 pkgsrc/audio/rubberband/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: schmonz@NetBSD.org
State-Changed-When: Fri, 15 Dec 2023 13:56:21 +0000
State-Changed-Why:
PLIST now matches on macOS. Thanks for the report!


>Unformatted:

Home	PR Database Search