NetBSD Problem Report #57617

From www@netbsd.org  Mon Sep 11 14:44:32 2023
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 6D9261A9238
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 11 Sep 2023 14:44:32 +0000 (UTC)
Message-Id: <20230911144431.2E71B1A9239@mollari.NetBSD.org>
Date: Mon, 11 Sep 2023 14:44:31 +0000 (UTC)
From: holovati@gmail.com
Reply-To: holovati@gmail.com
To: gnats-bugs@NetBSD.org
Subject: ext2fs broken
X-Send-Pr-Version: www-1.0

>Number:         57617
>Category:       kern
>Synopsis:       ext2fs broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    christos
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 11 14:45:00 +0000 2023
>Last-Modified:  Mon Sep 11 14:52:37 +0000 2023
>Originator:     Damir Holovati
>Release:        https://github.com/NetBSD/src
>Organization:
na
>Environment:
na
>Description:
Changes made in

/* $NetBSD: ext2fs_vfsops.c,v 1.225 2023/08/27 16:35:51 christos Exp $ */
break the loading of group descriptors.

ext2fs_vfsops.c:773  &m_fs->e2fs_gd[i * m_fs->e2fs_bsize/ sizeof(struct ext2_gd)]

is not the same as &m_fs->e2fs_gd[i * sh].

In the new code(e2fs_bsize = 0x400) e2fs_cgload writes 32 descriptors to e2fs_gd but "i * m_fs->e2fs_bsize/ sizeof(struct ext2_gd)" offsets e2fs_gd by 16.
>How-To-Repeat:
Try mounting a fs with 1024 byte blocks.
>Fix:
Revert to &m_fs->e2fs_gd[i * sh].

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->christos
Responsible-Changed-By: riastradh@NetBSD.org
Responsible-Changed-When: Mon, 11 Sep 2023 14:52:37 +0000
Responsible-Changed-Why:
broke with christos's recent ext2fs patch merge


>Unformatted:

Home	PR Database Search