NetBSD Problem Report #57667

From www@netbsd.org  Wed Oct 18 06:36:47 2023
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B99821A9238
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 18 Oct 2023 06:36:47 +0000 (UTC)
Message-Id: <20231018063646.336A91A9239@mollari.NetBSD.org>
Date: Wed, 18 Oct 2023 06:36:46 +0000 (UTC)
From: schaecsn@gmx.net
Reply-To: schaecsn@gmx.net
To: gnats-bugs@NetBSD.org
Subject: graphics/ImageMagick can't convert certain jpegs
X-Send-Pr-Version: www-1.0

>Number:         57667
>Category:       pkg
>Synopsis:       graphics/ImageMagick can't convert certain jpegs
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    adam
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 18 06:40:00 +0000 2023
>Last-Modified:  Mon Oct 23 10:56:41 +0000 2023
>Originator:     Stefan Schaeckeler
>Release:        pkgsrc-2023Q3
>Organization:
>Environment:
NetBSD XXX 9.3_STABLE NetBSD 9.3_STABLE (GENERIC) #4: Sat Sep  2 10:58:30 PDT 2023  root@XXX:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
>Description:
ImageMagick convert from pkgsrc 2023Q3 can't convert jpegs which embed thumbnails. This was reported upstream https://github.com/ImageMagick/ImageMagick/issues/6475 and was resolved with commit https://github.com/ImageMagick/ImageMagick/commit/2366b767cf711753328944f082376bdfd916d8e8.patch (see second last comment in above issue report).

>How-To-Repeat:
$ wget https://user-images.githubusercontent.com/2273262/252267836-6d4d0a89-510d-4fa0-8b73-d96ea8144908.jpg -O input.jpeg

$ convert input.jpeg output.png
convert: Premature end of JPEG file `/tmp/magick-gpycpZ4_Ji8qBEEstI7Ss8gcmhVLcPXU' @ warning/jpeg.c/JPEGWarningHandler/403.
convert: insufficient image data in file `/tmp/magick-gpycpZ4_Ji8qBEEstI7Ss8gcmhVLcPXU' @ error/jpeg.c/ReadProfileData/478.
convert: Improper call to JPEG library in state 201 `/tmp/magick-gpycpZ4_Ji8qBEEstI7Ss8gcmhVLcPXU' @ error/jpeg.c/JPEGErrorHandler/348.

>Fix:
The upstream patch does not apply cleanly. Spent no time on backporting.

My workaround is updating to the next minor version

Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/ImageMagick/Makefile.common,v
retrieving revision 1.273
diff -u -p -r1.273 Makefile.common
--- Makefile.common     6 Jul 2023 09:45:33 -0000       1.273
+++ Makefile.common     18 Oct 2023 05:51:23 -0000
@@ -5,7 +5,7 @@
 # Changelog: https://github.com/ImageMagick/Website/blob/main/ChangeLog.md

 IM_MAJOR_VER=          7.1.1
-IM_MINOR_VER=          12
+IM_MINOR_VER=          13
 IM_MAJOR_LIB_VER=      7

 .if (${IM_MINOR_VER} != NONE)

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->adam
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Mon, 23 Oct 2023 10:56:41 +0000
Responsible-Changed-Why:
Over to maintainer.


>Unformatted:

Home	PR Database Search