NetBSD Problem Report #5783

Received: (qmail 20316 invoked from network); 17 Jul 1998 14:20:29 -0000
Message-Id: <199807171420.HAA13923@nooksack.ldc.cs.wwu.edu>
Date: Fri, 17 Jul 1998 07:20:27 -0700 (PDT)
From: p@pir.net
To: gnats-bugs@gnats.netbsd.org
Subject: rbootd distributed with port-hp300 does not work on FreeBSD
X-Send-Pr-Version: www-1.0

>Number:         5783
>Category:       port-hp300
>Synopsis:       rbootd distributed with port-hp300 does not work on FreeBSD
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mycroft
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 17 07:35:00 +0000 1998
>Closed-Date:    Tue Jul 06 13:05:43 +0000 2004
>Last-Modified:  Sat Jul 10 12:39:04 +0000 2004
>Originator:     Peter Radcliffe
>Release:        1.3.2
>Organization:
>Environment:
client: hp300 with no OS
server: FreeBSD mewp 2.2.6-RELEASE FreeBSD 2.2.6-RELEASE #0: Mon Jul 13 18:11:21 EDT 1998     pir@mewp:/usr/src/sys/compile/MEWP-IPF  i386


>Description:
There is a 'fix' in rmpproto.c in rbootd for FreeBSD bpf wanting some
data in host order.
This is not needed, certainly in FreeBSD 2.2.6.
Unfortunately I don't have an older FreeBSD box to test this on.

#ifdef __FreeBSD__
        /* BPF (incorrectly) wants this in host order. */
        rconn->rmp.hp_hdr.len = rconn->rmplen - sizeof(struct hp_hdr);
#else
        rconn->rmp.hp_hdr.len = htons(rconn->rmplen - sizeof(struct hp_hdr));
#endif

Change this to version dependant ?

FreeBSD 2.2.6 does, however need the following patch to utils.c:
-----------------------------------------------------------------
*** utils.c.orig     Fri Jul 17 10:17:09 1998
--- utils.c     Fri Jul 17 10:16:47 1998
***************
*** 63,68 ****
--- 63,71 ----
  #include <stdlib.h>
  #include <string.h>
  #include <syslog.h>
+ #ifdef __FreeBSD__
+ #include <sys/time.h>
+ #endif /* __FreeBSD__ */
  #include <time.h>
  #include <unistd.h>
  #include "defs.h"
-----------------------------------------------------------------
>How-To-Repeat:

1) Attempt to network boot an hp300 series from a freebsd 2.2.6 server
   using NetBSD rbootd.

2) attempt to compile NetBSD rbootd on FreeBSD 2.2.6.

>Fix:

Remove/make version dependand the FreeBSD #ifdef in rmpproto.c.
Add the patch to utils.c.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->port-hp300-maintainer 
Responsible-Changed-By: fair 
Responsible-Changed-When: Mon Dec 28 09:37:21 PST 1998 
Responsible-Changed-Why:  
This PR is the responsibility of the portmaster, 
not the GNATS database administrator. 
State-Changed-From-To: open->closed 
State-Changed-By: mycroft 
State-Changed-When: Tue Jul 6 13:03:07 UTC 2004 
State-Changed-Why:  
Changes applied. 


Responsible-Changed-From-To: port-hp300-maintainer->mycroft 
Responsible-Changed-By: mycroft 
Responsible-Changed-When: Tue Jul 6 13:03:07 UTC 2004 
Responsible-Changed-Why:  
. 

From: "Charles M. Hannum" <mycroft@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/5783 CVS commit: src/usr.sbin/rbootd
Date: Tue,  6 Jul 2004 13:05:25 +0000 (UTC)

 Module Name:	src
 Committed By:	mycroft
 Date:		Tue Jul  6 13:05:25 UTC 2004

 Modified Files:
 	src/usr.sbin/rbootd: rmpproto.c utils.c

 Log Message:
 Fix portability problems, per PR 5783.


 To generate a diff of this commit:
 cvs rdiff -r1.13 -r1.14 src/usr.sbin/rbootd/rmpproto.c
 cvs rdiff -r1.14 -r1.15 src/usr.sbin/rbootd/utils.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: Matthias Scheler <tron@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/5783 CVS commit: [netbsd-2-0] src/usr.sbin/rbootd
Date: Sat, 10 Jul 2004 12:37:54 +0000 (UTC)

 Module Name:	src
 Committed By:	tron
 Date:		Sat Jul 10 12:37:54 UTC 2004

 Modified Files:
 	src/usr.sbin/rbootd [netbsd-2-0]: rmpproto.c

 Log Message:
 Pull up revision 1.14 (requested by mycroft in ticket #615):
 Fix portability problems, per PR 5783.


 To generate a diff of this commit:
 cvs rdiff -r1.13 -r1.13.2.1 src/usr.sbin/rbootd/rmpproto.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: Matthias Scheler <tron@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/5783 CVS commit: [netbsd-2-0] src/usr.sbin/rbootd
Date: Sat, 10 Jul 2004 12:38:15 +0000 (UTC)

 Module Name:	src
 Committed By:	tron
 Date:		Sat Jul 10 12:38:15 UTC 2004

 Modified Files:
 	src/usr.sbin/rbootd [netbsd-2-0]: utils.c

 Log Message:
 Pull up revision 1.15 (requested by mycroft in ticket #615):
 Fix portability problems, per PR 5783.


 To generate a diff of this commit:
 cvs rdiff -r1.14 -r1.14.2.1 src/usr.sbin/rbootd/utils.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search