NetBSD Problem Report #57876

From www@netbsd.org  Wed Jan 24 22:08:09 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 40CB81A9238
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 24 Jan 2024 22:08:09 +0000 (UTC)
Message-Id: <20240124220807.D474E1A9239@mollari.NetBSD.org>
Date: Wed, 24 Jan 2024 22:08:07 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: HWRNG drivers should use RND_FLAG_COLLECT_VALUE, not RND_FLAG_DEFAULT
X-Send-Pr-Version: www-1.0

>Number:         57876
>Category:       kern
>Synopsis:       HWRNG drivers should use RND_FLAG_COLLECT_VALUE, not RND_FLAG_DEFAULT
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 24 22:10:01 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10
>Organization:
The NetBSD Randomization
>Environment:
>Description:
The entropy provided by HWRNG devices usually comes from the values sampled out of them, not the times when we choose to sample them.

So kernel rndsources backed by HWRNG devices should generally use RND_FLAG_COLLECT_VALUE, but not RND_FLAG_COLLECT_TIME or, worse, RND_FLAG_ESTIMATE_TIME, which are both in RND_FLAG_DEFAULT.

Affected HWRNG drivers:

- rndrrs (arch/aarch64/aarch64/cpu.c)
- rk_v1crypto (arch/arm/rockchip/rk_v1crypto.c)
- octrnm (arch/mips/cavium/dev/octeon_rnm.c)
- virt68k bootinfo (arch/virt68k/virt68k/bootinfo.c)
- fdt efirng (dev/fdt/fdt_boot.c)
- hifn (dev/pci/hifn7751.c)


Also: sun8i_crypto (arch/arm/sunxi/sun8i_crypto.c) and tpm (dev/ic/tpm.c) should skip RND_FLAG_ESTIMATE_VALUE, which currently does nothing.
>How-To-Repeat:
rndctl -l on a machine with efirng
>Fix:
Yes, please!

Home	PR Database Search