NetBSD Problem Report #57900

From www@netbsd.org  Fri Feb  2 22:23:28 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BA7671A9238
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  2 Feb 2024 22:23:28 +0000 (UTC)
Message-Id: <20240202222327.497541A9239@mollari.NetBSD.org>
Date: Fri,  2 Feb 2024 22:23:27 +0000 (UTC)
From: rbranco@suse.de
Reply-To: rbranco@suse.de
To: gnats-bugs@NetBSD.org
Subject: Import monitor tool from DragonflyBSD
X-Send-Pr-Version: www-1.0

>Number:         57900
>Category:       bin
>Synopsis:       Import monitor tool from DragonflyBSD
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 02 22:25:00 +0000 2024
>Last-Modified:  Sun Feb 04 01:25:01 +0000 2024
>Originator:     Ricardo Branco
>Release:        NetBSD 10.0_RC3
>Organization:
>Environment:
>Description:
Import monitor tool from DragonflyBSD:
https://leaf.dragonflybsd.org/cgi/web-man?command=monitor&section=ANY
>How-To-Repeat:

>Fix:
https://github.com/NetBSD/src/pull/30

>Audit-Trail:
From: Jason Thorpe <thorpej@me.com>
To: rbranco@suse.de
Cc: gnats-admin@netbsd.org,
 netbsd-bugs@netbsd.org,
 gnats-bugs@netbsd.org
Subject: Re: bin/57900: Import monitor tool from DragonflyBSD
Date: Fri, 2 Feb 2024 14:44:59 -0800

 >> Fix:
 > https://github.com/NetBSD/src/pull/30

 I made a comment on that pull request that I think should be addressed =
 before the code is imported.

 FWIW, I do not particularly like the name of this tool.  When I first =
 saw this report, not being familiar with the tool, I thought it was =
 related to computer displays.  But it's not a hill I'm willing to die =
 on, so if it's decided to import it with this name for the same of =
 compatibility, that's fine.

 -- thorpej

From: Christos Zoulas <christos@zoulas.com>
To: gnats-bugs@netbsd.org
Cc: gnats-admin@netbsd.org,
 netbsd-bugs@netbsd.org,
 rbranco@suse.de
Subject: Re: bin/57900: Import monitor tool from DragonflyBSD
Date: Fri, 2 Feb 2024 17:52:19 -0500

 > I made a comment on that pull request that I think should be addressed =
 > before the code is imported.
 > 
 > FWIW, I do not particularly like the name of this tool.  When I first =
 > saw this report, not being familiar with the tool, I thought it was =
 > related to computer displays.  But it's not a hill I'm willing to die =
 > on, so if it's decided to import it with this name for the same of =
 > compatibility, that's fine.
 > 
 > -- thorpej
 > 


 I don't like the name either; filewatch would have been better. But what
 is more evil to rename it and be different or live with the poor name?

 christos

From: Ricardo Branco <rbranco@suse.de>
To: gnats-bugs@netbsd.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Cc: 
Subject: Re: bin/57900: Import monitor tool from DragonflyBSD
Date: Sat, 3 Feb 2024 00:01:41 +0100

 I removed the ifdef's as they pollute the code.

 Best,

 On 2/2/24 23:50, Jason Thorpe wrote:
 >   I made a comment on that pull request that I think should be addressed =
 >   before the code is imported.

From: Simon Burge <simonb@NetBSD.org>
To: gnats-bugs@netbsd.org, gnats-admin@netbsd.org,
    netbsd-bugs@netbsd.org, rbranco@suse.de
Cc: 
Subject: Re: bin/57900: Import monitor tool from DragonflyBSD
Date: Sun, 04 Feb 2024 12:21:18 +1100

 Christos Zoulas wrote:
 > Jason Thorpe wrote:
 >
 > > I made a comment on that pull request that I think should be addressed =
 > > before the code is imported.
 > > 
 > > FWIW, I do not particularly like the name of this tool.  When I first =
 > > saw this report, not being familiar with the tool, I thought it was =
 > > related to computer displays.  But it's not a hill I'm willing to die =
 > > on, so if it's decided to import it with this name for the same of =
 > > compatibility, that's fine.
 >
 > I don't like the name either; filewatch would have been better. But what
 > is more evil to rename it and be different or live with the poor name?

 I have to agree the name is absolutely terrible.  If I google for
 "dragonflybsd" and "monitor" the first page of results talks about 4K
 displays, laptops, KDE, virtual machine monitors (NVMM), GPUs - none of
 which I can guess might be related to the tool in this PR.

 Much less evil to rename it ... although I still don't actually know
 what it monitors from a read of the PR and a quick search!  Maybe files
 because of Christos' comment?!

 Cheers,
 Simon.

Home	PR Database Search