NetBSD Problem Report #57901

From www@netbsd.org  Sat Feb  3 00:41:10 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id DB8A51A9238
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  3 Feb 2024 00:41:10 +0000 (UTC)
Message-Id: <20240203004109.B34761A9239@mollari.NetBSD.org>
Date: Sat,  3 Feb 2024 00:41:09 +0000 (UTC)
From: rwhitlock22@gmail.com
Reply-To: rwhitlock22@gmail.com
To: gnats-bugs@NetBSD.org
Subject: vim-motif builds, but without motif
X-Send-Pr-Version: www-1.0

>Number:         57901
>Category:       pkg
>Synopsis:       vim-motif builds, but without motif
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bsiegert
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 03 00:45:00 +0000 2024
>Closed-Date:    Fri Apr 05 03:07:56 +0000 2024
>Last-Modified:  Fri Apr 05 03:07:56 +0000 2024
>Originator:     Robert Whitlock
>Release:        pkgsrc-2023Q4
>Organization:
>Environment:
NetBSD thinkpad 10.0_RC3 NetBSD 10.0_RC3 (GENERIC_thinkpad) #0: Wed Jan 31 00:00:23 EST 2024  rob@thinkpad:/usr/src/sys/arch/amd64/compile/GENERIC_thinkpad amd64
>Description:
The editors/vim-motif package builds, but its configure.ac was looking for motif in specific locations, none of which included packages under /usr/pkg, predictably, and so gave up on building with motif support. The result is a vim-motif without motif support.
>How-To-Repeat:
cd /usr/pkgsrc/editors/vim-motif
make install
vim -g

and watch it give an error about not being compiled with GUI support.
>Fix:
pkgsrc has configuration settings for the location of motif, so let's use them!

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/editors/vim-motif/Makefile,v
retrieving revision 1.43
diff -u -r1.43 Makefile
--- Makefile	16 Sep 2023 12:43:14 -0000	1.43
+++ Makefile	3 Feb 2024 00:39:14 -0000
@@ -9,7 +9,7 @@
 DEPENDS+=		vim-share-${VIM_VERSION}.${VIM_PATCHLEVEL}{,nb*}:../../editors/vim-share
 CONFLICTS+=		vim-[0-9]* vim-gtk2-[0-9]* vim-gtk3-[0-9]*

-CONFIGURE_ARGS+=	--enable-gui=motif
+CONFIGURE_ARGS+=	--enable-gui=motif GUI_INC_LOC=-I${MOTIFBASE:Q}/include GUI_LIB_LOC=-L${MOTIFBASE:Q}/lib
 CONFIGURE_ARGS+=	--with-tlib=${BUILDLINK_LIBNAME.termcap}

 CONFIGURE_ENV+=		MOTIFBASE=${MOTIFBASE}

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->bsiegert
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Thu, 29 Feb 2024 14:05:10 +0000
Responsible-Changed-Why:
take


State-Changed-From-To: open->pending-pullups
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Thu, 29 Feb 2024 19:35:17 +0000
State-Changed-Why:
Patch applied, thanks!
Will send a pullup ticket for 2023Q4.


From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/57901 CVS commit: pkgsrc/editors/vim-motif
Date: Thu, 29 Feb 2024 19:37:26 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Thu Feb 29 19:37:26 UTC 2024

 Modified Files:
 	pkgsrc/editors/vim-motif: Makefile

 Log Message:
 vim-motif: bump revision after last commit

 PR pkg/57901


 To generate a diff of this commit:
 cvs rdiff -u -r1.44 -r1.45 pkgsrc/editors/vim-motif/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: riastradh@NetBSD.org
State-Changed-When: Fri, 05 Apr 2024 03:07:56 +0000
State-Changed-Why:
2023Q4 is EOL, 2024Q1 has the fix


>Unformatted:

Home	PR Database Search