NetBSD Problem Report #58127

From www@netbsd.org  Mon Apr  8 19:17:01 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 6A00F1A9239
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  8 Apr 2024 19:17:01 +0000 (UTC)
Message-Id: <20240408191700.55BBB1A923B@mollari.NetBSD.org>
Date: Mon,  8 Apr 2024 19:17:00 +0000 (UTC)
From: cang1@live.co.uk
Reply-To: cang1@live.co.uk
To: gnats-bugs@NetBSD.org
Subject: [patch] Add support for a range of USB serial adapters
X-Send-Pr-Version: www-1.0

>Number:         58127
>Category:       kern
>Synopsis:       [patch] Add support for a range of USB serial adapters
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 08 19:20:00 +0000 2024
>Closed-Date:    Sun Apr 28 13:36:52 +0000 2024
>Last-Modified:  Sun Apr 28 13:36:52 +0000 2024
>Originator:     Cameron Williams
>Release:        HEAD
>Organization:
>Environment:
>Description:
Patch for a range of USB-to-Serial (RS232/422/485) devices. Please let me know if the white-spacing got messed up. Based on -CURRENT (HEAD)
>How-To-Repeat:

>Fix:
Index: uftdi.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/uftdi.c,v
retrieving revision 1.77
diff -u -r1.77 uftdi.c
--- uftdi.c	26 Mar 2024 03:38:02 -0000	1.77
+++ uftdi.c	8 Apr 2024 18:24:26 -0000
@@ -126,6 +126,25 @@
  */
 static const struct usb_devno uftdi_devs[] = {
 	{ USB_VENDOR_BBELECTRONICS, USB_PRODUCT_BBELECTRONICS_USOTL4 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US101 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US159 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US235 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US257 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US279_12 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US279_34 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US279_56 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US279_78 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US313 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US320 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US324 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US346_12 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US346_34 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US701_12 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US701_34 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US842_12 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US842_34 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US842_56 },
+	{ USB_VENDOR_BRAINBOXES, USB_PRODUCT_BRAINBOXES_US842_78 },
 	{ USB_VENDOR_FALCOM, USB_PRODUCT_FALCOM_TWIST },
 	{ USB_VENDOR_FALCOM, USB_PRODUCT_FALCOM_SAMBA },
 	{ USB_VENDOR_FTDI, USB_PRODUCT_FTDI_SERIAL_230X },
Index: usbdevs
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs,v
retrieving revision 1.814
diff -u -r1.814 usbdevs
--- usbdevs	28 Feb 2024 21:50:51 -0000	1.814
+++ usbdevs	8 Apr 2024 18:24:27 -0000
@@ -1118,6 +1118,27 @@
 product BILLIONTON USBE100	0x8511	USBE100
 product BILLIONTON USB2AR	0x90ff	USB2AR Ethernet

+/* Brainboxes Limited products */
+product BRAINBOXES US101	0x1011	US-101 USB2Serial 1xRS232
+product BRAINBOXES US159	0x1021	US-159 USB2Serial 1xRS232
+product BRAINBOXES US235	0x1017	US-235 USB2Serial 1xRS232
+product BRAINBOXES US257	0x5001	US-257 USB2Serial 2xRS232
+product BRAINBOXES US279_12	0x2021	US-279 USB2Serial 8xRS232 (Port 1 and 2)
+product BRAINBOXES US279_34	0x2022	US-279 USB2Serial 8xRS232 (Port 3 and 4)
+product BRAINBOXES US279_56	0x2023	US-279 USB2Serial 8xRS232 (Port 5 and 6)
+product BRAINBOXES US279_78	0x2024	US-279 USB2Serial 8xRS232 (Port 7 and 8)
+product BRAINBOXES US313	0x6001	US-313 USB2Serial 2xRS422/485
+product BRAINBOXES US320	0x1019	US-320 USB2Serial 1xRS422/485
+product BRAINBOXES US324	0x1013	US-324 USB2Serial 1xRS422/485
+product BRAINBOXES US346_12	0x3011	US-346 USB2Serial 4xRS422/485 (Port 1 and 2)
+product BRAINBOXES US346_34	0x3012	US-346 USB2Serial 4xRS422/485 (Port 3 and 4)
+product BRAINBOXES US701_12	0x2011	US-701 USB2Serial 4xRS232 (Port 1 and 2)
+product BRAINBOXES US701_34	0x2012	US-701 USB2Serial 4xRS232 (Port 3 and 4)
+product BRAINBOXES US842_12	0x8001	US-842 USB2Serial 8xRS422/485 (Port 1 and 2)
+product BRAINBOXES US842_34	0x8002	US-842 USB2Serial 8xRS422/485 (Port 3 and 4)
+product BRAINBOXES US842_56	0x8003	US-842 USB2Serial 8xRS422/485 (Port 5 and 6)
+product BRAINBOXES US842_78	0x8004	US-842 USB2Serial 8xRS422/485 (Port 7 and 8)
+
 /* Broadcom products */
 product BROADCOM BCMFW		0x0bdc	BCMFW
 product BROADCOM BCM2033	0x2000	BCM2033

>Release-Note:

>Audit-Trail:
From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58127 CVS commit: src/sys/dev/usb
Date: Wed, 17 Apr 2024 02:32:09 +0000

 Module Name:	src
 Committed By:	maya
 Date:		Wed Apr 17 02:32:09 UTC 2024

 Modified Files:
 	src/sys/dev/usb: usbdevs

 Log Message:
 Add some USB serial adapters

 From Cameron Williams in PR kern/58127


 To generate a diff of this commit:
 cvs rdiff -u -r1.814 -r1.815 src/sys/dev/usb/usbdevs

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58127 CVS commit: src/sys/dev/usb
Date: Wed, 17 Apr 2024 02:34:45 +0000

 Module Name:	src
 Committed By:	maya
 Date:		Wed Apr 17 02:34:45 UTC 2024

 Modified Files:
 	src/sys/dev/usb: uftdi.c

 Log Message:
 Add support for a range of USB serial adapters

 From Cameron Williams in PR kern/58127


 To generate a diff of this commit:
 cvs rdiff -u -r1.77 -r1.78 src/sys/dev/usb/uftdi.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 17 Apr 2024 02:36:20 +0000
State-Changed-Why:
applied, thanks! (please reply if you want it in a particular release too, otherwise I'll apply it to HEAD only)


From: Cameron Williams <cang1@live.co.uk>
To: gnats-bugs@netbsd.org, maya@netnsd.org
Cc: kern-bug-people@netbsd.org, netbsd-bugs@netbsd.org,
	gnats-admin@netbsd.org
Subject: Re: kern/58127 ([patch] Add support for a range of USB serial
 adapters)
Date: Wed, 17 Apr 2024 08:11:57 +0100

 Thanks Maya.
 Would it be possible to commit it to netbsd-9 and netbsd-10 too? No particular reason why, just if it's not too much work :).

 -- Cameron

 On Wed, Apr 17, 2024 at 02:36:20AM +0000, maya@NetBSD.org wrote:
 > Synopsis: [patch] Add support for a range of USB serial adapters
 > 
 > State-Changed-From-To: open->closed
 > State-Changed-By: maya@NetBSD.org
 > State-Changed-When: Wed, 17 Apr 2024 02:36:20 +0000
 > State-Changed-Why:
 > applied, thanks! (please reply if you want it in a particular release too, otherwise I'll apply it to HEAD only)
 > 
 > 
 > 

State-Changed-From-To: closed->needs-pullups
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 17 Apr 2024 18:56:12 +0000
State-Changed-Why:


State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: maya@NetBSD.org
State-Changed-When: Fri, 26 Apr 2024 21:19:00 +0000
State-Changed-Why:
pullup-10 #679
pullup-9 #1837


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58127 CVS commit: [netbsd-10] src/sys/dev/usb
Date: Sun, 28 Apr 2024 13:26:36 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun Apr 28 13:26:36 UTC 2024

 Modified Files:
 	src/sys/dev/usb [netbsd-10]: uftdi.c usbdevs

 Log Message:
 Pull up following revision(s) (requested by maya in ticket #679):

 	sys/dev/usb/uftdi.c: revision 1.78
 	sys/dev/usb/usbdevs: revision 1.815

 Add some USB serial adapters
 From Cameron Williams in PR kern/58127

 Add support for a range of USB serial adapters
 From Cameron Williams in PR kern/58127


 To generate a diff of this commit:
 cvs rdiff -u -r1.76.6.2 -r1.76.6.3 src/sys/dev/usb/uftdi.c
 cvs rdiff -u -r1.806.4.2 -r1.806.4.3 src/sys/dev/usb/usbdevs

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/58127 CVS commit: [netbsd-9] src/sys/dev/usb
Date: Sun, 28 Apr 2024 13:29:40 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun Apr 28 13:29:40 UTC 2024

 Modified Files:
 	src/sys/dev/usb [netbsd-9]: uftdi.c usbdevs

 Log Message:
 Pull up following revision(s) (requested by maya in ticket #1837):

 	sys/dev/usb/uftdi.c: revision 1.78
 	sys/dev/usb/usbdevs: revision 1.815

 Add some USB serial adapters
 From Cameron Williams in PR kern/58127

 Add support for a range of USB serial adapters
 From Cameron Williams in PR kern/58127


 To generate a diff of this commit:
 cvs rdiff -u -r1.70 -r1.70.2.1 src/sys/dev/usb/uftdi.c
 cvs rdiff -u -r1.770.4.13 -r1.770.4.14 src/sys/dev/usb/usbdevs

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 28 Apr 2024 13:36:52 +0000
State-Changed-Why:
pullups done


>Unformatted:

Home	PR Database Search