NetBSD Problem Report #58182

From www@netbsd.org  Sun Apr 21 13:51:03 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 75C7F1A9238
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 21 Apr 2024 13:51:03 +0000 (UTC)
Message-Id: <20240421135102.187561A923B@mollari.NetBSD.org>
Date: Sun, 21 Apr 2024 13:51:02 +0000 (UTC)
From: campbell+netbsd@mumble.net
Reply-To: campbell+netbsd@mumble.net
To: gnats-bugs@NetBSD.org
Subject: missing driver for ACPI I2C device INT3432, INT3433
X-Send-Pr-Version: www-1.0

>Number:         58182
>Category:       kern
>Synopsis:       missing driver for ACPI I2C device INT3432, INT3433
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 21 13:55:00 +0000 2024
>Last-Modified:  Mon May 06 11:40:01 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10
>Organization:
The NetDWIIC Foundatacpi
>Environment:
>Description:
User reports non-working trackpad in machine with this dmesg, having I2C0 and I2C1 ACPI nodes with CIDs INT3432 and INT3433, respectively:

https://dmesgd.nycbug.org/index.cgi?do=view&id=7699

Cursory glance at Linux suggests the following ACPI CID are also DesignWare I2C controllers, which dwiic(4) should handle:

INT33C2
INT33C3
INT3432
INT3433
80860F41
808622C1
AMDI0019
HISI02A1
HISI02A2
HISI02A3
HYGO0010
>How-To-Repeat:

>Fix:
Yes, please!

>Audit-Trail:
From: pierre-alain+netbsd@toret.fr
To: gnats-bugs@NetBSD.org
Cc: netbsd-bugs@NetBSD.org
Subject: Re: kern/58182: missing driver for ACPI I2C device INT3432, INT3433
Date: Mon, 6 May 2024 13:34:58 +0200

 I'm the user for which Taylor reported the issue.

 He sent me the following patch :

  From 4f104a63e5af7ce1c2b7c9d83e401d6285479264 Mon Sep 17 00:00:00 2001
 From: Taylor R Campbell <riastradh@NetBSD.org>
 Date: Sun, 21 Apr 2024 13:51:33 +0000
 Subject: [PATCH] dwiic(4): Attach at CIDs INT3432 and INT3433 in acpi(4).

 PR kern/58182
 ---
   sys/dev/acpi/dwiic_acpi.c | 2 ++
   1 file changed, 2 insertions(+)

 diff --git a/sys/dev/acpi/dwiic_acpi.c b/sys/dev/acpi/dwiic_acpi.c
 index 6c8b32c81702..81ee0540b779 100644
 --- a/sys/dev/acpi/dwiic_acpi.c
 +++ b/sys/dev/acpi/dwiic_acpi.c
 @@ -64,6 +64,8 @@ static const struct device_compatible_entry 
 compat_data[] = {
   	{ .compat = "AMDI0010" },	/* AMD FCH */
   	{ .compat = "AMDI0510" },	/* AMD Seattle */
   	{ .compat = "APMC0D0F" },	/* Ampere eMAG */
 +	{ .compat = "INT3432" },
 +	{ .compat = "INT3433" },
   	DEVICE_COMPAT_EOL
   };


 Once applied dmesg shows the following lines :

 [     1.020295] dwiic0 at acpi0 (I2C0, INT3432-1): mem 
 0x91122000-0x91122fff irq 7
 [     1.020295] dwiic0: autoconfiguration error: failed initializing
 [     1.020295] dwiic1 at acpi0 (I2C1, INT3433-1): mem 
 0x91124000-0x91124fff irq 7
 [     1.020295] dwiic1: autoconfiguration error: failed initializing

Home	PR Database Search