NetBSD Problem Report #58195

From www@netbsd.org  Thu Apr 25 13:10:35 2024
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 8757A1A9238
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 25 Apr 2024 13:10:35 +0000 (UTC)
Message-Id: <20240425131033.D5B281A923B@mollari.NetBSD.org>
Date: Thu, 25 Apr 2024 13:10:33 +0000 (UTC)
From: pho@cielonegro.org
Reply-To: pho@cielonegro.org
To: gnats-bugs@NetBSD.org
Subject: vmt(4) driver conflicts with open-vm-tools
X-Send-Pr-Version: www-1.0

>Number:         58195
>Category:       kern
>Synopsis:       vmt(4) driver conflicts with open-vm-tools
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 25 13:15:00 +0000 2024
>Closed-Date:    Sat May 11 04:05:55 +0000 2024
>Last-Modified:  Sat May 11 04:05:55 +0000 2024
>Originator:     PHO
>Release:        10.0
>Organization:
TNF
>Environment:
NetBSD yukari.cielonegro.org 10.0 NetBSD 10.0 (GENERIC64) #0: Thu Mar 28 08:33:33 UTC 2024  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/evbarm/compile/GENERIC64 evbarm
>Description:
http://mail-index.netbsd.org/current-users/2024/04/20/msg045201.html

The vmt(4) driver causes a conflict with vmtoolsd(8) from sysutils/open-vm-tools. The driver works by establishing an RPC channel called TCLO between VMware guest and host to receive controlling messages from the host. The problem is that vmt(4) is essentially a subset of vmtoolsd(8), and they both use the same RPC channel, but TCLO is never meant to be simultaneously used by two distinct services in the same VM guest. So when vmtoolsd(8) is running while also vmt(4) is active, they continually fight for the channel, both get rejected by the confused VM host, and neither one can establish a stable communication line.
>How-To-Repeat:
Run NetBSD 10.0 on VMware and make sure the vmt(4) driver is loaded. Then install sysutils/open-vm-tools, add "vmtools=YES" to /etc/rc.conf, and run "/etc/rc.d/vmtools start".

The two services will start fighting and spam the console without achieving anything. Try shutting down the guest from VMware; since no TCLO channel is successfully established, the host forcibly terminates the VM without first asking the guest politely to shut down itself.
>Fix:
There is no obvious way to detect the conflict and automatically turn off the vmt(4) driver, because the RPC can be done from userland via hypervisor calls. It does not require any kind of privileges, so the driver cannot know that there is another service in the userland that is trying to do essentially the same thing as the driver.

So I initially thought of modularizing vmt(4) and unloading the module right before starting vmtoolsd, but I scrapped the idea because that wouldn't work when kern.securelevel is above zero. The next thing I came up with was to simply add a sysctl knob to turn it off. I'll soon post a patch to do just that.

>Release-Note:

>Audit-Trail:
From: PHO <pho@cielonegro.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/58195: vmt(4) driver conflicts with open-vm-tools
Date: Thu, 25 Apr 2024 22:36:31 +0900

 This is a multi-part message in MIME format.
 --------------KvxgWL6YBL5ErUQKnRRuFFky
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 7bit

 Here's the patch. I will commit this if nobody objects within a 
 reasonable time period.
 --------------KvxgWL6YBL5ErUQKnRRuFFky
 Content-Type: text/x-patch; charset=UTF-8;
  name="0002-kern-58195-Add-a-sysctl-variable-to-turn-off-vmt-4.patch"
 Content-Disposition: attachment;
  filename*0="0002-kern-58195-Add-a-sysctl-variable-to-turn-off-vmt-4.patc";
  filename*1="h"
 Content-Transfer-Encoding: base64

 RnJvbSBjNzFjZTU2YjgwYjY0NmRmMDIwYmZmMDRlMzQ3NzliYWI3ZmI0ZTZjIE1vbiBTZXAg
 MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQSE8gPHBob0BjaWVsb25lZ3JvLm9yZz4KRGF0ZTog
 VGh1LCAyNSBBcHIgMjAyNCAwMDozMDo0NyArMDkwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSBr
 ZXJuLzU4MTk1OiBBZGQgYSBzeXNjdGwgdmFyaWFibGUgdG8gdHVybiBvZmYgdm10KDQpCgpU
 aGUgdm10KDQpIGRyaXZlciBjYXVzZXMgYSBjb25mbGljdCB3aXRoIHZtdG9vbHNkKDgpIGZy
 b20Kc3lzdXRpbHMvb3Blbi12bS10b29scy4gVGhlIGRyaXZlciB3b3JrcyBieSBlc3RhYmxp
 c2hpbmcgYW4gUlBDIGNoYW5uZWwKY2FsbGVkIFRDTE8gYmV0d2VlbiBWTXdhcmUgZ3Vlc3Qg
 YW5kIGhvc3QgdG8gcmVjZWl2ZSBjb250cm9sbGluZyBtZXNzYWdlcwpmcm9tIHRoZSBob3N0
 LiBUaGUgcHJvYmxlbSBpcyB0aGF0IHZtdCg0KSBpcyBlc3NlbnRpYWxseSBhIHN1YnNldCBv
 Zgp2bXRvb2xzZCg4KSwgYW5kIHRoZXkgYm90aCB1c2UgdGhlIHNhbWUgUlBDIGNoYW5uZWws
 IGJ1dCBUQ0xPIGlzIG5ldmVyCm1lYW50IHRvIGJlIHNpbXVsdGFuZW91c2x5IHVzZWQgYnkg
 dHdvIGRpc3RpbmN0IHNlcnZpY2VzIGluIHRoZSBzYW1lIFZNCmd1ZXN0LiBTbyB3aGVuIHZt
 dG9vbHNkKDgpIGlzIHJ1bm5pbmcgd2hpbGUgYWxzbyB2bXQoNCkgaXMgYWN0aXZlLCB0aGV5
 CmNvbnRpbnVhbGx5IGZpZ2h0IGZvciB0aGUgY2hhbm5lbCwgYm90aCBnZXQgcmVqZWN0ZWQg
 YnkgdGhlIGNvbmZ1c2VkIFZNCmhvc3QsIGFuZCBuZWl0aGVyIG9uZSBjYW4gZXN0YWJsaXNo
 IGEgc3RhYmxlIGNvbW11bmljYXRpb24gbGluZS4KCklkZWFsbHkgdGhlIGRyaXZlciBzaG91
 bGQgZGV0ZWN0IHRoYXQgdGhlcmUgaXMgYSBjb25mbGljdGluZyBkYWVtb24gcnVubmluZwpp
 biB1c2VybGFuZCwgYnV0IHRoYXQgaXMgaW5mZWFzaWJsZSBiZWNhdXNlIHRoZSBSUEMgY2Fu
 IGJlIGRvbmUgZnJvbQp1c2VybGFuZCB2aWEgaHlwZXJ2aXNvciBjYWxscy4gSXQgZG9lcyBu
 b3QgcmVxdWlyZSBhbnkga2luZCBvZiBwcml2aWxlZ2VzLApzbyB0aGUgZHJpdmVyIGNhbm5v
 dCBrbm93IHRoYXQgdGhlcmUgaXMgYW5vdGhlciBzZXJ2aWNlIGluIHVzZXJsYW5kIHRoYXQg
 aXMKdHJ5aW5nIHRvIGRvIGVzc2VudGlhbGx5IHRoZSBzYW1lIHRoaW5nIGFzIHRoZSBkcml2
 ZXIuCgpTbyBhIHdvcmthcm91bmQgaXMgdG8gYWRkIGEgc3lzY3RsIGtub2IgdG8gdHVybiBp
 dCBvZmYuIEl0J3Mgc3Vib3B0aW1hbCwKYnV0IGlzIHN0aWxsIGJldHRlciB0aGFuIG5vdGhp
 bmcuCi0tLQogc2hhcmUvbWFuL21hbjQvdm10LjQgICB8ICA0NyArKysrKysrKysrKysKIHN5
 cy9kZXYvdm10L3ZtdF9zdWJyLmMgfCAxNTcgKysrKysrKysrKysrKysrKysrKysrKysrKysr
 KysrKystLS0tLS0tLS0KIHN5cy9kZXYvdm10L3ZtdHZhci5oICAgfCAgIDEgKwogMyBmaWxl
 cyBjaGFuZ2VkLCAxNzMgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25zKC0pCgpkaWZmIC0t
 Z2l0IGEvc2hhcmUvbWFuL21hbjQvdm10LjQgYi9zaGFyZS9tYW4vbWFuNC92bXQuNAppbmRl
 eCA5MjY1N2Q0NTE3ZS4uMjM2ZjQwY2UyMWMgMTAwNjQ0Ci0tLSBhL3NoYXJlL21hbi9tYW40
 L3ZtdC40CisrKyBiL3NoYXJlL21hbi9tYW40L3ZtdC40CkBAIC02Myw2ICs2MywyMyBAQCB3
 aGVuIHRoZSBob3N0IGlzIHN1c3BlbmRlZCwgYmVjYXVzZSBpbiB0aGlzIGNhc2UgdGhlCiBk
 cml2ZXIgcmVjZWl2ZXMgbm8gbm90aWZpY2F0aW9uIG9mIHN1Y2ggYW4gZXZlbnQuCiBTZXR0
 aW5nIHRoaXMgdHVuYWJsZSB0byB6ZXJvIGRpc2FibGVzIGNsb2NrIHN5bmNocm9uaXphdGlv
 bi4KIC5FbAorLlNzIEVuYWJsaW5nIGFuZCBkaXNhYmxpbmcgdGhlIGRyaXZlcgorVGhlCisu
 Tm0KK2RyaXZlciBpcyBpbml0aWFsbHkgZW5hYmxlZCB3aGVuIGl0IGlzIGF0dGFjaGVkLCBh
 bmQgY2FuIGJlIHRlbXBvcmFyaWx5CitkaXNhYmxlZCBieSBzZXR0aW5nIHRoZQorLlZhIG1h
 Y2hkZXAudm10MC5lbmFibGUKKy5YciBzeXNjdGwgOAordmFyaWFibGUgdG8KKy5MaSAwIC4K
 K1NldHRpbmcgaXQgYmFjayB0bworLkxpIDEKK2VuYWJsZXMgdGhlIGRyaXZlciBhZ2Fpbi4g
 SXQgaXMgbmVjZXNzYXJ5IHRvIGRpc2FibGUgdGhlIGRyaXZlciB0byB1c2UKKy5YciB2bXRv
 b2xzZCA4Citmcm9tCisuTGsgaHR0cHM6Ly9naXRodWIuY29tL3Ztd2FyZS9vcGVuLXZtLXRv
 b2xzIG9wZW4tdm0tdG9vbHMKKyhzZWUKKy5TeCBCVUdTICkgLgogLlNoIFNFRSBBTFNPCiAu
 XCIgLlhyIGNwdSA0ICwKIC5YciBwb3dlcmQgOApAQCAtNzgsMyArOTUsMzMgQEAgVGhlCiAu
 Tm0KIGRyaXZlciB3YXMgd3JpdHRlbiBieQogLkFuIERhdmlkIEd3eW5uZSBBcSBNdCBkbGdA
 b3BlbmJzZC5vcmcgLgorLlNoIEJVR1MKKy5ObQoraXMga25vd24gdG8gY2F1c2UgYSBjb25m
 bGljdCB3aXRoCisuWHIgdm10b29sc2QgOAorZnJvbQorLkxpIG9wZW4tdm0tdG9vbHMgLgor
 Lk5tCit3b3JrcyBieSBlc3RhYmxpc2hpbmcgYW4gUlBDIGNoYW5uZWwgY2FsbGVkIFRDTE8g
 YmV0d2VlbiBWTXdhcmUgZ3Vlc3QgYW5kCitob3N0IHRvIHJlY2VpdmUgY29udHJvbGxpbmcg
 bWVzc2FnZXMgZnJvbSB0aGUgaG9zdC4gVGhlIHByb2JsZW0gaXMgdGhhdAorLk5tCitpcyBl
 c3NlbnRpYWxseSBhIHN1YnNldCBvZgorLlhyIHZtdG9vbHNkIDggLAorYW5kIHRoZXkgYm90
 aCB1c2UgdGhlIHNhbWUgUlBDIGNoYW5uZWwsIGJ1dCBUQ0xPIGlzIG5ldmVyIG1lYW50IHRv
 IGJlCitzaW11bHRhbmVvdXNseSB1c2VkIGJ5IHR3byBkaXN0aW5jdCBzZXJ2aWNlcyBpbiB0
 aGUgc2FtZSBWTSBndWVzdC4gU28gd2hlbgorLlhyIHZtdG9vbHNkIDgKK2lzIHJ1bm5pbmcg
 d2hpbGUgYWxzbworLk5tCitpcyBhY3RpdmUsIHRoZXkgY29udGludWFsbHkgZmlnaHQgZm9y
 IHRoZSBjaGFubmVsLCBib3RoIGdldCByZWplY3RlZCBieSB0aGUKK2NvbmZ1c2VkIFZNIGhv
 c3QsIGFuZCBuZWl0aGVyIG9uZSBjYW4gZXN0YWJsaXNoIGEgc3RhYmxlIGNvbW11bmljYXRp
 b24KK2xpbmUuCisuUHAKK1RoZQorLlZhIG1hY2hkZXAudm10MC5lbmFibGUKKy5YciBzeXNj
 dGwgOAordmFyaWFibGUgKHNlZQorLlN4IEVuYWJsaW5nIGFuZCBkaXNhYmxpbmcgdGhlIGRy
 aXZlciApCitoYXMgYmVlbiBpbnRyb2R1Y2VkIHRvIHdvcmsgYXJvdW5kIHRoaXMgcHJvYmxl
 bS4gRGlzYWJsZSB0aGUgZHJpdmVyIGJlZm9yZQorbGF1bmNoaW5nCisuWHIgdm10b29sc2Qg
 OCAsCithbmQgZW5hYmxlIGl0IGFnYWluIGFmdGVyIHRlcm1pbmF0aW5nIHRoZSBkYWVtb24u
 CmRpZmYgLS1naXQgYS9zeXMvZGV2L3ZtdC92bXRfc3Vici5jIGIvc3lzL2Rldi92bXQvdm10
 X3N1YnIuYwppbmRleCAxNDQ0NDdhOWQxYy4uMTk1ZjliNTVmMmMgMTAwNjQ0Ci0tLSBhL3N5
 cy9kZXYvdm10L3ZtdF9zdWJyLmMKKysrIGIvc3lzL2Rldi92bXQvdm10X3N1YnIuYwpAQCAt
 NTAsOSArNTAsMTQgQEAKIAogLyogI2RlZmluZSBWTVRfREVCVUcgKi8KIAorc3RhdGljIGlu
 dCB2bXRfZW5hYmxlKHN0cnVjdCB2bXRfc29mdGMgKik7CitzdGF0aWMgaW50IHZtdF9kaXNh
 YmxlKHN0cnVjdCB2bXRfc29mdGMgKik7CisKIHN0YXRpYyBpbnQgdm10X3N5c2N0bF9zZXR1
 cF9yb290KGRldmljZV90KTsKIHN0YXRpYyBpbnQgdm10X3N5c2N0bF9zZXR1cF9jbG9ja19z
 eW5jKGRldmljZV90LCBjb25zdCBzdHJ1Y3Qgc3lzY3Rsbm9kZSAqKTsKIHN0YXRpYyBpbnQg
 dm10X3N5c2N0bF91cGRhdGVfY2xvY2tfc3luY19wZXJpb2QoU1lTQ1RMRk5fUFJPVE8pOwor
 c3RhdGljIGludCB2bXRfc3lzY3RsX3NldHVwX2VuYWJsZShkZXZpY2VfdCwgY29uc3Qgc3Ry
 dWN0IHN5c2N0bG5vZGUgKik7CitzdGF0aWMgaW50IHZtdF9zeXNjdGxfdXBkYXRlX2VuYWJs
 ZShTWVNDVExGTl9QUk9UTyk7CiAKIHN0YXRpYyB2b2lkIHZtX2NtZChzdHJ1Y3Qgdm1fYmFj
 a2Rvb3IgKik7CiBzdGF0aWMgdm9pZCB2bV9pbnMoc3RydWN0IHZtX2JhY2tkb29yICopOwpA
 QCAtMjI0LDIzICsyMjksNiBAQCB2bXRfY29tbW9uX2F0dGFjaChzdHJ1Y3Qgdm10X3NvZnRj
 ICpzYykKIAogCXNjLT5zY19ycGNfYnVmID0ga21lbV9hbGxvYyhWTVRfUlBDX0JVRkxFTiwg
 S01fU0xFRVApOwogCi0JaWYgKHZtX3JwY19vcGVuKCZzYy0+c2NfdGNsb19ycGMsIFZNX1JQ
 Q19PUEVOX1RDTE8pICE9IDApIHsKLQkJYXByaW50X2Vycm9yX2RldihzZWxmLCAiZmFpbGVk
 IHRvIG9wZW4gYmFja2Rvb3IgUlBDIGNoYW5uZWwgIgotCQkgICAgIihUQ0xPIHByb3RvY29s
 KVxuIik7Ci0JCWdvdG8gZnJlZTsKLQl9Ci0Jc2MtPnNjX3RjbG9fcnBjX29wZW4gPSB0cnVl
 OwotCi0JLyogZG9uJ3Qga25vdyBpZiB0aGlzIGlzIGltcG9ydGFudCBhdCBhbGwgeWV0ICov
 Ci0JaWYgKHZtX3JwY19zZW5kX3JwY2lfdHgoc2MsCi0JICAgICJ0b29scy5jYXBhYmlsaXR5
 LmhnZnNfc2VydmVyIHRvb2xib3ggMSIpICE9IDApIHsKLQkJYXByaW50X2Vycm9yX2Rldihz
 ZWxmLAotCQkgICAgImZhaWxlZCB0byBzZXQgSEdGUyBzZXJ2ZXIgY2FwYWJpbGl0eVxuIik7
 Ci0JCWdvdG8gZnJlZTsKLQl9Ci0KLQlwbWZfZGV2aWNlX3JlZ2lzdGVyMShzZWxmLCBOVUxM
 LCBOVUxMLCB2bXRfc2h1dGRvd24pOwotCiAJc3lzbW9uX3Rhc2tfcXVldWVfaW5pdCgpOwog
 CiAJc2MtPnNjX2V2X3Bvd2VyLmV2X3NtcHN3LnNtcHN3X3R5cGUgPSBQU1dJVENIX1RZUEVf
 UE9XRVI7CkBAIC0yNTgsMzMgKzI0Niw5NSBAQCB2bXRfY29tbW9uX2F0dGFjaChzdHJ1Y3Qg
 dm10X3NvZnRjICpzYykKIAlzYy0+c2Nfc21wc3dfdmFsaWQgPSB0cnVlOwogCiAJY2FsbG91
 dF9zZXRmdW5jKCZzYy0+c2NfdGljaywgdm10X3RpY2ssIHNjKTsKLQljYWxsb3V0X3NjaGVk
 dWxlKCZzYy0+c2NfdGljaywgaHopOwotCiAJY2FsbG91dF9zZXRmdW5jKCZzYy0+c2NfdGNs
 b190aWNrLCB2bXRfdGNsb190aWNrLCBzYyk7Ci0JY2FsbG91dF9zY2hlZHVsZSgmc2MtPnNj
 X3RjbG9fdGljaywgaHopOwotCXNjLT5zY190Y2xvX3BpbmcgPSAxOwotCiAJY2FsbG91dF9z
 ZXRmdW5jKCZzYy0+c2NfY2xvY2tfc3luY190aWNrLCB2bXRfY2xvY2tfc3luY190aWNrLCBz
 Yyk7Ci0JY2FsbG91dF9zY2hlZHVsZSgmc2MtPnNjX2Nsb2NrX3N5bmNfdGljaywKLQkgICAg
 bXN0b2h6KHNjLT5zY19jbG9ja19zeW5jX3BlcmlvZF9zZWNvbmRzICogMTAwMCkpOworCisJ
 aWYgKHZtdF9lbmFibGUoc2MpICE9IDApIHsKKwkJZ290byBmcmVlOworCX0KIAogCXZtdF9z
 eW5jX2d1ZXN0X2Nsb2NrKHNjKTsKIAogCXJldHVybjsKIAogZnJlZToKKwlpZiAoc2MtPnNj
 X3RjbG9fcnBjX29wZW4pCisJCXZtX3JwY19jbG9zZSgmc2MtPnNjX3RjbG9fcnBjKTsKIAlp
 ZiAoc2MtPnNjX3JwY19idWYpCiAJCWttZW1fZnJlZShzYy0+c2NfcnBjX2J1ZiwgVk1UX1JQ
 Q19CVUZMRU4pOwotCXBtZl9kZXZpY2VfcmVnaXN0ZXIoc2VsZiwgTlVMTCwgTlVMTCk7CisJ
 cG1mX2RldmljZV9kZXJlZ2lzdGVyKHNlbGYpOwogCWlmIChzYy0+c2NfbG9nKQogCQlzeXNj
 dGxfdGVhcmRvd24oJnNjLT5zY19sb2cpOwogfQogCisvKgorICogRW5hYmxlIHRoZSB2bXQg
 ZHJpdmVyLgorICovCitzdGF0aWMgaW50Cit2bXRfZW5hYmxlKHN0cnVjdCB2bXRfc29mdGMg
 KnNjKQoreworCWRldmljZV90IHNlbGYgPSBzYy0+c2NfZGV2OworCWludCBydjsKKworCWlm
 IChzYy0+c2NfZW5hYmxlZCkKKwkJcmV0dXJuIDA7CisKKwlydiA9IHZtX3JwY19vcGVuKCZz
 Yy0+c2NfdGNsb19ycGMsIFZNX1JQQ19PUEVOX1RDTE8pOworCWlmIChydiAhPSAwKSB7CisJ
 CWFwcmludF9lcnJvcl9kZXYoc2VsZiwgImZhaWxlZCB0byBvcGVuIGJhY2tkb29yIFJQQyBj
 aGFubmVsICIKKwkJICAgICIoVENMTyBwcm90b2NvbClcbiIpOworCQlyZXR1cm4gcnY7CisJ
 fQorCXNjLT5zY190Y2xvX3JwY19vcGVuID0gdHJ1ZTsKKworCS8qIGRvbid0IGtub3cgaWYg
 dGhpcyBpcyBpbXBvcnRhbnQgYXQgYWxsIHlldCAqLworCXJ2ID0gdm1fcnBjX3NlbmRfcnBj
 aV90eChzYywKKwkgICAgInRvb2xzLmNhcGFiaWxpdHkuaGdmc19zZXJ2ZXIgdG9vbGJveCAx
 Iik7CisJaWYgKHJ2ICE9IDApIHsKKwkJYXByaW50X2Vycm9yX2RldihzZWxmLAorCQkgICAg
 ImZhaWxlZCB0byBzZXQgSEdGUyBzZXJ2ZXIgY2FwYWJpbGl0eVxuIik7CisJCXJldHVybiBy
 djsKKwl9CisKKwlwbWZfZGV2aWNlX3JlZ2lzdGVyMShzZWxmLCBOVUxMLCBOVUxMLCB2bXRf
 c2h1dGRvd24pOworCisJc2MtPnNjX3RjbG9fcGluZyA9IDE7CisJY2FsbG91dF9zY2hlZHVs
 ZSgmc2MtPnNjX3RpY2ssIGh6KTsKKwljYWxsb3V0X3NjaGVkdWxlKCZzYy0+c2NfdGNsb190
 aWNrLCBoeik7CisJY2FsbG91dF9zY2hlZHVsZSgmc2MtPnNjX2Nsb2NrX3N5bmNfdGljaywK
 KwkgICAgbXN0b2h6KHNjLT5zY19jbG9ja19zeW5jX3BlcmlvZF9zZWNvbmRzICogMTAwMCkp
 OworCisJZGV2aWNlX3ByaW50ZihzZWxmLCAidm10IGRyaXZlciBlbmFibGVkXG4iKTsKKwlz
 Yy0+c2NfZW5hYmxlZCA9IHRydWU7CisJcmV0dXJuIDA7Cit9CisKK3N0YXRpYyBpbnQKK3Zt
 dF9kaXNhYmxlKHN0cnVjdCB2bXRfc29mdGMgKnNjKQoreworCWRldmljZV90IHNlbGYgPSBz
 Yy0+c2NfZGV2OworCisJaWYgKCFzYy0+c2NfZW5hYmxlZCkKKwkJcmV0dXJuIDA7CisKKwlj
 YWxsb3V0X2hhbHQoJnNjLT5zY190aWNrLCBOVUxMKTsKKwljYWxsb3V0X2hhbHQoJnNjLT5z
 Y190Y2xvX3RpY2ssIE5VTEwpOworCWNhbGxvdXRfaGFsdCgmc2MtPnNjX2Nsb2NrX3N5bmNf
 dGljaywgTlVMTCk7CisKKwlwbWZfZGV2aWNlX2RlcmVnaXN0ZXIoc2VsZik7CisKKwlpZiAo
 c2MtPnNjX3RjbG9fcnBjX29wZW4pCisJCXZtX3JwY19jbG9zZSgmc2MtPnNjX3RjbG9fcnBj
 KTsKKworCWRldmljZV9wcmludGYoc2VsZiwgInZtdCBkcml2ZXIgZGlzYWJsZWRcbiIpOwor
 CXNjLT5zY19lbmFibGVkID0gZmFsc2U7CisJcmV0dXJuIDA7Cit9CisKIGludAogdm10X2Nv
 bW1vbl9kZXRhY2goc3RydWN0IHZtdF9zb2Z0YyAqc2MpCiB7Ci0JaWYgKHNjLT5zY190Y2xv
 X3JwY19vcGVuKQotCQl2bV9ycGNfY2xvc2UoJnNjLT5zY190Y2xvX3JwYyk7CisJdm10X2Rp
 c2FibGUoc2MpOwogCiAJaWYgKHNjLT5zY19zbXBzd192YWxpZCkgewogCQlzeXNtb25fcHN3
 aXRjaF91bnJlZ2lzdGVyKCZzYy0+c2NfZXZfc2xlZXAuZXZfc21wc3cpOwpAQCAtMjkyLDEz
 ICszNDIsOCBAQCB2bXRfY29tbW9uX2RldGFjaChzdHJ1Y3Qgdm10X3NvZnRjICpzYykKIAkJ
 c3lzbW9uX3Bzd2l0Y2hfdW5yZWdpc3Rlcigmc2MtPnNjX2V2X3Bvd2VyLmV2X3NtcHN3KTsK
 IAl9CiAKLQljYWxsb3V0X2hhbHQoJnNjLT5zY190aWNrLCBOVUxMKTsKIAljYWxsb3V0X2Rl
 c3Ryb3koJnNjLT5zY190aWNrKTsKLQotCWNhbGxvdXRfaGFsdCgmc2MtPnNjX3RjbG9fdGlj
 aywgTlVMTCk7CiAJY2FsbG91dF9kZXN0cm95KCZzYy0+c2NfdGNsb190aWNrKTsKLQotCWNh
 bGxvdXRfaGFsdCgmc2MtPnNjX2Nsb2NrX3N5bmNfdGljaywgTlVMTCk7CiAJY2FsbG91dF9k
 ZXN0cm95KCZzYy0+c2NfY2xvY2tfc3luY190aWNrKTsKIAogCWlmIChzYy0+c2NfcnBjX2J1
 ZikKQEAgLTMzNiwxMSArMzgxLDE3IEBAIHZtdF9zeXNjdGxfc2V0dXBfcm9vdChkZXZpY2Vf
 dCBzZWxmKQogCSAgICBTWVNDVExfREVTQ1IoIlVVSUQgb2YgdmlydHVhbCBtYWNoaW5lIiks
 CiAJICAgIE5VTEwsIDAsIHNjLT5zY191dWlkLCAwLAogCSAgICBDVExfQ1JFQVRFLCBDVExf
 RU9MKTsKKwlpZiAocnYgIT0gMCkKKwkJZ290byBmYWlsOwogCiAJcnYgPSB2bXRfc3lzY3Rs
 X3NldHVwX2Nsb2NrX3N5bmMoc2VsZiwgdm10X25vZGUpOwogCWlmIChydiAhPSAwKQogCQln
 b3RvIGZhaWw7CiAKKwlydiA9IHZtdF9zeXNjdGxfc2V0dXBfZW5hYmxlKHNlbGYsIHZtdF9u
 b2RlKTsKKwlpZiAocnYgIT0gMCkKKwkJZ290byBmYWlsOworCiAJcmV0dXJuIDA7CiAKIGZh
 aWw6CkBAIC0zOTgsNiArNDQ5LDQ4IEBAIHZtdF9zeXNjdGxfdXBkYXRlX2Nsb2NrX3N5bmNf
 cGVyaW9kKFNZU0NUTEZOX0FSR1MpCiAJcmV0dXJuIDA7CiB9CiAKK3N0YXRpYyBpbnQKK3Zt
 dF9zeXNjdGxfc2V0dXBfZW5hYmxlKGRldmljZV90IHNlbGYsIGNvbnN0IHN0cnVjdCBzeXNj
 dGxub2RlICpyb290X25vZGUpCit7CisJc3RydWN0IHZtdF9zb2Z0YyAqc2MgPSBkZXZpY2Vf
 cHJpdmF0ZShzZWxmKTsKKwlpbnQgcnY7CisKKwlydiA9IHN5c2N0bF9jcmVhdGV2KCZzYy0+
 c2NfbG9nLCAwLCAmcm9vdF9ub2RlLCBOVUxMLAorCSAgICBDVExGTEFHX1JFQURXUklURSwg
 Q1RMVFlQRV9CT09MLCAiZW5hYmxlIiwKKwkgICAgU1lTQ1RMX0RFU0NSKCJEcml2ZXIgZW5h
 YmxlZCIpLAorCSAgICB2bXRfc3lzY3RsX3VwZGF0ZV9lbmFibGUsIDAsICh2b2lkICopc2Ms
 IDAsCisJICAgIENUTF9DUkVBVEUsIENUTF9FT0wpOworCisJcmV0dXJuIHJ2OworfQorCitz
 dGF0aWMgaW50Cit2bXRfc3lzY3RsX3VwZGF0ZV9lbmFibGUoU1lTQ1RMRk5fQVJHUykKK3sK
 KwlzdHJ1Y3Qgc3lzY3Rsbm9kZSBub2RlOworCXN0cnVjdCB2bXRfc29mdGMgKnNjOworCWJv
 b2wgZW5hYmxlZDsKKwlpbnQgZXJyb3I7CisKKwlub2RlID0gKnJub2RlOworCXNjID0gKHN0
 cnVjdCB2bXRfc29mdGMgKilub2RlLnN5c2N0bF9kYXRhOworCisJZW5hYmxlZCA9IHNjLT5z
 Y19lbmFibGVkOworCW5vZGUuc3lzY3RsX2RhdGEgPSAmZW5hYmxlZDsKKwllcnJvciA9IHN5
 c2N0bF9sb29rdXAoU1lTQ1RMRk5fQ0FMTCgmbm9kZSkpOworCWlmIChlcnJvciB8fCBuZXdw
 ID09IE5VTEwpCisJCXJldHVybiBlcnJvcjsKKworCWlmIChlbmFibGVkKSB7CisJCXZtdF9l
 bmFibGUoc2MpOworCX0KKwllbHNlIHsKKwkJdm10X2Rpc2FibGUoc2MpOworCX0KKworCXJl
 dHVybiAwOworfQorCiBzdGF0aWMgdm9pZAogdm10X2Nsb2NrX3N5bmNfdGljayh2b2lkICp4
 YXJnKQogewpkaWZmIC0tZ2l0IGEvc3lzL2Rldi92bXQvdm10dmFyLmggYi9zeXMvZGV2L3Zt
 dC92bXR2YXIuaAppbmRleCA1MTcyYTYyMTlmOS4uNzQwZTFmOTQ2N2EgMTAwNjQ0Ci0tLSBh
 L3N5cy9kZXYvdm10L3ZtdHZhci5oCisrKyBiL3N5cy9kZXYvdm10L3ZtdHZhci5oCkBAIC02
 MSw2ICs2MSw3IEBAIHN0cnVjdCB2bXRfZXZlbnQgewogc3RydWN0IHZtdF9zb2Z0YyB7CiAJ
 ZGV2aWNlX3QJCXNjX2RldjsKIAorCWJvb2wJCQlzY19lbmFibGVkOwogCXN0cnVjdCBzeXNj
 dGxsb2cJKnNjX2xvZzsKIAlzdHJ1Y3Qgdm1fcnBjCQlzY190Y2xvX3JwYzsKIAlib29sCQkJ
 c2NfdGNsb19ycGNfb3BlbjsKLS0gCjIuNDQuMAoK

 --------------KvxgWL6YBL5ErUQKnRRuFFky--

From: PHO <pho@cielonegro.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/58195: vmt(4) driver conflicts with open-vm-tools
Date: Thu, 25 Apr 2024 22:39:44 +0900

 I unintentionally sent the patch in base64. You can read it here:
 https://github.com/depressed-pho/netbsd-src/commit/c71ce56b80b646df020bff04e34779bab7fb4e6c

From: matthew green <mrg@eterna23.net>
To: gnats-bugs@netbsd.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
    netbsd-bugs@netbsd.org
Subject: re: kern/58195: vmt(4) driver conflicts with open-vm-tools
Date: Fri, 26 Apr 2024 17:45:00 +1000

 FWIW, you can 'drvctl -d vmt0' to detach the driver.

 i once had to do this and re-load it when it was log-spewing
 in my netbsd guest after a long long uptime.


 .mrg.

From: PHO <pho@cielonegro.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/58195: vmt(4) driver conflicts with open-vm-tools
Date: Sat, 27 Apr 2024 00:42:28 +0900

 On 4/26/24 16:50, matthew green wrote:
 > 
 >   FWIW, you can 'drvctl -d vmt0' to detach the driver.
 >   
 >   i once had to do this and re-load it when it was log-spewing
 >   in my netbsd guest after a long long uptime.

 I didn't know we could do it! Thanks!
 That means we don't need a sysctl knob for this. We just need to 
 implement cpu_rescan() and cpu_childdetached() for aarch64. Here's my 
 updated patch:
 https://github.com/depressed-pho/netbsd-src/commit/d062d13a53328c0bee643d585411a516f88a512e

From: PHO <pho@cielonegro.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/58195: vmt(4) driver conflicts with open-vm-tools
Date: Sat, 27 Apr 2024 00:55:03 +0900

 Oops, I forgot to include an update to vmt.4 in my patch:
 https://github.com/depressed-pho/netbsd-src/commit/e4ad6befb7e49995b804baf49026e1e53bed347d

From: PHO <pho@cielonegro.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/58195: vmt(4) driver conflicts with open-vm-tools
Date: Thu, 9 May 2024 21:46:00 +0900

 Committed. Will file a pull-up request later:
 http://mail-index.netbsd.org/source-changes/2024/05/09/msg151250.html

State-Changed-From-To: open->closed
State-Changed-By: pho@NetBSD.org
State-Changed-When: Sat, 11 May 2024 04:05:55 +0000
State-Changed-Why:
I decided not to request a pull-up for this one. Users can use open-vm-tools no problem as long as port-arm/58194 isn't pulled up.


>Unformatted:

Home	PR Database Search