NetBSD Problem Report #6613

Received: (qmail 12305 invoked from network); 19 Dec 1998 18:17:14 -0000
Message-Id: <199812191803.DAA17639@pppp.ap.so-net.ne.jp>
Date: Sun, 20 Dec 1998 03:03:56 +0900 (JST)
From: kei_sun@ba2.so-net.ne.jp
Reply-To: kei_sun@ba2.so-net.ne.jp
To: gnats-bugs@gnats.netbsd.org
Subject: missing #ifdef ALTXBUTTONS in aed.c
X-Send-Pr-Version: 3.95

>Number:         6613
>Category:       port-mac68k
>Synopsis:       missing #ifdef ALTXBUTTONS in aed.c
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    gnats-admin
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 19 10:20:01 +0000 1998
>Closed-Date:    Sat Dec 19 21:43:27 +0000 1998
>Last-Modified:  Sat Dec 19 21:43:54 +0000 1998
>Originator:     SUNAGAWA Keiki
>Release:        -current source SUP'ed in 1998/12/16
>Organization:
	individual
>Environment:
	NetBSD/mac68k 1.3I

>Description:
	mac68k/dev/aed.c has a line using ADBK_3 not enclosed with
	#ifdef ALTXBUTTONS.  It probably breaks on non-US keyboard.
>How-To-Repeat:
	I don't know about this option, but some people said it was
	incompatible with non-US keyboard.
>Fix:
	apply the diff below.

Index: aed.c
===================================================================
RCS file: /cvsroot/src/sys/arch/mac68k/dev/aed.c,v
retrieving revision 1.1.1.1
retrieving revision 1.1.1.1.2.1
diff -u -r1.1.1.1 -r1.1.1.1.2.1
--- aed.c	1998/12/16 00:05:55	1.1.1.1
+++ aed.c	1998/12/17 02:29:47	1.1.1.1.2.1
@@ -244,7 +244,9 @@
 			aed_handoff(&new_event);
 			break;
 		case ADBK_KEYUP(ADBK_RIGHT):
+#ifdef ALTXBUTTONS
 		case ADBK_KEYUP(ADBK_3):
+#endif
 			aed_sc->sc_buttons &= ~4;	/* right up */
 			new_event.def_addr = ADBADDR_MS;
 			new_event.u.m.buttons = aed_sc->sc_buttons;
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: scottr 
State-Changed-When: Sat Dec 19 13:43:27 PST 1998 
State-Changed-Why:  
Made suggested change; thanks! 
>Unformatted:

Home	PR Database Search