NetBSD Problem Report #7304

Received: (qmail 8268 invoked from network); 2 Apr 1999 09:33:33 -0000
Message-Id: <199904020933.SAA02865@mirage.ceres.dti.ne.jp>
Date: Fri, 2 Apr 1999 18:33:29 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@gnats.netbsd.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: mips/locore.S does not include machine/endian.h
X-Send-Pr-Version: 3.95

>Number:         7304
>Category:       port-mips
>Synopsis:       mips/locore.S does not include machine/endian.h
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    port-mips-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 02 01:35:01 +0000 1999
>Closed-Date:    Thu Apr 15 18:18:04 +0000 1999
>Last-Modified:  Thu Apr 15 18:19:55 +0000 1999
>Originator:     Izumi Tsutsui
>Release:        NetBSD-current supped on 19990324
>Organization:
Izumi Tsutsui	Himeji City Japan
>Environment:
System: NetBSD/newsmips 1.3K, maybe all mips ports

>Description:
arch/mips/mips/locore.S does not include machine/endian.h,
so `#if BYTE_ORDER == LITTLE_ENDIAN' would not work correctly.

>How-To-Repeat:
Do make depend on mips system and see the .depend file.
locore.o does not depend machine/endian.h.

>Fix:
Just include machine/endian.h in locore.S.

--- sys/arch/mips/mips/locore.S.orig	Mon Mar  1 21:13:35 1999
+++ sys/arch/mips/mips/locore.S	Wed Mar 24 12:40:05 1999
@@ -70,6 +70,7 @@
 #endif

 #include <machine/param.h>
+#include <machine/endian.h>
 #include <mips/asm.h>
 #include <mips/cpuregs.h>

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: ad 
State-Changed-When: Thu Apr 15 11:18:04 PDT 1999 
State-Changed-Why:  
ntohl/htonl have been disabled in locore.S due to duplication in libkern. 
The pr is no longer pertinant. 
>Unformatted:

Home	PR Database Search