NetBSD Problem Report #10314

Received: (qmail 25905 invoked from network); 7 Jun 2000 22:28:58 -0000
Message-Id: <200006072228.PAA12585@nbwww.isc.org>
Date: Wed, 7 Jun 2000 15:28:58 -0700 (PDT)
From: cgd@netbsd.org
Reply-To: cgd@netbsd.org
To: gnats-bugs@gnats.netbsd.org
Subject: DDB confusion around if_arp.c's symbols, if no ethernets present.
X-Send-Pr-Version: www-1.0

>Number:         10314
>Category:       kern
>Synopsis:       netatalk forces inclusion of if_arp.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 07 22:29:00 +0000 2000
>Closed-Date:    
>Last-Modified:  Fri Jun 09 15:07:17 +0000 2000
>Originator:     Chris Demetriou
>Release:        NetBSD-current as of 20000606
>Organization:
>Environment:
any should work; just configur a kernel with DDB and INET,
and no ethernets.
>Description:
compile a kernel DDB and INET, but without any ethernet devices.
you get a link error, about 'db_show_arptab' being an undefined
symbol.

note that DDB (in db_command.c) includes the cmd which shows
the arp table if INET is defined.

However, if_arp.c is included in the kernel only if there are
devices which need 'arp' (#include arp.h ; NARP > 0), or if
netatalk is in the kernel.
>How-To-Repeat:

see above.
>Fix:

a naive fix would be to #include "arp.h" and change the #ifdef INET
to be #if defined(INET) && (NARP > 0).

However, there's the question of what to do about the netatalk case.
(why include if_arp.c if it's not needed in that case, so, how is it
needed, and if it is needed what is it used for?  and then based
on that, should the arptab display code be included if NETATALK
is defined.)  However, if you look at if_arp.c, if INET isn't
defined, it gets #if'd entirely out!

So, there are multiple levels of lossage here: the incorrect use of
db_show_arptab, and the inclusion of if_arp.c if netatalk.  The
resolution of the latter may impact the fix for the former...
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: kern-bug-people->jhawk 
Responsible-Changed-By: jhawk 
Responsible-Changed-When: Wed Jun 7 19:59:08 PDT 2000 
Responsible-Changed-Why:  
I broke it. 
State-Changed-From-To: open->feedback 
State-Changed-By: jhawk 
State-Changed-When: Thu Jun 8 14:07:10 PDT 2000 
State-Changed-Why:  
Naive fix applied. 
If you think this isn't good enough, or that the netatalk problem 
should be addressed as well, then I guess we can change the 
PR synopsis and the >Responsible person ;-) 

Is this sufficient? 

From: cgd@netbsd.org (Chris G. Demetriou)
To: jhawk@netbsd.org
Cc: gnats-bugs@netbsd.org
Subject: Re: kern/10314
Date: 08 Jun 2000 14:27:14 -0700

 jhawk@netbsd.org writes:
 > If you think this isn't good enough, or that the netatalk problem
 > should be addressed as well, then I guess we can change the
 > PR synopsis and the >Responsible person ;-)

 I think it's probably appropriate to do this; what's currently there
 ... makes no sense.


 cgd
 -- 
 Chris Demetriou - cgd@netbsd.org - http://www.netbsd.org/People/Pages/cgd.html
 Disclaimer: Not speaking for NetBSD, just expressing my own opinion.

From: John Hawkinson <jhawk@MIT.EDU>
To: gnats-bugs@netbsd.org
Cc:  
Subject: Re: kern/10314
Date: Fri, 9 Jun 2000 11:04:11 -0400 (EDT)

 Original face of the PR:

 >Number:         10314
 >Category:       kern
 >Synopsis:       DDB confusion around if_arp.c's symbols, if no ethernets present.
 >Confidential:   no
 >Severity:       serious
 >Priority:       high
 >Responsible:    jhawk
 >State:          feedback
 >Class:          sw-bug
 >Submitter-Id:   net
State-Changed-From-To: feedback->open 
State-Changed-By: jhawk 
State-Changed-When: Fri Jun 9 08:05:32 PDT 2000 
State-Changed-Why:  
DDB problem fixed, but netatalk problem still there. 


Responsible-Changed-From-To: jhawk->kern-bug-people 
Responsible-Changed-By: jhawk 
Responsible-Changed-When: Fri Jun 9 08:05:32 PDT 2000 
Responsible-Changed-Why:  
I was only here to fix the ddb problem. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.