NetBSD Problem Report #10328

Received: (qmail 1302 invoked from network); 8 Jun 2000 17:16:37 -0000
Message-Id: <200006081716.KAA08495@nbwww.isc.org>
Date: Thu, 8 Jun 2000 10:16:37 -0700 (PDT)
From: cgd@netbsd.org
Reply-To: cgd@netbsd.org
To: gnats-bugs@gnats.netbsd.org
Subject: 'en' driver uses vtophys, kernel printf %b
X-Send-Pr-Version: www-1.0

>Number:         10328
>Category:       kern
>Synopsis:       'en' driver uses vtophys, kernel printf %b
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 08 17:17:00 +0000 2000
>Closed-Date:    Sun Sep 23 21:28:31 +0000 2018
>Last-Modified:  Sun Sep 23 21:28:31 +0000 2018
>Originator:     Chris Demetriou
>Release:        NetBSD-current sources as of 20000606
>Organization:
>Environment:
N/A

>Description:
the 'en' ATM driver (in particular, its source file
sys/dev/ic/midway.c) uses the deprecated (for MI driver
use), non-portable vtophys() interface.  It should
be using the bus_dma routines.

The same file also uses the kernel printf() %b format.
This is deprecated, and bitmask_snprintf() should be used
instead.
>How-To-Repeat:
for the vtophys() problem: read the source, or try to include the
'tl' driver for an arch which doesn't include vtophys().  (Even
on some which compile, the use of vtophys() will probably be
incorrect and result in incorrect operation.)

for the printf() %b problem: read the source, or try to compile
with a stock GNU gcc cross-compiler (e.g. targetted for mips-elf)
which doesn't include our __kprintf__ attribute.  in versions ofgcc
which don't support our __kprintf__ attribute, no special attribute
will be defined for kernel printf(), and so it will assume that it
behaves like standard (user-land) printf(), which doesn't support %b.
>Fix:


>Release-Note:
>Audit-Trail:
From: Sergey Svishchev <svs+pr@grep.ru>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/10328
Date: Sun, 20 Jan 2008 14:00:04 +0300

 The code uses bitmask_snprintf() now; vtophys() are still there.

 -- 
 Sergey Svishchev

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 23 Sep 2018 21:28:31 +0000
State-Changed-Why:
en(4) removed, together with the ATM code. Thanks for the report, and sorry there wasn't a fix for it before the removal.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.