NetBSD Problem Report #1048
From gnats Sun May 14 17:50:58 1995
Received: from pain.lcs.mit.edu (pain.lcs.mit.edu [128.52.46.239]) by sun-lamp.cs.berkeley.edu (8.6.10/8.6.10) with ESMTP id RAA29082 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Sun, 14 May 1995 17:50:57 -0700
Message-Id: <199505150051.CAA26340@skarven.itea.unit.no>
Date: Mon, 15 May 1995 02:51:34 +0200
From: Arne Juul <arnej@itea.unit.no>
Reply-To: arnej@itea.unit.no
To: gnats-bugs@NetBSD.ORG
Subject: modf routine fails on mips
X-Send-Pr-Version: 3.2
>Number: 1048
>Category: lib
>Synopsis: modf routine fails on large values
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: lib-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun May 14 18:05:03 +0000 1995
>Closed-Date: Tue Sep 26 18:34:57 +0000 1995
>Last-Modified: Tue Sep 26 18:37:15 +0000 1995
>Originator: Arne H Juul
>Release: current
>Organization:
"Norwegian University of Technology and Science"
>Environment:
System: NetBSD dekk.pvv.unit.no 1.0A NetBSD 1.0A (GNE) #8: Fri May 12 19:31:07 MET DST 1995 arnej@dekk.pvv.unit.no:/home/nova/a/arnej/netbsd/src/src/sys/arch/pmax/compile/GNE pmax
>Description:
When I compiled perl for NetBSD/pmax, it failed a 'basic test'.
Further investigation showed that the int() function (in perl) didn't
work for moderately large numbers. This can be traced to the modf()
routine in the C library.
>How-To-Repeat:
Run this test program:
#include <stdio.h>
#include <math.h>
main()
{
double a, b, c;
int i;
a= 0.0295623451187264398;
for (i=0; i<25; i++) {
c=modf(a,&b);
printf("modf %35.9f gives %30.4f / %15.9f\n", a, b, c);
a *= 10.0;
}
}
Compare with i386 results, which are OK.
>Fix:
Here's a replacement for /usr/src/lib/libc/arch/mips/gen/modf.S:
/*-
* Copyright (c) 1991, 1993, 1995
* The Regents of the University of California. All rights reserved.
*
* This code is derived from software contributed to Berkeley by
* Ralph Campbell.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. All advertising materials mentioning features or use of this software
* must display the following acknowledgement:
* This product includes software developed by the University of
* California, Berkeley and its contributors.
* 4. Neither the name of the University nor the names of its contributors
* may be used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#include <machine/machAsmDefs.h>
#if defined(LIBC_SCCS) && !defined(lint)
ASMSTR("from: @(#)modf.s 8.1 (Berkeley) 6/4/93")
ASMSTR("$Id: modf.S,v 1.3 1994/12/15 17:24:50 mycroft Exp $")
#endif /* LIBC_SCCS and not lint */
/*
* double modf(val, iptr)
* double val, *iptr;
* returns: xxx and n (in *iptr) where val == n.xxx
*/
LEAF(modf)
cfc1 t0, $31 # get the control register
li.d $f2, 4503599627370496e0 # f2 <- 2^52
or t1, t0, 0x3 # set rounding mode to round to zero
xor t1, t1, 0x2 # (i.e., 01)
ctc1 t1, $31
abs.d $f4, $f12 # f4 <- |f12|
c.olt.d $f4, $f2 # f4 ? < f2
bc1f 1f # leave alone if Nan, infinity
# or >=2^52
c.eq.d $f12,$f4 # was f12 positive ?
add.d $f4,$f2,$f4 # round off to integer
bc1f 2f # No -> will have to negate result
sub.d $f0,$f4,$f2 # Remove fudge factor
j 1f # integer fraction got
2:
sub.d $f0,$f2,$f4 # Remove fudge factor and negate
1:
ctc1 t0, $31 # restore old rounding mode
s.d $f0, 0(a2) # save the integer part
sub.d $f0, $f12, $f0 # subtract val - integer part
j ra
END(modf)
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: jonathan
State-Changed-When: Tue Sep 26 14:34:57 EDT 1995
State-Changed-Why:
Suggested replacement MIPS modf() tested on little-endian mips and installed.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.