NetBSD Problem Report #10698
Received: (qmail 25357 invoked from network); 28 Jul 2000 00:07:22 -0000
Message-Id: <200007280006.RAA12979@swamp.sfo.geocast.net>
Date: Thu, 27 Jul 2000 17:06:47 -0700 (PDT)
From: Castor Fu <castor@geocast.com>
Reply-To: castor@geocast.com
To: gnats-bugs@gnats.netbsd.org
Subject: accept returns garbage w/evanescent connects to unix domain sockets
X-Send-Pr-Version: 3.95
>Number: 10698
>Category: kern
>Synopsis: accept returns garbage w/evanescent connects to unix domain sockets
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: itojun
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Jul 28 00:08:00 +0000 2000
>Closed-Date: Mon Feb 12 22:40:34 +0000 2001
>Last-Modified: Mon Feb 12 22:40:34 +0000 2001
>Originator: Castor Fu
>Release: NetBSD-1.4
>Organization:
Geocast Network Systems
>Environment:
Seen on NetBSD/i386 and Geocast's internal mips based platform.
Also seen with NetBSD-1.5 branch as of a few days ago on i386.
System: NetBSD swamp.sfo.geocast.net 1.4P NetBSD 1.4P (GEO_STANDARD) #171: Thu Jun 29 15:56:03 PDT 2000 castor@swamp.sfo.geocast.net:/usr/export/home/castor/nb/usr/src/sys/arch/i386/compile/GEO_STANDARD i386
>Description:
accept(2) on a unix domain socket returns an invalid value
for the address family in a sockaddr when connector closes
before the accept is executed.
>How-To-Repeat:
The following two programs and the script can be used to exercise
this bug.
#!/bin/sh
set -x
./nps &
spid=$!
sleep 1
./xclient &
sleep 1
c1pid=$!
./xclient&
c2pid=$!
sleep 1
kill $c2pid
sleep 1
kill $c1pid
sleep 1
kill -0 $spid
/* nps.c, no NSPR */
#include <unistd.h>
#include <string.h>
#include <sys/socket.h>
#include <sys/un.h>
#include <errno.h>
#include <stdio.h>
#define SOCKET_NAME "/ftsoNSPR"
int main(int argc, char *argv[])
{
struct sockaddr_un addr;
int rv;
int conn = -1;
struct sockaddr_un serverAddr;
int listenSocket;
char buf[256];
int size;
int i;
int addr_len;
unlink("ftsoNSPR");
memset(&serverAddr, 0, sizeof(serverAddr)); /* set up address structure */
serverAddr.sun_len = sizeof(serverAddr);
serverAddr.sun_family = AF_UNIX;
if (getcwd(serverAddr.sun_path, sizeof(serverAddr.sun_path)) == NULL) {
fprintf(stderr, "Can't get current directory.\n");
return -1;
}
size = strlen(serverAddr.sun_path);
strncat(serverAddr.sun_path, SOCKET_NAME,
sizeof(serverAddr.sun_path) - size);
/* create the socket */
listenSocket = socket(AF_UNIX, SOCK_STREAM, 0);
if (listenSocket == -1) {
fprintf(stderr, "Error returned from PR_Socket: %d", errno);
return -1;
}
fprintf(stderr, "path is %s\n", serverAddr.sun_path);
/* bind the socket */
if (bind(listenSocket, (struct sockaddr *) &serverAddr, sizeof(serverAddr)) == -1) {
fprintf(stderr, "Server error binding to server address: OS error
%d\n",
errno);
return -1;
}
/* set the socket up to receive inbound connections */
if ( listen(listenSocket, 10) == -1) {
fprintf(stderr, "Server error listening to server socket\n");
return -1;
}
while(1) {
if (conn == -1) {
addr_len = sizeof(addr);
printf("calling accept\n");
conn = accept(listenSocket, (struct sockaddr *)&addr, &addr_len);
printf("returns %d\n", conn);
if (addr.sun_family != AF_UNIX) {
fprintf(stderr, "address family is %d\n", addr.sun_family);
abort();
}
continue;
}
if(read(conn, buf, 10) > 0) {
fprintf(stderr, "read this: ");
for(i = 0; i < 10; i++)
fprintf(stderr, "%c", buf[i]);
} else {
close(conn);
conn = -1;
}
}
return 0;
}
/* xclient.c */
#include <unistd.h>
#include <string.h>
#include <errno.h>
#include <stdio.h>
#include <sys/socket.h>
#include <sys/un.h>
#define SOCKET_NAME "/ftsoNSPR"
int main(int argc, char *argv[])
{
struct sockaddr_un serverAddr;
int l;
int scriptSock;
/* set up address structure */
memset(&serverAddr, 0, sizeof(serverAddr));
serverAddr.sun_len = sizeof(serverAddr);
serverAddr.sun_family = AF_LOCAL;
if (getcwd(serverAddr.sun_path, sizeof(serverAddr.sun_path)) == NULL) {
fprintf(stderr, "Can't get current directory.\n");
exit(1);
}
l = strlen(serverAddr.sun_path);
strncat(serverAddr.sun_path, SOCKET_NAME,
sizeof(serverAddr.sun_path) - l);
/* create the socket */
scriptSock = socket(AF_LOCAL, SOCK_STREAM, 0);
if ( scriptSock < 0 ) {
fprintf(stderr,
"initScriptSocket: Error returned from socket: %s %s\n",
strerror(errno), serverAddr.sun_path);
exit(1);
}
/* connect */
if ( connect(scriptSock, (struct sockaddr *) &serverAddr,
sizeof(serverAddr)) != 0) {
fprintf(stderr,
"initScriptSocket: Error returned from connect: %s\n",
strerror(errno));
exit(1);
}
write(scriptSock, "hi there.\n", 10);
while(1) {
sleep(1000);
}
}
>Fix:
none yet.
>Release-Note:
>Audit-Trail:
From: itojun@itojun.org (Jun-ichiro itojun Hagino)
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: Re: kern/10698
Date: Tue, 23 Jan 2001 02:27:36 +0900 (JST)
i experienced similar issue with AF_INET. see PR 12027.
State-Changed-From-To: open->feedback
State-Changed-By: itojun
State-Changed-When: Mon Jan 22 18:37:18 PST 2001
State-Changed-Why:
i've made a change so that there won't be junk sockaddr. it still can return
0-length sockaddr. need more investigation to find a standard behavior.
Responsible-Changed-From-To: kern-bug-people->itojun
Responsible-Changed-By: itojun
Responsible-Changed-When: Mon Jan 22 18:38:32 PST 2001
Responsible-Changed-Why:
mine
State-Changed-From-To: feedback->open
State-Changed-By: castor
State-Changed-When: Wed Jan 24 16:05:04 PST 2001
State-Changed-Why:
The 0-length sockaddr doesn't look like standard behavior.
Linux 2.2.5, SunOS 5.7, and FreeBSD 3.3 all pass back sockaddrs which
look fairly sane. Since there's data which can be read back,
they do return 0.
The Netscape Portable Runtime expects that accept(2) will return a
reasonable sockaddr, and will generate an assertion error if it does not.
State-Changed-From-To: open->feedback
State-Changed-By: itojun
State-Changed-When: Wed Feb 7 04:22:43 PST 2001
State-Changed-Why:
sys/kern/uipc_socket.c 1.53
State-Changed-From-To: feedback->closed
State-Changed-By: castor
State-Changed-When: Mon Feb 12 14:38:54 PST 2001
State-Changed-Why:
The changes committed by itojun seem reasonable. The correctness is
debatable in the unix domain case, but I think it does avoid
the worst cases.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.