NetBSD Problem Report #1077

From gnats  Sat May 27 10:10:44 1995
Received: from pain.lcs.mit.edu (pain.lcs.mit.edu [128.52.46.239]) by sun-lamp.cs.berkeley.edu (8.6.10/8.6.10) with ESMTP id KAA01106 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Sat, 27 May 1995 10:10:44 -0700
Message-Id: <199505261605.SAA20464@kiss.informatik.tu-muenchen.de>
Date: Fri, 26 May 1995 18:05:51 +0200
From: Rolf Grossmann <grossman@kiss.informatik.tu-muenchen.de>
Reply-To: grossman@kiss.informatik.tu-muenchen.de
To: gnats-bugs@NetBSD.ORG
Subject: fix 2 bugs with send-pr.el
X-Send-Pr-Version: 3.2

>Number:         1077
>Category:       misc
>Synopsis:       fix 2 bugs with send-pr.el
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 27 10:20:05 +0000 1995
>Closed-Date:    Thu Sep 14 14:02:49 +0000 1995
>Last-Modified:  Thu Sep 14 18:03:04 +0000 1995
>Originator:     
>Release:        NetBSD-current 1.0A
>Organization:
	I guess not
>Environment:
System: NetBSD kiss 1.0A NetBSD 1.0A (TIGKI) #22: Mon May 8 19:51:43 MET DST 1995 grossman@kiss:/export/netbsd/src/sys/arch/sparc/compile/TIGKI sparc


>Description:
	Send-pr tries to read /gnats-adm/config with /bin/sh and looks for
	error messages with a regular expression. This expression however
	does not cover all possible error messages the shell might emit for
	that command.
	Also, there is a bug in the send-pr script that prevents send-pr.el
	from sending the bug report: A wrong comparison.

>How-To-Repeat:
	Start emacs and execute send-pr when the file /gnats-adm/config
	does not exist.
	If you fix that bug, note that send-pr still refuses to send your
	problem report, even though it's correct.

>Fix:
	Apply the following patches in /usr/src/gnu/usr.bin/send-pr:

===================================================================
RCS file: /export/netbsd/mastersrc/netbsd/gnu/usr.bin/send-pr/send-pr-el.in,v
retrieving revision 1.1.1.1
diff -c -r1.1.1.1 send-pr-el.in
*** send-pr-el.in	1995/02/09 18:38:39	1.1.1.1
--- send-pr-el.in	1995/05/26 15:35:31
***************
*** 95,101 ****
        (set-buffer buf)
        (shell-command (concat ". " gnats:root "/gnats-adm/config; echo $" var )
  		     t)
!       (if (looking-at "/bin/sh:\\|\n")
  	  (setq ret nil)
  	(setq ret (buffer-substring (point-min) (- (point-max) 1)))))
      (kill-buffer buf)
--- 95,101 ----
        (set-buffer buf)
        (shell-command (concat ". " gnats:root "/gnats-adm/config; echo $" var )
  		     t)
!       (if (looking-at "/bin/sh:\\|\n\\|\\.:")
  	  (setq ret nil)
  	(setq ret (buffer-substring (point-min) (- (point-max) 1)))))
      (kill-buffer buf)
===================================================================
RCS file: /export/netbsd/mastersrc/netbsd/gnu/usr.bin/send-pr/send-pr.sh,v
retrieving revision 1.1.1.2
diff -c -r1.1.1.2 send-pr.sh
*** send-pr.sh	1995/03/02 15:13:07	1.1.1.2
--- send-pr.sh	1995/05/26 15:58:44
***************
*** 461,467 ****
        $ECHON1 "a)bort, e)dit or s)end? $ECHON2"
        read input
      else
!       if [ $CNT -eq 5 ]; then
          input=s
        else
          input=a
--- 461,467 ----
        $ECHON1 "a)bort, e)dit or s)end? $ECHON2"
        read input
      else
!       if [ $CNT -eq 6 ]; then
          input=s
        else
          input=a
>Release-Note:
>Audit-Trail:

State-Changed-From-To: open->feedback
State-Changed-By: jtc
State-Changed-When: Thu Aug 31 15:04:01 1995
State-Changed-Why:
I've integrated send-pr 3.95 from Cygnus, which addresses your first patch,
and I've checked in your second.  Can you try this out and get back to me 
with the results?

State-Changed-From-To: feedback->closed
State-Changed-By: jtc
State-Changed-When: Thu Sep 14 14:02:49 1995
State-Changed-Why:
Send-pr.el now works.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.