NetBSD Problem Report #11028
Received: (qmail 21045 invoked from network); 16 Sep 2000 06:35:02 -0000
Message-Id: <200009160634.CAA15437@dr-teeth.arepa.com>
Date: Sat, 16 Sep 2000 02:34:47 -0400 (EDT)
From: Eric Mumpower <nocturne@arepa.com>
Reply-To: nocturne@arepa.com
To: gnats-bugs@gnats.netbsd.org
Subject: pkgsrc: broken patch to wget
X-Send-Pr-Version: 3.95
>Number: 11028
>Category: pkg
>Synopsis: Patch to wget breaks -I flag
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Sep 16 06:36:00 +0000 2000
>Closed-Date: Sat Sep 16 08:35:31 +0000 2000
>Last-Modified: Sat Sep 16 08:35:31 +0000 2000
>Originator: Eric Mumpower
>Release: Stock 1.4.1 base install <NetBSD-current source date>
>Organization:
Arepa
>Environment:
System: NetBSD dr-teeth 1.4.1 NetBSD 1.4.1 (TEETH) #1: Fri Sep 15 18:27:55 EDT 2000 nocturne@dr-teeth:/usr/src/sys/arch/i386/compile/TEETH i386
>Description:
Someone wasn't paying adequately close attention when they wrote the IPv6
patch to wget, I guess. They broke the '-I' flag due to a mis-alphabetization.
Function init.c:comind() requires the commands[] structure to be strictly
alphabetized, which it isn't after the application of wget's patch-ae.
>How-To-Repeat:
Build and install wget from the -current pkgsrc release.
Run "wget -I foo http://www.mit.edu", note the error you get:
"get: BUG: unknown command `includedirectories', value `foo'."
>Fix:
Note that init.c EXPLICITLY documents itself to indicate that additions to
commands[] must be made *alphabetically*. wget/patches/patch-ae ignores this,
or else was written by someone with an inadequate knowledge of ASCII
alphabetization, as it files "inet" and "inet6" *before* "includedirectories".
The correct fix is to change patch-ae to something like this:
*** init.c.orig Thu Sep 10 20:20:23 1998
--- init.c Sat Sep 16 02:31:41 2000
***************
*** 114,119 ****
--- 114,121 ----
{ "httpuser", &opt.http_user, cmd_string },
{ "ignorelength", &opt.ignore_length, cmd_boolean },
{ "includedirectories", &opt.includes, cmd_directory_vector },
+ { "inet", &opt.inet, cmd_boolean },
+ { "inet6", &opt.inet6, cmd_boolean },
{ "input", &opt.input_filename, cmd_string },
{ "killlonger", &opt.kill_longer, cmd_boolean },
{ "logfile", &opt.lfilename, cmd_string },
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback
State-Changed-By: tron
State-Changed-When: Sat Sep 16 00:40:57 PDT 2000
State-Changed-Why:
There isn't a single patch file in the "wget" package in "pkgsrc" at the
moment. Could you please update your package source with a suited method
(e.g. SUP with "-d", anonymous CVS or "rm -rf pkgsrc before extracting
the latest tar ball) and try if the problem still exists?
State-Changed-From-To: feedback->closed
State-Changed-By: itojun
State-Changed-When: Sat Sep 16 01:34:34 PDT 2000
State-Changed-Why:
changed IPv6 patch revision (use the latest one). pkgsrc/net/wget/Makefile
revision 1.22 should be okay. if you still see problem, please let me know.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.