NetBSD Problem Report #1128

From gnats  Mon Jun 19 22:19:27 1995
Received: from pain.lcs.mit.edu (pain.lcs.mit.edu [128.52.46.239]) by sun-lamp.pc.cs.cmu.edu (8.6.11/8.6.10) with ESMTP id WAA18331 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Mon, 19 Jun 1995 22:19:25 -0400
Message-Id: <199506190431.VAA26805@toccata.fugue.com>
Date: Sun, 18 Jun 1995 21:31:27 -0700
From: Ted Lemon <mellon@fugue.com>
Reply-To: mellon@fugue.com
To: gnats-bugs@NetBSD.ORG
Subject: vfs_bufstats inconsistently conditionalized
X-Send-Pr-Version: 3.2

>Number:         1128
>Category:       kern
>Synopsis:       vfs_bufstats inconsistently conditionalized
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 19 22:20:04 +0000 1995
>Closed-Date:    Tue Jun 20 10:32:39 +0000 1995
>Last-Modified:  
>Originator:     Ted Lemon
>Release:        July 15, 1995
>Organization:
>Environment:
System: NetBSD toccata 1.0A NetBSD 1.0A (TOCCATA) #158: Wed Jun 14 12:49:57 PDT 1995 mellon@toccata:/sandbox/NetBSD-current/sys/arch/pmax/compile/TOCCATA pmax


>Description:
	vfs_bufstats is compiled conditionally on DIAGNOSTIC, but is called
	conditionally on DEBUG, so if only one is defined, the kernel fails
	to link.
>How-To-Repeat:
>Fix:
RCS file: /a/cvsroot/src/sys/kern/vfs_syscalls.c,v
retrieving revision 1.53
diff -c -r1.53 vfs_syscalls.c
*** vfs_syscalls.c	1995/06/01 22:44:13	1.53
--- vfs_syscalls.c	1995/06/19 04:28:30
***************
*** 436,445 ****
  			vfs_unbusy(mp);
  		}
  	}
! #ifdef DEBUG
  	if (syncprt)
  		vfs_bufstats();
! #endif /* DEBUG */
  	return (0);
  }

--- 436,445 ----
  			vfs_unbusy(mp);
  		}
  	}
! #ifdef DIAGNOSTIC
  	if (syncprt)
  		vfs_bufstats();
! #endif /* DIAGNOSTIC */
  	return (0);
  }

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: cgd 
State-Changed-When: Tue Jun 20 06:32:39 EDT 1995 
State-Changed-Why:  
can't fix in this way (too many dependencies).  instead, change vfs_bufstats 
conditional. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.