NetBSD Problem Report #11462

Received: (qmail 13031 invoked from network); 9 Nov 2000 23:30:21 -0000
Message-Id: <Pine.LNX.4.21.0011091529480.16858-100000@pilchuck.reedmedia.net>
Date: Thu, 9 Nov 2000 15:30:18 -0800 (PST)
From: "Jeremy C. Reed" <reed@reedmedia.net>
To: gnats-bugs@gnats.netbsd.org
Subject: A sentence in any package's README.html is missing a period

>Number:         11462
>Category:       pkg
>Synopsis:       formatting for current source version is removed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 09 23:31:00 +0000 2000
>Closed-Date:    Thu Nov 09 23:47:34 +0000 2000
>Last-Modified:  Thu Nov 09 23:47:34 +0000 2000
>Originator:     Jeremy C. Reed
>Release:        
>Organization:

>Environment:

System: NetBSD rainier 1.5_BETA NetBSD 1.5_BETA (GENERIC) #1: Sat Oct 21 13:59:18 MEST 2000 fvdl@sushi:/work/trees/netbsd-1-5/sys/arch/i386/compile/GENERIC i386


>Description:
A README.html page (using links as an example) has:

   The package is located in the "www/links" directory. The current source
   version of the package is links-0.92 For a summary on how to use the
   package collection, go to the top of the packages tree.

Notice how there is no "quotes" around the "links-0.92" and no period
at the end of that sentence.

There should be quotes (as defined in the README.pkg template). Also the
template is missing the period. Adding the period doesn't work, because
the make routine for README.html use a sed routine that that "reads" a file
which inserts to the next line.

>How-To-Repeat:

>Fix:

As far as I can tell, I see know purpose for putting the source package
name in a file and then reading it. 
Here is my diff: 

2843d2842
<       @${ECHO} '${PKGNAME:S/&/\&amp;/g:S/>/\&gt;/g:S/</\&lt;/g}' >> $@.tmp3
2851,2852c2850
<               -e '/%%PKG%%/r $@.tmp3'                                 \
<               -e '/%%PKG%%/d'                                         \
---
>               -e 's|%%PKG%%|${PKGNAME:S/&/\&amp;/g:S/>/\&gt;/g:S/</\&lt;/g}|g'\
2871c2869
<       @${RM} -f $@.tmp $@.tmp1 $@.tmp2 $@.tmp3 $@.tmp4 $@.tmp5 $@.tmp6
---
>       @${RM} -f $@.tmp $@.tmp1 $@.tmp2 $@.tmp4 $@.tmp5 $@.tmp6

On a side note, maybe the html checking/substitution isn't needed.
Do package names ever have ">", "<" or ampersands in them?

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: hubertf 
State-Changed-When: Thu Nov 9 15:46:42 PST 2000 
State-Changed-Why:  
I've applied your patch, thanks. 


- Hubert 

P.S.: Please submit a unified diff (cvs diff -u) for better readability 
in the future - thanks! 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.