NetBSD Problem Report #1182

From gnats  Sat Jul  1 16:12:23 1995
Received: from khym.imf.unit.no (khym.imf.unit.no [129.241.15.200]) by sun-lamp.pc.cs.cmu.edu (8.6.11/8.6.10) with SMTP id QAA18950 for <gnats-bugs@gnats.netbsd.org>; Sat, 1 Jul 1995 16:12:21 -0400
Message-Id: <199507012012.WAA25210@rtfm.imf.unit.no>
Date: Sat, 1 Jul 1995 22:12:06 +0200
From: Arne Henrik Juul <arnej@imf.unit.no>
Reply-To: arnej@imf.unit.no
To: gnats-bugs@gnats.netbsd.org
Subject: rpc programs use illegal constructs
X-Send-Pr-Version: 3.2

>Number:         1182
>Category:       bin
>Synopsis:       rpc programs use illegal constructs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jul 01 16:20:01 +0000 1995
>Closed-Date:    Sun Jul 09 00:22:46 +0000 1995
>Last-Modified:  
>Originator:     Arne H. Juul
>Release:        NetBSD-current, Jul  1 1995
>Organization:
	University of Trondheim, Norway
>Environment:

System: NetBSD rtfm.imf.unit.no 1.0A NetBSD 1.0A (RTFM) #1: Sun Jun 11 18:53:58 MET DST 1995 root@rtfm.imf.unit.no:/usr/src/sys/arch/i386/compile/RTFM i386


>Description:
	The recent 'ansification' of various rpc programs went a
bit too far, by declaring pointers to function with only (...)
parameters. This isn't legal, as gcc 2.7.0 shows:

 : ===> rpc.rstatd
 : /store/bin/gcc -O   -c /usr/src/libexec/rpc.rstatd/rstat_proc.c
 : /usr/src/libexec/rpc.rstatd/rstat_proc.c: In function `rstat_service':
 : /usr/src/libexec/rpc.rstatd/rstat_proc.c:387: ANSI C requires a named argument before `...'
 : /usr/src/libexec/rpc.rstatd/rstat_proc.c:387: ANSI C requires a named argument before `...'
 : *** Error code 1 (continuing)
 : `all' not remade because of errors.
 : ===> rpc.rusersd
 : /store/bin/gcc -O   -c /usr/src/libexec/rpc.rusersd/rusers_proc.c
 : /usr/src/libexec/rpc.rusersd/rusers_proc.c:160: warning: #warning i386 console hack here
 : /usr/src/libexec/rpc.rusersd/rusers_proc.c: In function `rusers_service':
 : /usr/src/libexec/rpc.rusersd/rusers_proc.c:346: ANSI C requires a named argument before `...'
 : /usr/src/libexec/rpc.rusersd/rusers_proc.c:346: ANSI C requires a named argument before `...'
 : *** Error code 1 (continuing)
 : `all' not remade because of errors.
 : ===> rpc.rwalld
 : /store/bin/gcc -O   -c /usr/src/libexec/rpc.rwalld/rwalld.c
 : /usr/src/libexec/rpc.rwalld/rwalld.c: In function `wallprog_1':
 : /usr/src/libexec/rpc.rwalld/rwalld.c:145: ANSI C requires a named argument before `...'
 : /usr/src/libexec/rpc.rwalld/rwalld.c:145: ANSI C requires a named argument before `...'
 : *** Error code 1 (continuing)
 : `all' not remade because of errors.

>How-To-Repeat:
	Install gcc 2.7.0 or another picky ansi compiler. Recompile.
>Fix:
	Apply this patch:

diff -ru /usr/src/libexec/rpc.rstatd/rstat_proc.c.pre /usr/src/libexec/rpc.rstatd/rstat_proc.c
--- /usr/src/libexec/rpc.rstatd/rstat_proc.c.pre	Sat Jul  1 19:49:18 1995
+++ /usr/src/libexec/rpc.rstatd/rstat_proc.c	Sat Jul  1 19:50:00 1995
@@ -384,7 +384,7 @@
 		int fill;
 	} argument;
 	char *result;
-	bool_t (*xdr_argument) __P((...)), (*xdr_result) __P((...));
+	bool_t (*xdr_argument) (), (*xdr_result) ();
 	char *(*local) __P((void *, struct svc_req *));

 	switch (rqstp->rq_proc) {
diff -ru /usr/src/libexec/rpc.rusersd/rusers_proc.c.pre /usr/src/libexec/rpc.rusersd/rusers_proc.c
--- /usr/src/libexec/rpc.rusersd/rusers_proc.c.pre	Sat Jul  1 19:49:23 1995
+++ /usr/src/libexec/rpc.rusersd/rusers_proc.c	Sat Jul  1 19:50:21 1995
@@ -343,7 +343,7 @@
 		int fill;
 	} argument;
 	char *result;
-	bool_t (*xdr_argument) __P((...)), (*xdr_result) __P((...));
+	bool_t (*xdr_argument) (), (*xdr_result) ();
 	char *(*local) __P((void *, struct svc_req *));

 	switch (rqstp->rq_proc) {
diff -ru /usr/src/libexec/rpc.rwalld/rwalld.c.pre /usr/src/libexec/rpc.rwalld/rwalld.c
--- /usr/src/libexec/rpc.rwalld/rwalld.c.pre	Sat Jul  1 19:49:28 1995
+++ /usr/src/libexec/rpc.rwalld/rwalld.c	Sat Jul  1 19:50:30 1995
@@ -142,7 +142,7 @@
 		char *wallproc_wall_1_arg;
 	} argument;
 	char *result;
-	bool_t (*xdr_argument) __P((...)), (*xdr_result) __P((...));
+	bool_t (*xdr_argument) (), (*xdr_result) ();
 	char *(*local) __P((char **, struct svc_req *));

 	switch (rqstp->rq_proc) {
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: pk 
State-Changed-When: Sat Jul 8 20:22:46 EDT 1995 
State-Changed-Why:  
Declare xdr_{args,result} differently. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.