NetBSD Problem Report #11910

Received: (qmail 18576 invoked from network); 7 Jan 2001 21:17:47 -0000
Message-Id: <200101072108.f07L8YE00406@neko.yamanet>
Date: Mon, 8 Jan 2001 06:08:34 +0900 (JST)
From: takashi.yamamoto@bigfoot.com
Reply-To: takashi.yamamoto@bigfoot.com
To: gnats-bugs@gnats.netbsd.org
Subject: ess1688 patch
X-Send-Pr-Version: 3.95

>Number:         11910
>Category:       kern
>Synopsis:       ess1688 patch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mycroft
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 07 21:18:00 +0000 2001
>Closed-Date:    Tue Aug 17 00:43:55 +0000 2004
>Last-Modified:  Tue Aug 17 00:43:55 +0000 2004
>Originator:     
>Release:        1.5Q
>Organization:

>Environment:

System: NetBSD neko 1.5Q NetBSD 1.5Q (560) #10: Mon Jan 8 05:48:06 JST 2001 takashi@neko:/usr/home/takashi/netbsd/current/src/sys/arch/i386/compile/560 i386
Architecture: i386
Machine: i386
>Description:
	this patch just makes ess driver handle ess1688.
	I'm not sure because I don't have data sheets,
	but it seems to work on my Thinkpad 560E which has ess1688.
>How-To-Repeat:

>Fix:

--- /sys/dev/isa/bak/ess.c	Fri Dec 29 14:56:35 2000
+++ /sys/dev/isa/ess.c	Mon Jan  8 05:47:52 2001
@@ -193,6 +193,7 @@
 	"1879",
 	"1868",
 	"1878",
+	"1688",
 };

 struct audio_device ess_device = {
@@ -660,6 +661,14 @@
 	ess_write_mix_reg(sc, ESS_MREG_VOLUME_CTRL, reg2);

 	if (ess_read_mix_reg(sc, ESS_MREG_VOLUME_CTRL) != reg2) {
+	/*
+	 * it has no h/w volume, so maybe ESS1688.
+	 */
+		if (sc->sc_version == 0x688b) {
+			sc->sc_model = ESS_1688;
+			return 0;
+		}
+
 		printf("ess: Hardware error (unable to toggle bit 2 of mixer register 0x64)\n");
 		return 1;
 	}
--- /sys/dev/isa/bak/essreg.h	Tue Jun 29 09:04:49 1999
+++ /sys/dev/isa/essreg.h	Sun Jan  7 00:34:31 2001
@@ -175,7 +175,7 @@

 #define ESS_DRQ2_VALID(chan) ((chan) == 0 || (chan) == 1 || (chan) == 3 || (chan) == 5)

-#define ESS_USE_AUDIO1(model) (((model) == ESS_1788) || ((model) == ESS_1868) || ((model) == ESS_1878) || ((model) == ESS_1869) || ((model) == ESS_1879))
+#define ESS_USE_AUDIO1(model) (((model) == ESS_1688) || ((model) == ESS_1788) || ((model) == ESS_1868) || ((model) == ESS_1878) || ((model) == ESS_1869) || ((model) == ESS_1879))

 /*
  * Macros to manipulate gain values
--- /sys/dev/isa/bak/essvar.h	Thu Mar 23 21:33:33 2000
+++ /sys/dev/isa/essvar.h	Sun Jan  7 00:29:08 2001
@@ -159,6 +159,7 @@
 #define ESS_1879	6
 #define ESS_1868	7
 #define ESS_1878	8
+#define ESS_1688	9

 	u_int	sc_version;		/* Legacy ES688/ES1688 ID */
 };
>Release-Note:
>Audit-Trail:

From: nathanw@MIT.EDU (Nathan J. Williams)
To: takashi.yamamoto@bigfoot.com
Cc: gnats-bugs@gnats.netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: kern/11910: ess1688 patch
Date: 07 Jan 2001 17:26:15 -0500

 <takashi.yamamoto@bigfoot.com> (takashi.yamamoto@bigfoot.com) writes:
 > @@ -660,6 +661,14 @@
 >  	ess_write_mix_reg(sc, ESS_MREG_VOLUME_CTRL, reg2);
 >  	
 >  	if (ess_read_mix_reg(sc, ESS_MREG_VOLUME_CTRL) != reg2) {
 > +	/*
 > +	 * it has no h/w volume, so maybe ESS1688.
 > +	 */
 > +		if (sc->sc_version == 0x688b) {
 > +			sc->sc_model = ESS_1688;
 > +			return 0;
 > +		}
 > +
 >  		printf("ess: Hardware error (unable to toggle bit 2 of mixer register 0x64)\n");
 >  		return 1;
 >  	}

 This part of the patch is not correct. ESS chips after the 1688 all
 report 0x688b as their version, for backwards compatibility with 1688
 drivers. This includes the 1788 and the 1887, and probably the 1868
 and 1869.

 You will need to find another way to distinguish the 1688 from later
 chips. 

         - Nathan


From: takashi@bigfoot.com
To: gnats-bugs@gnats.netbsd.org, Nathan J. Williams <nathanw@MIT.EDU>
Cc:  
Subject: Re: kern/11910: ess1688 patch
Date: Sat, 13 Jan 2001 04:20:19 +0900

 > This part of the patch is not correct. ESS chips after the 1688 all
 > report 0x688b as their version, for backwards compatibility with 1688   
 > drivers. This includes the 1788 and the 1887, and probably the 1868
 > and 1869.

 on chips like 1788, this part is not executed.
 (until 'hardware error' occured)
 So, it isn't serious problem, I think.


 btw, this pr is not found at query pr page on netbsd web site.
 and I didn't get Nathan's message by email.
 I read it on netbsd-bugs mailing list archive on web.
 it's normal behaivior?
 (I'm not sure about gnats...)

 YAMAMOTO Takashi<takashi.yamamoto@bigfoot.com>
State-Changed-From-To: open->feedback 
State-Changed-By: mycroft 
State-Changed-When: Fri Aug 6 15:12:39 UTC 2004 
State-Changed-Why:  
Changes added in -current.  If possible, please confirm that it works. 


Responsible-Changed-From-To: kern-bug-people->mycroft 
Responsible-Changed-By: mycroft 
Responsible-Changed-When: Fri Aug 6 15:12:39 UTC 2004 
Responsible-Changed-Why:  
. 

From: "Charles M. Hannum" <mycroft@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:  
Subject: pr/11910 CVS commit: src/sys/dev/isa
Date: Fri,  6 Aug 2004 15:11:48 +0000 (UTC)

 Module Name:	src
 Committed By:	mycroft
 Date:		Fri Aug  6 15:11:48 UTC 2004

 Modified Files:
 	src/sys/dev/isa: ess.c essreg.h essvar.h

 Log Message:
 Add code to recognize the 1688, per PR 11910.  Also reduce some control logic.


 To generate a diff of this commit:
 cvs rdiff -r1.61 -r1.62 src/sys/dev/isa/ess.c
 cvs rdiff -r1.13 -r1.14 src/sys/dev/isa/essreg.h
 cvs rdiff -r1.19 -r1.20 src/sys/dev/isa/essvar.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
To: gnats-bugs@gnats.netbsd.org
Cc: mycroft@netbsd.org, kern-bug-people@netbsd.org
Subject: Re: kern/11910
Date: Sat, 07 Aug 2004 02:03:06 +0900

 > Synopsis: ess1688 patch

 > Changes added in -current.  If possible, please confirm that it works.

 unfortunately, i don't have a machine with the chip anymore.

 YAMAMOTO Takashi
State-Changed-From-To: feedback->suspended 
State-Changed-By: mycroft 
State-Changed-When: Fri Aug 6 21:22:26 UTC 2004 
State-Changed-Why:  
Added in -current, but user is unable to test. 
State-Changed-From-To: suspended->closed 
State-Changed-By: mycroft 
State-Changed-When: Tue Aug 17 00:43:15 UTC 2004 
State-Changed-Why:  
Code was added, so presumed fixed.  No way to test. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.