NetBSD Problem Report #1199

From gnats  Thu Jul  6 01:42:23 1995
Received: from mail.telstra.com.au (mail.telstra.com.au [192.148.160.10]) by sun-lamp.pc.cs.cmu.edu (8.6.11/8.6.10) with ESMTP id BAA17288 for <gnats-bugs@gnats.netbsd.org>; Thu, 6 Jul 1995 01:42:21 -0400
Message-Id: <199507060631.QAA04406@hobbit.dn.itg.telecom.com.au.>
Date: Thu, 6 Jul 1995 16:31:11 +1000
From: "Simon J. Gerraty" <sjg@hobbit.dn.itg.telecom.com.au>
Reply-To: sjg@hobbit.dn.itg.telecom.com.au
To: gnats-bugs@gnats.netbsd.org
Subject: kernel build dies if () in CFLAGS
X-Send-Pr-Version: 3.2

>Number:         1199
>Category:       kern
>Synopsis:       compile of lib{kern,compat} breaks if CFLAGS contains ().
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 06 01:50:03 +0000 1995
>Closed-Date:    Mon May 20 17:23:38 +0000 1996
>Last-Modified:  Mon May 20 17:24:24 +0000 1996
>Originator:     Simon J. Gerraty
>Release:        NetBSD-950627
>Organization:

>Environment:

System: NetBSD hobbit 1.0A NetBSD 1.0A (HOBBIT) #0: Thu Jul 6 15:59:00 EST 1995 root@hobbit:/usr/bsd_src/usr.src/sys/arch/sparc/compile/HOBBIT sparc


>Description:

The assignments *FLAGS="${CFLAGS}" results in a syntax error if CFLAGS contains
() inside quotes.
I broke it by having -DCHILD_MAX="(maxproc / 2)" in CFLAGS but other
cases could easily be contrived.
The above results in:

root:380# make 
making sure the kern library is up to date...
Syntax error: "(" unexpected (expecting ")")
*** Error code 2


>How-To-Repeat:

See above.

>Fix:

Given that several things in kernel config files put "" around options etc,
using 
*FLAGS='${CFLAGS}' seems prudent.
The following patch takes care of sys/lib/libkern and sys/compat/common


Index: sys/lib/libkern/Makefile.inc
===================================================================
RCS file: /prod/cvsroot/usr.src/sys/lib/libkern/Makefile.inc,v
retrieving revision 1.1.1.2
diff -c -b -r1.1.1.2 Makefile.inc
*** /tmp/T0a20702	Thu Jul  6 15:16:26 1995
--- Makefile.inc	Thu Jul  6 15:02:31 1995
***************
*** 13,19 ****
  	@echo making sure the kern library is up to date...
  	@(cd ${KERNDST} && ${MAKE} -f ${KERNREL}${KERNDIR}/Makefile \
  	  KERNCC="${CC}" \
! 	  KERNCFLAGS="${CFLAGS}" \
  	  KERNREL="${KERNREL}" \
  	  KERNDIR="${KERNDIR}" libkern.a)

--- 13,19 ----
  	@echo making sure the kern library is up to date...
  	@(cd ${KERNDST} && ${MAKE} -f ${KERNREL}${KERNDIR}/Makefile \
  	  KERNCC="${CC}" \
! 	  KERNCFLAGS='${CFLAGS}' \
  	  KERNREL="${KERNREL}" \
  	  KERNDIR="${KERNDIR}" libkern.a)

***************
*** 21,27 ****
  	@echo making sure the profiled kern library is up to date...
  	@(cd ${KERNDST} && ${MAKE} -f ${KERNREL}${KERNDIR}/Makefile \
  	  KERNCC="${CC}" \
! 	  KERNCFLAGS="${CFLAGS}" \
  	  KERNREL="${KERNREL}" \
  	  KERNDIR="${KERNDIR}" libkern_p.a)

--- 21,27 ----
  	@echo making sure the profiled kern library is up to date...
  	@(cd ${KERNDST} && ${MAKE} -f ${KERNREL}${KERNDIR}/Makefile \
  	  KERNCC="${CC}" \
! 	  KERNCFLAGS='${CFLAGS}' \
  	  KERNREL="${KERNREL}" \
  	  KERNDIR="${KERNDIR}" libkern_p.a)

***************
*** 29,35 ****
  	@echo cleaning the kern library objects
  	@(cd ${KERNDST} && ${MAKE} -f ${KERNREL}${KERNDIR}/Makefile \
  	  KERNCC="${CC}" \
! 	  KERNCFLAGS="${CFLAGS}" \
  	  KERNREL="${KERNREL}" \
  	  KERNDIR="${KERNDIR}" clean)

--- 29,35 ----
  	@echo cleaning the kern library objects
  	@(cd ${KERNDST} && ${MAKE} -f ${KERNREL}${KERNDIR}/Makefile \
  	  KERNCC="${CC}" \
! 	  KERNCFLAGS='${CFLAGS}' \
  	  KERNREL="${KERNREL}" \
  	  KERNDIR="${KERNDIR}" clean)

Index: sys/compat/common/Makefile.inc
===================================================================
RCS file: /prod/cvsroot/usr.src/sys/compat/common/Makefile.inc,v
retrieving revision 1.1.1.1
diff -c -b -r1.1.1.1 Makefile.inc
*** /tmp/T0a20706	Thu Jul  6 15:16:26 1995
--- Makefile.inc	Thu Jul  6 15:09:26 1995
***************
*** 13,19 ****
  	@echo making sure the compat library is up to date...
  	@(cd ${COMPATDST} && ${MAKE} -f ${COMPATREL}${COMPATDIR}/Makefile \
  	  COMPATCC="${CC}" \
! 	  COMPATCFLAGS="${CFLAGS}" \
  	  COMPATREL="${COMPATREL}" \
  	  COMPATDIR="${COMPATDIR}" libcompat.a)

--- 13,19 ----
  	@echo making sure the compat library is up to date...
  	@(cd ${COMPATDST} && ${MAKE} -f ${COMPATREL}${COMPATDIR}/Makefile \
  	  COMPATCC="${CC}" \
! 	  COMPATCFLAGS='${CFLAGS}' \
  	  COMPATREL="${COMPATREL}" \
  	  COMPATDIR="${COMPATDIR}" libcompat.a)

***************
*** 21,27 ****
  	@echo making sure the profiled compat library is up to date...
  	@(cd ${COMPATDST} && ${MAKE} -f ${COMPATREL}${COMPATDIR}/Makefile \
  	  COMPATCC="${CC}" \
! 	  COMPATCFLAGS="${CFLAGS}" \
  	  COMPATREL="${COMPATREL}" \
  	  COMPATDIR="${COMPATDIR}" libcompat_p.a)

--- 21,27 ----
  	@echo making sure the profiled compat library is up to date...
  	@(cd ${COMPATDST} && ${MAKE} -f ${COMPATREL}${COMPATDIR}/Makefile \
  	  COMPATCC="${CC}" \
! 	  COMPATCFLAGS='${CFLAGS}' \
  	  COMPATREL="${COMPATREL}" \
  	  COMPATDIR="${COMPATDIR}" libcompat_p.a)

***************
*** 29,35 ****
  	@echo cleaning the compat library objects
  	@(cd ${COMPATDST} && ${MAKE} -f ${COMPATREL}${COMPATDIR}/Makefile \
  	  COMPATCC="${CC}" \
! 	  COMPATCFLAGS="${CFLAGS}" \
  	  COMPATREL="${COMPATREL}" \
  	  COMPATDIR="${COMPATDIR}" clean)

--- 29,35 ----
  	@echo cleaning the compat library objects
  	@(cd ${COMPATDST} && ${MAKE} -f ${COMPATREL}${COMPATDIR}/Makefile \
  	  COMPATCC="${CC}" \
! 	  COMPATCFLAGS='${CFLAGS}' \
  	  COMPATREL="${COMPATREL}" \
  	  COMPATDIR="${COMPATDIR}" clean)

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: mrg 
State-Changed-When: Mon May 20 13:23:38 EDT 1996 
State-Changed-Why:  
we now use ' not ". 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.