NetBSD Problem Report #12222

Received: (qmail 10549 invoked from network); 16 Feb 2001 09:11:53 -0000
Message-Id: <200102161107.f1GB7jX23474@ws216.nomadiclab.com>
Date: Fri, 16 Feb 2001 13:07:45 +0200 (EET)
From: martti.kuparinen@iki.fi
Reply-To: martti.kuparinen@iki.fi
To: gnats-bugs@gnats.netbsd.org
Subject: Update for pine and pico
X-Send-Pr-Version: 3.95

>Number:         12222
>Category:       pkg
>Synopsis:       Update for pine and pico
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    abs
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 16 09:12:00 +0000 2001
>Closed-Date:    Fri Feb 16 10:15:42 +0000 2001
>Last-Modified:  Mon Feb 19 18:37:00 +0000 2001
>Originator:     Martti Kuparinen
>Release:        /usr/pkgsrc from today
>Organization:
piuha.net
>Environment:

System: NetBSD ws216 1.5 NetBSD 1.5 (WS20) #2: Tue Feb 13 09:40:43 EET 2001 root@ws216:/usr/src/sys/arch/i386/compile/WS20 i386


>Description:

I have updated the pine and pico packages. If you have difficulties
with the following patches, just get the whole collection from

	http://www.piuha.net/~martti/tmp/

>How-To-Repeat:

>Fix:

Index: editors/pico/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/editors/pico/Makefile,v
retrieving revision 1.21
diff -u -r1.21 Makefile
--- Makefile	2000/11/09 03:34:13	1.21
+++ Makefile	2001/02/16 08:49:18
@@ -1,7 +1,7 @@
 # $NetBSD: Makefile,v 1.21 2000/11/09 03:34:13 hubertf Exp $
 #

-DISTNAME=	pine4.30
+DISTNAME=	pine4.33
 PKGNAME=	pico-3.8
 CATEGORIES=	editors
 MASTER_SITES=	ftp://ftp.cac.washington.edu/pine/
Index: editors/pico/files/md5
===================================================================
RCS file: /cvsroot/pkgsrc/editors/pico/files/md5,v
retrieving revision 1.12
diff -u -r1.12 md5
--- files/md5	2000/11/09 03:34:14	1.12
+++ files/md5	2001/02/16 08:49:18
@@ -1,3 +1,3 @@
-$NetBSD: md5,v 1.12 2000/11/09 03:34:14 hubertf Exp $
+$NetBSD$

-MD5 (pine4.30.tar.gz) = 21e16ae355a3c78cbe128876e3e65350
+MD5 (pine4.33.tar.gz) = fb45dcfa1d3379031700da49236b2b9c




Index: mail/pine/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/mail/pine/Makefile,v
retrieving revision 1.40
diff -u -r1.40 Makefile
--- Makefile	2000/12/18 18:09:11	1.40
+++ Makefile	2001/02/16 08:49:18
@@ -2,8 +2,8 @@
 # FreeBSD Id: Makefile,v 1.21 1997/03/26 02:12:07 ache Exp
 #

-DISTNAME=       pine4.30
-PKGNAME=        pine-4.30
+DISTNAME=       pine4.33
+PKGNAME=        pine-4.33
 CATEGORIES=     mail news
 MASTER_SITES=	ftp://ftp.cac.washington.edu/pine/ \
 		ftp://ftp.fu-berlin.de/unix/mail/pine/
Index: mail/pine/files/md5
===================================================================
RCS file: /cvsroot/pkgsrc/mail/pine/files/md5,v
retrieving revision 1.11
diff -u -r1.11 md5
--- files/md5	2000/11/09 03:37:26	1.11
+++ files/md5	2001/02/16 08:49:18
@@ -1,3 +1,3 @@
-$NetBSD: md5,v 1.11 2000/11/09 03:37:26 hubertf Exp $
+$NetBSD$

-MD5 (pine4.30.tar.gz) = 21e16ae355a3c78cbe128876e3e65350
+MD5 (pine4.33.tar.gz) = fb45dcfa1d3379031700da49236b2b9c
Index: mail/pine/files/patch-sum
===================================================================
RCS file: /cvsroot/pkgsrc/mail/pine/files/patch-sum,v
retrieving revision 1.7
diff -u -r1.7 patch-sum
--- files/patch-sum	2000/12/18 18:09:11	1.7
+++ files/patch-sum	2001/02/16 08:49:18
@@ -1,6 +1,6 @@
 $NetBSD: patch-sum,v 1.7 2000/12/18 18:09:11 jwise Exp $

 MD5 (patch-aa) = f9bc943f36dfc5f2c3583bcbe7a1aba6
-MD5 (patch-ac) = 5b10cccaeecdc6163e452a0bc691b247
-MD5 (patch-al) = e079f418def13fb0386bd6faecf113b4
+MD5 (patch-ac) = 9f88664a90e9a9a989b6e6aadf939402
+MD5 (patch-al) = ec4b240b1113eeb0e979e4ff1f3f1209
 MD5 (patch-ao) = bf069e8f6c0e571c26a3f52fe2781b6b
Index: mail/pine/patches/patch-ac
===================================================================
RCS file: /cvsroot/pkgsrc/mail/pine/patches/patch-ac,v
retrieving revision 1.10
diff -u -r1.10 patch-ac
--- patches/patch-ac	2000/12/18 18:09:11	1.10
+++ patches/patch-ac	2001/02/16 08:49:18
@@ -1,7 +1,5 @@
-$NetBSD: patch-ac,v 1.10 2000/12/18 18:09:11 jwise Exp $
-
---- pine/makefile.neb.orig	Thu Aug 27 18:50:02 1998
-+++ pine/makefile.neb
+--- pine/makefile.neb.orig	Fri Nov 10 02:57:03 2000
++++ pine/makefile.neb	Fri Feb 16 10:04:20 2001
 @@ -45,11 +45,16 @@
  RM=          rm -f
  LN=          ln -s
@@ -24,7 +22,7 @@
  # Only need to uncomment next two lines if you run make from this directory
 @@ -60,14 +65,13 @@
  LDAPOFILES=   addrbook.o adrbkcmd.o args.o bldaddr.o init.o \
- 	      other.o pine.o takeaddr.o
+ 	      mailview.o other.o pine.o strings.o takeaddr.o

 -STDLIBS=     -ltermlib
 -LOCLIBS=     $(PICODIR)/libpico.a $(CCLIENTDIR)/c-client.a
@@ -69,6 +67,6 @@
 -send.o:							$(CCLIENTDIR)/smtp.h
 +context.o:						$(CCLIENTINC)/misc.h
 +send.o:							$(CCLIENTINC)/smtp.h
- $(LDAPOFILES):						$(LDAPLIBS)
+ #$(LDAPOFILES):						$(LDAPLIBS)

  helptext.c:	pine.hlp
Index: mail/pine/patches/patch-al
===================================================================
RCS file: /cvsroot/pkgsrc/mail/pine/patches/patch-al,v
retrieving revision 1.7
diff -u -r1.7 patch-al
--- patches/patch-al	2000/11/09 03:37:27	1.7
+++ patches/patch-al	2001/02/16 08:49:18
@@ -1,17 +1,15 @@
-$NetBSD: patch-al,v 1.7 2000/11/09 03:37:27 hubertf Exp $
-
---- build.orig	Tue Aug  1 00:28:01 2000
-+++ build
-@@ -198,7 +198,7 @@
-      mnt) makeargs="CC=gcc $makeargs" ;;
+--- build.orig	Thu Jan  4 20:13:11 2001
++++ build	Fri Feb 16 10:33:44 2001
+@@ -201,7 +201,7 @@
       bs3) makeargs="CC=shlicc $makeargs" ;;
+      nto) makeargs="CC=qcc $makeargs" ;;
       lyn) [ -f /CYGNUS.bash ] && . /CYGNUS.bash; makeargs="CC=gcc $makeargs" ;;
 -       *) makeargs="CC=cc $makeargs" ;;
 +       *) makeargs="CC=${LT}\ cc\ -g $makeargs" ;;
    esac
  fi

-@@ -303,23 +303,28 @@
+@@ -309,23 +309,28 @@
  	  echo "Including SSL functionality"
  	fi

@@ -57,7 +55,7 @@

          echo "Making Pine".
          cd $PHOME/pine
-@@ -336,8 +341,6 @@
+@@ -342,8 +347,6 @@
          if [ -s ../pico/pilot ] ;     then ln ../pico/pilot pilot ; fi
          cd $PHOME
          echo ''
@@ -66,7 +64,7 @@
  	case $maketarg in
  	    mnt)    echo "Fixing stacksizes ..."
  		    fixstk 64K bin/pine bin/pico bin/imapd bin/mtest bin/pilot
-@@ -347,9 +350,9 @@
+@@ -353,9 +356,9 @@


      clean) # This only sort of works 
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: abs 
State-Changed-When: Fri Feb 16 02:15:21 PST 2001 
State-Changed-Why:  
Patch applied - package updated. 

Many thanks 


Responsible-Changed-From-To: pkg-manager->abs 
Responsible-Changed-By: abs 
Responsible-Changed-When: Fri Feb 16 02:15:21 PST 2001 
Responsible-Changed-Why:  

From: Todd Vierling <tv@wasabisystems.com>
To: <gnats-bugs@gnats.netbsd.org>
Cc: <netbsd-bugs@netbsd.org>
Subject: Re: pkg/12222: Update for pine and pico
Date: Fri, 16 Feb 2001 10:40:24 -0500 (Eastern Standard Time)

 On Fri, 16 Feb 2001 martti.kuparinen@iki.fi wrote:

 : I have updated the pine and pico packages. If you have difficulties
 : with the following patches, just get the whole collection from

 To whomever updates this pkg:  Please do not forget to bump the major number
 of libpico (which is not in this update)!

 -- 
 -- Todd Vierling <tv@wasabisystems.com>  *  Wasabi NetBSD:  Run with it.
 -- NetBSD 1.5 now available on CD-ROM  --  http://www.wasabisystems.com/


From: David Brownlee <abs@netbsd.org>
To: Todd Vierling <tv@wasabisystems.com>
Cc: <gnats-bugs@gnats.netbsd.org>, <netbsd-bugs@netbsd.org>
Subject: Re: pkg/12222: Update for pine and pico
Date: Fri, 16 Feb 2001 15:47:27 +0000 (GMT)

 	Given the package is a bugfix release would it be more appropriate
 	to bump the minor?

 		David/absolute		-- www.netbsd.org: No hype required --


 On Fri, 16 Feb 2001, Todd Vierling wrote:

 > On Fri, 16 Feb 2001 martti.kuparinen@iki.fi wrote:
 >
 > : I have updated the pine and pico packages. If you have difficulties
 > : with the following patches, just get the whole collection from
 >
 > To whomever updates this pkg:  Please do not forget to bump the major number
 > of libpico (which is not in this update)!
 >
 >


From: Todd Vierling <tv@wasabisystems.com>
To: David Brownlee <abs@netbsd.org>
Cc: <gnats-bugs@gnats.netbsd.org>, <netbsd-bugs@netbsd.org>
Subject: Re: pkg/12222: Update for pine and pico
Date: Fri, 16 Feb 2001 12:13:18 -0500 (Eastern Standard Time)

 On Fri, 16 Feb 2001, David Brownlee wrote:

 : 	Given the package is a bugfix release would it be more appropriate
 : 	to bump the minor?

 Only if you can verify that the ABI hasn't changed.  I assume the worst.

 -- 
 -- Todd Vierling <tv@wasabisystems.com>  *  Wasabi NetBSD:  Run with it.
 -- NetBSD 1.5 now available on CD-ROM  --  http://www.wasabisystems.com/


From: Frederick Bruckman <fb@enteract.com>
To: Todd Vierling <tv@wasabisystems.com>
Cc: David Brownlee <abs@netbsd.org>, <gnats-bugs@gnats.netbsd.org>,
   <netbsd-bugs@netbsd.org>
Subject: Re: pkg/12222: Update for pine and pico
Date: Sat, 17 Feb 2001 10:12:04 -0600 (CST)

 On Fri, 16 Feb 2001, Todd Vierling wrote:

 > On Fri, 16 Feb 2001, David Brownlee wrote:
 >
 > : 	Given the package is a bugfix release would it be more appropriate
 > : 	to bump the minor?
 >
 > Only if you can verify that the ABI hasn't changed.  I assume the worst.

 Why assume the worst? None of the release notes even mentions pico.
 It's possible that libpico hasn't changed at all, in which case
 bumping the version would only lead to a gratuitious difference
 between the NetBSD package and the maintained sources.


 Frederick


From: Todd Vierling <tv@wasabisystems.com>
To: Frederick Bruckman <fb@enteract.com>
Cc: David Brownlee <abs@netbsd.org>, <gnats-bugs@gnats.netbsd.org>,
   <netbsd-bugs@netbsd.org>
Subject: Re: pkg/12222: Update for pine and pico
Date: Sat, 17 Feb 2001 11:24:16 -0500 (Eastern Standard Time)

 On Sat, 17 Feb 2001, Frederick Bruckman wrote:

 : > : 	Given the package is a bugfix release would it be more appropriate
 : > : 	to bump the minor?
 : >
 : > Only if you can verify that the ABI hasn't changed.  I assume the worst.
 :
 : Why assume the worst?

 Why assume the best?  Keeping the same major number, if the ABI changes,
 can cause spectacular (and difficult to diagnose) breakage.

 : None of the release notes even mentions pico.
 : It's possible that libpico hasn't changed at all,

 Then verify that.

 -- 
 -- Todd Vierling <tv@wasabisystems.com>  *  Wasabi NetBSD:  Run with it.
 -- NetBSD 1.5 now available on CD-ROM  --  http://www.wasabisystems.com/


From: David Brownlee <abs@netbsd.org>
To: Todd Vierling <tv@wasabisystems.com>
Cc: Frederick Bruckman <fb@enteract.com>, <gnats-bugs@gnats.netbsd.org>,
   <netbsd-bugs@netbsd.org>
Subject: Re: pkg/12222: Update for pine and pico
Date: Mon, 19 Feb 2001 18:27:54 +0000 (GMT)

 	Checking the relevant files the only differences in ABI are
 	int -> void function returns (many of them). AFAIK that should be
 	OK...?

 		David/absolute		-- www.netbsd.org: No hype required --


 On Sat, 17 Feb 2001, Todd Vierling wrote:

 > On Sat, 17 Feb 2001, Frederick Bruckman wrote:
 >
 > : > : 	Given the package is a bugfix release would it be more appropriate
 > : > : 	to bump the minor?
 > : >
 > : > Only if you can verify that the ABI hasn't changed.  I assume the worst.
 > :
 > : Why assume the worst?
 >
 > Why assume the best?  Keeping the same major number, if the ABI changes,
 > can cause spectacular (and difficult to diagnose) breakage.
 >
 > : None of the release notes even mentions pico.
 > : It's possible that libpico hasn't changed at all,
 >
 > Then verify that.
 >
 >


From: Todd Vierling <tv@wasabisystems.com>
To: David Brownlee <abs@netbsd.org>
Cc: Frederick Bruckman <fb@enteract.com>, <gnats-bugs@gnats.netbsd.org>,
   <netbsd-bugs@netbsd.org>
Subject: Re: pkg/12222: Update for pine and pico
Date: Mon, 19 Feb 2001 13:35:43 -0500 (Eastern Standard Time)

 On Mon, 19 Feb 2001, David Brownlee wrote:

 : 	Checking the relevant files the only differences in ABI are
 : 	int -> void function returns (many of them). AFAIK that should be
 : 	OK...?

 Then it's not a problem; bump the minor.

 Thanks for checking.  As I said, I've just bumped the major when I haven't
 had the time to check, as only pine depends on the libpico version.  There
 have been real ABI changes, so this is an important thing to check when we
 maintain the shlib's version.

 -- 
 -- Todd Vierling <tv@wasabisystems.com>  *  Wasabi NetBSD:  Run with it.
 -- NetBSD 1.5 now available on CD-ROM  --  http://www.wasabisystems.com/

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.