NetBSD Problem Report #12820

Received: (qmail 17009 invoked from network); 3 May 2001 22:12:38 -0000
Message-Id: <20010503221319.67727129BD@ack.estation.com>
Date: Thu,  3 May 2001 18:13:19 -0400 (EDT)
From: Michael Santos <mike@ethmoid.org>
Reply-To: mike@ethmoid.org
To: gnats-bugs@gnats.netbsd.org
Subject: gensolpkg broken w/ current pkgsrc
X-Send-Pr-Version: 3.95

>Number:         12820
>Category:       pkg
>Synopsis:       Make gensolpkg work with current pkgsrc
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    veego
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu May 03 22:13:02 +0000 2001
>Closed-Date:    Sat May 05 15:55:57 +0000 2001
>Last-Modified:  Sat May 05 15:55:57 +0000 2001
>Originator:     Michael Santos
>Release:        -current
>Organization:

>Environment:

System: NetBSD ack 1.5U NetBSD 1.5U (ack) #16: Sun Apr 29 21:27:55 EDT 2001 root@ack:/amd/ns/root/usr/a/src/sys/arch/i386/compile/ack i386
Architecture: i386
Machine: i386
>Description:

gensolpkg doesn't work after the COMMENT file was integrated into the pkg
Makefile.

>How-To-Repeat:

run gensolpkg w/ current pkgsrc.

>Fix:

--- gensolpkg.c.in.orig	Sun Jan 21 18:32:49 2001
+++ gensolpkg.c.in	Thu May  3 11:17:21 2001
@@ -77,4 +77,5 @@
 static char	pkgarch[16 + 1];		/* Solaris arch name - default "sparc" */
 static char	pkgversion[256 + 1];		/* version number for this package */
+static char	comment[256 + 1];		/* one line descr of pkg */

 static char	prefix[MAXPATHLEN];		/* current prefix */
@@ -212,5 +213,4 @@
 	time_t	t;
 	FILE	*fp;
-	FILE	*comment;
 	char	buf[BUFSIZ];

@@ -226,10 +226,5 @@
 	(void) fprintf(fp, "VERSION=\"%.24s\"\n", pkgversion);
 	(void) fprintf(fp, "CATEGORY=\"%s\"\n", category);
-	if ((comment = fopen("pkg/COMMENT", "r")) == (FILE *) NULL) {
-		(void) fprintf(stderr, "can't open `pkg/COMMENT'\n");
-		return 0;
-	}
-	(void) fgets(buf, sizeof(buf), comment);
-	(void) fclose(comment);
+	(void) fprintf(fp, "COMMENT=\"%s\"\n", comment);
 	(void) fprintf(fp, "DESC=\"%.*s\"\n", strlen(buf) - 1, buf);
 	(void) fprintf(fp, "CLASSES=\"none\"\n");
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->veego 
Responsible-Changed-By: agc 
Responsible-Changed-When: Fri May 4 01:33:33 PDT 2001 
Responsible-Changed-Why:  
Bernd is looking after gensolpkg at the moment. 
State-Changed-From-To: open->feedback 
State-Changed-By: wiz 
State-Changed-When: Sat May 5 02:16:47 PDT 2001 
State-Changed-Why:  
Did you test the change you propose? 
I can't seem to find a code to fill out 'comment' like the other 
variables (around line 580 in gensolpkg.c.in) in your patch, but can't 
test it myself. 
State-Changed-From-To: feedback->closed 
State-Changed-By: veego 
State-Changed-When: Sat May 5 08:55:11 PDT 2001 
State-Changed-Why:  
I applied your patch and added another patch for fill out the 'comment' 
variable. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.