NetBSD Problem Report #1605

From gnats  Mon Oct  9 19:03:08 1995
Received: from eterna.com.au (splode.mame.mu.OZ.AU [128.250.209.121]) by sun-lamp.pc.cs.cmu.edu (8.6.11/8.6.10) with ESMTP id TAA02181 for <gnats-bugs@gnats.netbsd.org>; Mon, 9 Oct 1995 19:02:54 -0400
Message-Id: <199510092302.JAA07527@eterna.com.au>
Date: Tue, 10 Oct 1995 09:02:36 +1000
From: matthew green <mrg@eterna.com.au>
Reply-To: mrg@eterna.com.au
To: gnats-bugs@gnats.netbsd.org
Subject: LKM's are allowed with securelevel > 0
X-Send-Pr-Version: 3.95

>Number:         1605
>Category:       kern
>Synopsis:       LKM's are allowed with securelevel > 0
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 17 14:21:29 +0000 1995
>Closed-Date:    Wed Oct 18 00:29:53 +0000 1995
>Last-Modified:  Wed Oct 18 00:31:22 +0000 1995
>Originator:     matthew green
>Release:        25 sep 1995
>Organization:
bozotic softwar foundation
>Environment:

System: NetBSD splode.eterna.com.au 1.0A NetBSD 1.0A (_splode_) #258: Mon Oct 2 14:43:11 EST 1995 mrg@splode.eterna.com.au:/orb/q/build/src/sys/arch/sparc/compile/_splode_ sparc


>Description:

	lkm's are allowed with securelevel > 0 -- this means an lkm is able to
	lower the securelevel, which means securelevel with LKM is meaningless.
>How-To-Repeat:

	load an lkm with securelevel > 0, see it work.

>Fix:

this patch works for me:

Index: kern_lkm.c
===================================================================
RCS file: /local/cvs/src/sys/kern/kern_lkm.c,v
retrieving revision 1.1.1.4
retrieving revision 1.5
diff -c -r1.1.1.4 -r1.5
*** kern_lkm.c	1995/05/07 16:15:59	1.1.1.4
--- kern_lkm.c	1995/05/08 11:13:21	1.5
***************
*** 188,193 ****
--- 188,196 ----

  	switch(cmd) {
  	case LMRESERV:		/* reserve pages for a module */
+ 		if (securelevel > 0)
+ 			return EPERM;
+ 
  		if ((flag & FWRITE) == 0) /* only allow this if writing */
  			return EPERM;

***************
*** 228,233 ****
--- 231,239 ----
  		break;

  	case LMLOADBUF:		/* Copy in; stateful, follows LMRESERV */
+ 		if (securelevel > 0)
+ 			return EPERM;
+ 
  		if ((flag & FWRITE) == 0) /* only allow this if writing */
  			return EPERM;

***************
*** 261,266 ****
--- 267,275 ----
  		break;

  	case LMUNRESRV:		/* discard reserved pages for a module */
+ 		if (securelevel > 0)
+ 			return EPERM;
+ 
  		if ((flag & FWRITE) == 0) /* only allow this if writing */
  			return EPERM;

***************
*** 271,276 ****
--- 280,288 ----
  		break;

  	case LMREADY:		/* module loaded: call entry */
+ 		if (securelevel > 0)
+ 			return EPERM;
+ 
  		if ((flag & FWRITE) == 0) /* only allow this if writing */
  			return EPERM;

***************
*** 312,317 ****
--- 324,332 ----
  		break;

  	case LMUNLOAD:		/* unload a module */
+ 		if (securelevel > 0)
+ 			return EPERM;
+ 
  		if ((flag & FWRITE) == 0) /* only allow this if writing */
  			return EPERM;

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: thorpej 
State-Changed-When: Tue Oct 17 17:29:53 PDT 1995 
State-Changed-Why:  
I applied this patch before the PR actually appeared. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.