NetBSD Problem Report #16752
Received: (qmail 22614 invoked from network); 11 May 2002 08:41:30 -0000
Message-Id: <20020511084129.73D799EB5@darkstar.local>
Date: Sat, 11 May 2002 10:41:29 +0200 (CEST)
From: jmmv@hispabsd.org
Reply-To: jmmv@hispabsd.org
To: gnats-bugs@gnats.netbsd.org
Subject: New package: audio/grip, 3.0.0
X-Send-Pr-Version: 3.95
>Number: 16752
>Category: pkg
>Synopsis: New package: audio/grip, 3.0.0
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sat May 11 08:42:00 +0000 2002
>Closed-Date: Sat Nov 29 20:28:38 +0000 2003
>Last-Modified: Sat Nov 29 20:28:38 +0000 2003
>Originator: Julio Merino
>Release: NetBSD 1.5ZC
>Organization:
HispaBSD
>Environment:
System: NetBSD darkstar.local 1.5ZC NetBSD 1.5ZC (DARKSTAR) #35: Thu May 9 17:20:43 CEST 2002 juli@darkstar:/home/pub/NetBSD/src/sys/arch/i386/compile/DARKSTAR i386
Architecture: i386
Machine: i386
>Description:
Grip is a graphical frontend for audio extraction and encoding.
This package contains version 3.0.0.
>How-To-Repeat:
>Fix:
cd /usr/pkgsrc
tar xzvf ~/pkgsrc-grip.tar.gz
Get the package from:
http://jmmv.dyndns.org/NetBSD/pkgsrc-grip.tar.gz
>Release-Note:
>Audit-Trail:
From: TAMURA Kent <kent@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: pkg/16752
Date: Tue, 25 Jun 2002 21:54:13 +0900 (JST)
It seems no file.
% http://jmmv.dyndns.org/NetBSD/pkgsrc-grip.tar.gz
Requesting http://jmmv.dyndns.org/NetBSD/pkgsrc-grip.tar.gz
ftp: Error retrieving file - `404 Not Found'
State-Changed-From-To: open->analyzed
State-Changed-By: lukem
State-Changed-When: Fri Jun 28 05:10:03 PDT 2002
State-Changed-Why:
I took a look at this a while ago.
grip didn't work very well unless pth-syscall was used (e.g,
cddb lookup fails wihtout it), and even then, it didn't seem to function
too well.
We may have to hold off until we have decent userland threads
From: Jan Schaumann <jschauma@cs.stevens-tech.edu>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/16752
Date: Tue, 16 Jul 2002 12:11:55 -0400
In addition, there seems to be a problem with the eject/close calls:
- If no cd is in the drive on startup, the tray won't eject.
- If the drive is open, clicking the eject/close button does not close
the tray
I've been poking around that problem, but didn't find a solution: see
http://mail-index.netbsd.org/tech-misc/2002/07/14/0000.html
Furthermore, grip's latest version is 3.0.1, see
http://www.nostatic.org/grip/. I have some patches that make it compile
(mainly addition of "|| defined(__NetBSD__)" wherever there's a "#if
defined(__FreeBSD__)"), but haven't tested the performance due to the
above mentioned problem.
From: Scott Presnell <srp@tworoads.net>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/16752
Date: Tue, 04 Feb 2003 15:49:52 -0800
This is a multi-part message in MIME format.
--------------060902060507000208030900
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Please find enclosed a diff against the source for grip-3.0.5 that
works for me using package versions of:
pth-1.4.1nb6
gnome-libs-1.4.1.4nb2
cdparanoia-3.0.9.8
and NetBSD 1.5.2
use "configure --prefix=/usr/pkg --with-gnome=/usr/pkg"
I'm no good at patching configure source, but with some tweaking
of the generated config.h, this can be made to compile and utilize
the internal grip form of cdparanoia.
The only rough part is the operation of the cdtray: it mostly works,
except that there's no way to know the state of the tray, so if you
start grip with the tray open, you have to click twice to close it.
There's not much I can do to fix this.
Thanks.
- Scott
--------------060902060507000208030900
Content-Type: text/plain;
name="grip305.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="grip305.diff"
Only in src: .libs
Only in src: Makefile
Files src.orig/Makefile.am and src/Makefile.am are identical
Files src.orig/Makefile.in and src/Makefile.in are identical
Only in src: Makefile.sav
diff -rcs src.orig/cddev.c src/cddev.c
*** src.orig/cddev.c Sat Jan 4 11:04:08 2003
--- src/cddev.c Tue Feb 4 14:28:04 2003
***************
*** 52,58 ****
#define NON_BLOCKING
#endif
! #if defined(__FreeBSD__)
#define CDIOREADSUBCHANNEL CDIOCREADSUBCHANNEL
#endif
--- 52,58 ----
#define NON_BLOCKING
#endif
! #if defined(__FreeBSD__) || defined(__NetBSD__)
#define CDIOREADSUBCHANNEL CDIOCREADSUBCHANNEL
#endif
***************
*** 608,626 ****
return FALSE;
}
#ifdef CDIOCEJECT
/* always unlock door before an eject in case something else locked it */
#if defined(CDROM_LOCKDOOR)
if(ioctl(disc->cd_desc,CDROM_LOCKDOOR,0)<0)
! printf(_("Unlock failed: %d"), errno);
#endif
#ifdef CDIOCALLOW
if(ioctl(disc->cd_desc,CDIOCALLOW)<0)
! printf(_("Unlock failed: %d"),errno);
#endif
if(ioctl(disc->cd_desc,CDIOCEJECT)<0) {
! printf(_("CDIOCEJECT"));
return FALSE;
}
#endif
--- 608,628 ----
return FALSE;
}
+ Debug(_("ejecting...\n"));
+
#ifdef CDIOCEJECT
/* always unlock door before an eject in case something else locked it */
#if defined(CDROM_LOCKDOOR)
if(ioctl(disc->cd_desc,CDROM_LOCKDOOR,0)<0)
! printf(_("LOCKDOOR failed: %d\n"), errno);
#endif
#ifdef CDIOCALLOW
if(ioctl(disc->cd_desc,CDIOCALLOW)<0)
! printf(_("ALLOW failed: %d\n"),errno);
#endif
if(ioctl(disc->cd_desc,CDIOCEJECT)<0) {
! printf(_("CDIOCEJECT failed %d\n"), errno);
return FALSE;
}
#endif
***************
*** 628,634 ****
if(ioctl(disc->cd_desc,CDROMEJECT)<0)
return FALSE;
#endif
!
return TRUE;
}
--- 630,636 ----
if(ioctl(disc->cd_desc,CDROMEJECT)<0)
return FALSE;
#endif
!
return TRUE;
}
***************
*** 640,654 ****
return FALSE;
}
#ifdef CDIOCCLOSE
! if(ioctl(disc->cd_desc,CDIOCCLOSE)<0)
return FALSE;
#endif
#ifdef CDROMCLOSETRAY
if(ioctl(disc->cd_desc,CDROMCLOSETRAY)<0)
return FALSE;
#endif
!
return TRUE;
}
--- 642,665 ----
return FALSE;
}
+ Debug(_("door closing...\n"));
+
#ifdef CDIOCCLOSE
! if(ioctl(disc->cd_desc,CDIOCCLOSE)<0) {
! printf(_("Load failed: %d\n"),errno);
return FALSE;
+ }
#endif
+ #ifdef CDIOCPREVENT
+ if(ioctl(disc->cd_desc,CDIOCPREVENT)<0)
+ printf(_("Lock failed: %d\n"),errno);
+ #endif
+
#ifdef CDROMCLOSETRAY
if(ioctl(disc->cd_desc,CDROMCLOSETRAY)<0)
return FALSE;
#endif
!
return TRUE;
}
Files src.orig/cddev.h and src/cddev.h are identical
Only in src: cddev.o
diff -rcs src.orig/cdpar.c src/cdpar.c
*** src.orig/cdpar.c Sat Jan 4 11:04:08 2003
--- src/cdpar.c Tue Feb 4 14:56:24 2003
***************
*** 44,51 ****
--- 44,56 ----
#define size16 short
#define size32 int
+ #if defined(__NetBSD__)
+ #include <cdparanoia/cdda_interface.h>
+ #include <cdparanoia/cdda_paranoia.h>
+ #else
#include <cdda_interface.h>
#include <cdda_paranoia.h>
+ #endif
static void PutNum(long num,int f,int endianness,int bytes);
static void WriteWav(int f,long bytes);
***************
*** 218,226 ****
}
slast=slevel;
}
!
if(slevel<8&&slevel>0) *global_rip_smile_level=slevel-1;
else *global_rip_smile_level=0;
}
/* Do the replay gain calculation on a sector */
--- 223,236 ----
}
slast=slevel;
}
!
if(slevel<8&&slevel>0) *global_rip_smile_level=slevel-1;
else *global_rip_smile_level=0;
+
+ #if defined(__NetBSD__)
+ /* pth uses non-preemtive threads, so give way every once in awhile */
+ pthread_yield_np();
+ #endif
}
/* Do the replay gain calculation on a sector */
Only in src: cdpar.o
diff -rcs src.orig/cdplay.c src/cdplay.c
*** src.orig/cdplay.c Sat Jan 11 11:46:31 2003
--- src/cdplay.c Tue Feb 4 14:13:04 2003
***************
*** 87,93 ****
if(ginfo->looking_up) {
#if defined(__sun__)
pthread_exit(&status);
! #elif defined(__FreeBSD__)
pthread_kill(ginfo->discdb_thread,0);
#else
pthread_kill_other_threads_np();
--- 87,93 ----
if(ginfo->looking_up) {
#if defined(__sun__)
pthread_exit(&status);
! #elif defined(__FreeBSD__) || defined(__NetBSD__)
pthread_kill(ginfo->discdb_thread,0);
#else
pthread_kill_other_threads_np();
***************
*** 1206,1211 ****
--- 1206,1213 ----
ginfo->tray_open=TRUE;
}
else {
+ Debug(_("Don't have disc -- considering loading\n"));
+
if(ginfo->faulty_eject) {
if(ginfo->tray_open) CDClose(&(ginfo->disc));
else CDEject(&(ginfo->disc));
Files src.orig/cdplay.h and src/cdplay.h are identical
Only in src: cdplay.o
Files src.orig/common.h and src/common.h are identical
Files src.orig/cppmain.cc and src/cppmain.cc are identical
Only in src: cppmain.o
Files src.orig/dialog.c and src/dialog.c are identical
Files src.orig/dialog.h and src/dialog.h are identical
Only in src: dialog.o
diff -rcs src.orig/discdb.c src/discdb.c
*** src.orig/discdb.c Sun Jan 5 13:43:59 2003
--- src/discdb.c Tue Jan 28 10:36:58 2003
***************
*** 42,47 ****
--- 42,50 ----
#include "grip_id3.h"
#include "common.h"
#include "config.h"
+ #if defined(__NetBSD__)
+ #include <locale.h>
+ #endif
extern char *Program;
Files src.orig/discdb.h and src/discdb.h are identical
Only in src: discdb.o
Files src.orig/discedit.c and src/discedit.c are identical
Files src.orig/discedit.h and src/discedit.h are identical
Only in src: discedit.o
Files src.orig/gain_analysis.c and src/gain_analysis.c are identical
Files src.orig/gain_analysis.h and src/gain_analysis.h are identical
Only in src: gain_analysis.o
Only in src: grip
diff -rcs src.orig/grip.c src/grip.c
*** src.orig/grip.c Sun Jan 12 10:32:35 2003
--- src/grip.c Tue Feb 4 15:36:01 2003
***************
*** 537,544 ****
#ifdef GRIPCD
if(ginfo->poll_drive && !(secs%ginfo->poll_interval)) {
! if(!ginfo->have_disc)
CheckNewDisc(ginfo,FALSE);
}
if(ginfo->auto_eject_countdown && !(--ginfo->auto_eject_countdown))
--- 537,555 ----
#ifdef GRIPCD
if(ginfo->poll_drive && !(secs%ginfo->poll_interval)) {
! if(!ginfo->have_disc) {
! #if defined(__NetBSD__)
! /*
! * NetBSD invalidates the disklabel and ignores all further
! * requests from the open file handles when the media is
! * changed, so close the file descriptor and force a re-
! * opening of the drive each time we check.
! */
! close(ginfo->disc.cd_desc);
! ginfo->disc.cd_desc = -1;
! #endif
CheckNewDisc(ginfo,FALSE);
+ }
}
if(ginfo->auto_eject_countdown && !(--ginfo->auto_eject_countdown))
***************
*** 550,557 ****
if(!ginfo->ripping_a_disc) {
if(ginfo->poll_drive && !(secs%ginfo->poll_interval)) {
! if(!ginfo->have_disc)
CheckNewDisc(ginfo,FALSE);
}
UpdateDisplay(ginfo);
--- 561,574 ----
if(!ginfo->ripping_a_disc) {
if(ginfo->poll_drive && !(secs%ginfo->poll_interval)) {
! if(!ginfo->have_disc) {
! #if defined(__NetBSD__)
! /* Force a re-opening of the drive each time we check */
! close(ginfo->disc.cd_desc);
! ginfo->disc.cd_desc = -1;
! #endif
CheckNewDisc(ginfo,FALSE);
+ }
}
UpdateDisplay(ginfo);
***************
*** 599,606 ****
--- 616,630 ----
uinfo->id3_genre_item_list=NULL;
+ #if defined(__NetBSD__)
+ /* assumes links to appropriate device files */
+ strcpy(ginfo->cd_device,"/dev/rcdrom");
+ /* For use with internal cdparanoia */
+ strcpy(ginfo->force_scsi,"/dev/rcdrom");
+ #else
strcpy(ginfo->cd_device,"/dev/cdrom");
*ginfo->force_scsi='\0';
+ #endif
ginfo->local_mode=FALSE;
ginfo->have_disc=FALSE;
***************
*** 620,625 ****
--- 644,652 ----
#if defined(__FreeBSD__)
ginfo->poll_drive=FALSE;
ginfo->poll_interval=15;
+ #elif defined(__NetBSD__)
+ ginfo->poll_drive=TRUE;
+ ginfo->poll_interval=15;
#else
ginfo->poll_drive=TRUE;
ginfo->poll_interval=1;
***************
*** 692,700 ****
#endif
ginfo->in_rip_thread=FALSE;
strcpy(ginfo->ripfileformat,"~/mp3/%A/%d/%n.wav");
! #ifdef __linux__
FindExeInPath("cdparanoia", ginfo->ripexename, sizeof(ginfo->ripexename));
strcpy(ginfo->ripcmdline,"-d %c %t:[.%s]-%t:[.%e] %w");
#else
FindExeInPath("cdda2wav", ginfo->ripexename, sizeof(ginfo->ripexename));
#ifdef __sun__
--- 719,731 ----
#endif
ginfo->in_rip_thread=FALSE;
strcpy(ginfo->ripfileformat,"~/mp3/%A/%d/%n.wav");
! #if defined(__linux__) || defined(__FreeBSD__) || defined(__NetBSD__)
FindExeInPath("cdparanoia", ginfo->ripexename, sizeof(ginfo->ripexename));
+ #if defined(__NetBSD__)
+ strcpy(ginfo->ripcmdline,"-g %c %t:[.%s]-%t:[.%e] %w");
+ #else
strcpy(ginfo->ripcmdline,"-d %c %t:[.%s]-%t:[.%e] %w");
+ #endif
#else
FindExeInPath("cdda2wav", ginfo->ripexename, sizeof(ginfo->ripexename));
#ifdef __sun__
diff -rcs src.orig/grip.h src/grip.h
*** src.orig/grip.h Sat Jan 4 11:04:08 2003
--- src/grip.h Tue Jan 28 12:12:40 2003
***************
*** 42,48 ****
#define RRand(range) (random()%(range))
! #if defined(__linux__) || defined(__FreeBSD__) || defined(__osf__) /* __osf__ ?? */
#define MAILER "/usr/sbin/sendmail -i -t"
--- 42,48 ----
#define RRand(range) (random()%(range))
! #if defined(__linux__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__osf__) /* __osf__ ?? */
#define MAILER "/usr/sbin/sendmail -i -t"
Only in src: grip.o
Files src.orig/grip_id3.h and src/grip_id3.h are identical
diff -rcs src.orig/gripcfg.c src/gripcfg.c
*** src.orig/gripcfg.c Sat Jan 4 11:04:08 2003
--- src/gripcfg.c Mon Feb 3 11:09:13 2003
***************
*** 36,41 ****
--- 36,43 ----
#endif
#if defined(__linux__)
{"cdparanoia","-d %c %t:[.%s]-%t:[.%e] %w"},
+ #elif defined(__NetBSD__)
+ {"cdparanoia","-g %c %t:[.%s]-%t:[.%e] %w"},
#endif
#if defined(__sun__)
{"cdda2wav","-x -H -t %t -O wav %w"},
Files src.orig/gripcfg.h and src/gripcfg.h are identical
Only in src: gripcfg.o
Files src.orig/id3.c and src/id3.c are identical
Only in src: id3.o
Files src.orig/launch.c and src/launch.c are identical
Files src.orig/launch.h and src/launch.h are identical
Only in src: launch.o
Files src.orig/main.c and src/main.c are identical
Only in src: main.o
Files src.orig/parsecfg.c and src/parsecfg.c are identical
Files src.orig/parsecfg.h and src/parsecfg.h are identical
Only in src: parsecfg.o
diff -rcs src.orig/rip.c src/rip.c
*** src.orig/rip.c Sat Jan 11 15:00:00 2003
--- src/rip.c Tue Feb 4 15:35:03 2003
***************
*** 27,33 ****
#elif defined (HAVE_SYS_VFS_H)
#include <sys/vfs.h>
#endif
! #if defined(__FreeBSD__)
#include <sys/param.h>
#include <sys/mount.h>
#endif
--- 27,33 ----
#elif defined (HAVE_SYS_VFS_H)
#include <sys/vfs.h>
#endif
! #if defined(__FreeBSD__) || defined(__NetBSD__)
#include <sys/param.h>
#include <sys/mount.h>
#endif
***************
*** 50,57 ****
--- 50,62 ----
#include "gain_analysis.h"
#define size32 gint32
#define size16 gint16
+ #if defined(__NetBSD__)
+ #include <cdparanoia/cdda_interface.h>
+ #include <cdparanoia/cdda_paranoia.h>
+ #else
#include <cdda_interface.h>
#include <cdda_paranoia.h>
+ #endif
extern int rip_smile_level;
#endif
Files src.orig/rip.h and src/rip.h are identical
Only in src: rip.o
Only in src: src.diff
Files src.orig/uihelper.c and src/uihelper.c are identical
Only in src: uihelper.o
Files src.orig/xpm.h and src/xpm.h are identical
--------------060902060507000208030900--
State-Changed-From-To: analyzed->feedback
State-Changed-By: reed
State-Changed-When: Tue Nov 25 07:47:00 UTC 2003
State-Changed-Why:
Asked originator if this can be closed since newer grip is in
pkgsrc-wip.
State-Changed-From-To: feedback->closed
State-Changed-By: reed
State-Changed-When: Sat Nov 29 20:26:57 UTC 2003
State-Changed-Why:
Originator, Julio, said all patches posted in PR are in the wip
package, "so there is no point in keeping the PR."
He said it was okay to close.
Juan RP packaged grip 3.0.7 for pkgsrc-wip.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.