NetBSD Problem Report #16966
Received: (qmail 29936 invoked from network); 22 May 2002 16:06:14 -0000
Message-Id: <20020522160612.128059C17@darkstar.local>
Date: Wed, 22 May 2002 18:06:12 +0200 (CEST)
From: jmmv@hispabsd.org
Reply-To: jmmv@hispabsd.org
To: gnats-bugs@gnats.netbsd.org
Subject: Changed location of shared (conf) files of wm/windowmaker
X-Send-Pr-Version: 3.95
>Number: 16966
>Category: pkg
>Synopsis: Changed location of shared (conf) files of wm/windowmaker
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: jlam
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Wed May 22 16:07:00 +0000 2002
>Closed-Date: Wed Jan 08 19:58:34 +0000 2003
>Last-Modified: Wed Jan 08 19:58:34 +0000 2003
>Originator: Julio Merino
>Release: NetBSD 1.5ZC
>Organization:
HispaBSD
>Environment:
System: NetBSD darkstar.local 1.5ZC NetBSD 1.5ZC (DARKSTAR) #38: Sun May 19 20:12:17 CEST 2002 juli@darkstar.local:/home/pub/NetBSD/src/sys/arch/i386/compile/DARKSTAR i386
Architecture: i386
Machine: i386
>Description:
wm/windowmaker installs several files under pkg/etc/WindowMaker.
Those files are always copied into user's home by wmaker.inst
command, so global settings usually do not matter.
I've moved those files to pkg/share/WindowMaker, which makes
more sense. This solves the problem when using PKG_SYSCONFDIR.
>How-To-Repeat:
>Fix:
The following patch fixes wm/windowmaker:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/wm/windowmaker/Makefile,v
retrieving revision 1.25
diff -u -u -r1.25 Makefile
--- Makefile 2002/03/13 17:37:48 1.25
+++ Makefile 2002/05/22 16:03:14
@@ -2,7 +2,7 @@
DISTNAME= WindowMaker-0.80.0
PKGNAME= windowmaker-0.80.0
-PKGREVISION= 1
+PKGREVISION= 2
CATEGORIES= x11 wm
MASTER_SITES= ftp://ftp.windowmaker.org/pub/source/release/ \
ftp://ftp.ics.es.osaka-u.ac.jp/mirrors/WindowMaker/source/release/
@@ -24,7 +24,8 @@
USE_X11BASE= YES
GNU_CONFIGURE= YES
CONFIGURE_ARGS+= --enable-usermenu \
- --with-nlsdir=${PREFIX}/${PKGLOCALEDIR}/locale
+ --with-nlsdir=${PREFIX}/${PKGLOCALEDIR}/locale \
+ --sysconfdir=${PREFIX}/share
CONFIGURE_ENV+= LINGUAS=yes
INSTALL_TARGET= install-strip
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/wm/windowmaker/PLIST,v
retrieving revision 1.3
diff -u -u -r1.3 PLIST
--- PLIST 2002/02/15 10:13:01 1.3
+++ PLIST 2002/05/22 16:03:15
@@ -89,11 +89,6 @@
bin/wsetfont
bin/wxcopy
bin/wxpaste
-etc/WindowMaker/WMGLOBAL
-etc/WindowMaker/WMRootMenu
-etc/WindowMaker/WMState
-etc/WindowMaker/WMWindowAttributes
-etc/WindowMaker/WindowMaker
include/WINGs/WINGs.h
include/WINGs/WINGsP.h
include/WINGs/WUtil.h
@@ -247,6 +242,11 @@
share/WindowMaker/Themes/OpenStep.style
share/WindowMaker/Themes/Pastel.style
share/WindowMaker/Themes/SteelBlueSilk.style
+share/WindowMaker/WMGLOBAL
+share/WindowMaker/WMRootMenu
+share/WindowMaker/WMState
+share/WindowMaker/WMWindowAttributes
+share/WindowMaker/WindowMaker
share/WindowMaker/autostart.sh
share/WindowMaker/exitscript.sh
share/WindowMaker/menu
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback
State-Changed-By: tron
State-Changed-When: Tue Jun 4 08:56:19 PDT 2002
State-Changed-Why:
Which problem are you actually trying to solve with this patch? The
"windowmaker" package doesn't honor "PKG_SYSCONFDIR" anyway.
Responsible-Changed-From-To: pkg-manager->tron
Responsible-Changed-By: tron
Responsible-Changed-When: Tue Jun 4 08:56:19 PDT 2002
Responsible-Changed-Why:
I'll handle this PR.
Responsible-Changed-From-To: tron->jlam
Responsible-Changed-By: tron
Responsible-Changed-When: Tue Jun 4 09:42:49 PDT 2002
Responsible-Changed-Why:
I can't see the benifit of this change Johnny C. Lam, the maintainer
of this package, does.
State-Changed-From-To: feedback->open
State-Changed-By: wiz
State-Changed-When: Sun Jul 14 13:59:28 PDT 2002
State-Changed-Why:
Not really in feedback state.
State-Changed-From-To: open->analyzed
State-Changed-By: wiz
State-Changed-When: Tue Jul 30 09:03:35 PDT 2002
State-Changed-Why:
The change is not good enough:
wmaker.inst installs too many files.
Also, the PLIST still wants to remove etc/WindowMaker, that should go.
From: Julio Merino <jmmv@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: pr/16966 CVS commit: pkgsrc/wm/windowmaker
Date: Wed, 8 Jan 2003 21:56:35 +0200 (EET)
Module Name: pkgsrc
Committed By: jmmv
Date: Wed Jan 8 19:56:35 UTC 2003
Modified Files:
pkgsrc/wm/windowmaker: Makefile PLIST distinfo
Added Files:
pkgsrc/wm/windowmaker/patches: patch-af
Log Message:
Install configuration files under the examples hierarchy and use
bsd.pkg.install.mk to copy them to PKG_SYSCONFDIR. Bump PKGREVISION to 1.
This closes my own PR pkg/16966 (which proposed a different, wrong change).
To generate a diff of this commit:
cvs rdiff -r1.30 -r1.31 pkgsrc/wm/windowmaker/Makefile
cvs rdiff -r1.7 -r1.8 pkgsrc/wm/windowmaker/PLIST
cvs rdiff -r1.17 -r1.18 pkgsrc/wm/windowmaker/distinfo
cvs rdiff -r0 -r1.3 pkgsrc/wm/windowmaker/patches/patch-af
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: analyzed->closed
State-Changed-By: jmmv
State-Changed-When: Wed Jan 8 11:57:27 PST 2003
State-Changed-Why:
The package now honors PKG_SYSCONFDIR, which is the right solution for
this problem report.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.