NetBSD Problem Report #17249
Received: (qmail 23479 invoked by uid 605); 13 Jun 2002 17:17:09 -0000
Message-Id: <200206131717.g5DHH6g03070@edge.sky.yamashina.kyoto.jp>
Date: Fri, 14 Jun 2002 02:17:06 +0900 (JST)
From: Takahiro Kambe <taca@sky.yamashina.kyoto.jp>
Sender: gnats-bugs-owner@netbsd.org
To: gnats-bugs@gnats.netbsd.org
Subject: /etc/daily sends always /etc/security's actually empty report
X-Send-Pr-Version: 3.95
>Number: 17249
>Category: bin
>Synopsis: /etc/daily sends always /etc/security's actually empty report
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: jhawk
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Thu Jun 13 17:18:00 +0000 2002
>Closed-Date: Sat Feb 22 04:20:05 +0000 2003
>Last-Modified: Sat Feb 22 04:20:05 +0000 2003
>Originator: Takahiro Kambe
>Release: NetBSD 1.6_BETA1
>Organization:
>Environment:
System: NetBSD edge.sky.yamashina.kyoto.jp 1.6_BETA1 NetBSD 1.6_BETA1 (FIVA20X) #145: Sat Jun 8 14:34:16 JST 2002 taca@edge.sky.yamashina.kyoto.jp:/usr/src/sys/arch/i386/compile/FIVA20X i386
Architecture: i386
Machine: i386
>Description:
/etc/daily sends always /etc/security's actually empty report,
which contains "Nothing to report on <date>".
If nothing to report, busy administrator may want to receive
single mail from /etc/daily.
>How-To-Repeat:
>Fix:
With this patch and set always_report_security to "YES",
/etc/daily changes process of /etc/security's outpu.
(1) If /etc/security produce no output, then it print
"Nothing to report on <date>" as its output. So, a single
mail will be sent for /etc/daily.
(2) If /etc/security produce some output, then /etc/daily
process it as before; two mail (/etc/daily and /etc/security)
would be sent.
always_report_security's default value is "NO" and it change
nothing as before.
Index: etc/defaults/daily.conf
===================================================================
retrieving revision 1.1.1.3
retrieving revision 1.1.4.2.2.1
diff -u -r1.1.1.3 -r1.1.4.2.2.1
--- etc/defaults/daily.conf 2002/06/02 11:18:45 1.1.1.3
+++ etc/defaults/daily.conf 2002/06/11 08:14:43 1.1.4.2.2.1
@@ -22,3 +22,4 @@
run_rdist=YES
run_security=YES
run_skeyaudit=YES
+always_report_security=NO
Index: etc/daily
===================================================================
retrieving revision 1.1.1.4
retrieving revision 1.1.1.2.4.1.2.2
diff -u -r1.1.1.4 -r1.1.1.2.4.1.2.2
--- etc/daily 2002/06/02 11:18:22 1.1.1.4
+++ etc/daily 2002/06/11 09:06:33 1.1.1.2.4.1.2.2
@@ -225,12 +213,19 @@
fi
if checkyesno run_security; then
- SECOUT="$DAILYDIR/sec"
- sh /etc/security 2>&1 > "$SECOUT"
- if [ ! -s "$SECOUT" ]; then
- echo "Nothing to report on $date" > "$SECOUT"
+ SECOUT=$TMPDIR/sec
+ sh /etc/security 2>&1 > $SECOUT
+ if [ ! -s $SECOUT ]; then
+ if checkyesno always_report_security; then
+ echo "Nothing to report on $date" > $SECOUT
+ else
+ echo ""
+ echo "Nothing to report about security."
+ fi
+ fi
+ if [ -s $SECOUT ]; then
+ mail -s "$host daily insecurity output for $date" $MAILTO < $SECOUT
fi
- mail -s "$host daily insecurity output for $date" $MAILTO < "$SECOUT"
fi
if checkyesno run_skeyaudit; then
>Release-Note:
>Audit-Trail:
From: John Hawkinson <jhawk@MIT.EDU>
To: gnats-bugs@netbsd.org
Cc:
Subject: security/17249
Date: Wed, 12 Feb 2003 23:25:15 -0500 (EST)
s/TMPDIR/DAILYDIR/ in that patch, I believe.
--jhawk
Responsible-Changed-From-To: bin-bug-people->jhawk
Responsible-Changed-By: jhawk
Responsible-Changed-When: Wed Feb 19 10:55:58 PST 2003
Responsible-Changed-Why:
mine
From: John Hawkinson <jhawk@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: pr/17249 CVS commit: src
Date: Sat, 22 Feb 2003 00:35:48 +0200 (EET)
Module Name: src
Committed By: jhawk
Date: Fri Feb 21 22:35:47 UTC 2003
Modified Files:
src/etc: daily
src/etc/defaults: daily.conf
src/share/man/man5: daily.conf.5
Log Message:
Suppress emailing the daily security report if it is empty, unless
send_empty_security=YES. Implements change-request PR security/17249
from Takahiro Kambe <taca@sky.yamashina.kyoto.jp>.
To generate a diff of this commit:
cvs rdiff -r1.48 -r1.49 src/etc/daily
cvs rdiff -r1.2 -r1.3 src/etc/defaults/daily.conf
cvs rdiff -r1.12 -r1.13 src/share/man/man5/daily.conf.5
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->feedback
State-Changed-By: jhawk
State-Changed-When: Fri Feb 21 14:36:20 PST 2003
State-Changed-Why:
I changed your variable name to make it more clear; look good?
--jhawk
From: Takahiro Kambe <taca@back-street.net>
To: jhawk@netbsd.org
Cc: taca@sky.yamashina.kyoto.jp
Subject: Re: bin/17249
Date: Sat, 22 Feb 2003 08:43:23 +0900 (JST)
In message <20030221223636.25168.qmail@mail.netbsd.org>
on 21 Feb 2003 22:36:36 -0000,
jhawk@netbsd.org wrote:
> Synopsis: /etc/daily sends always /etc/security's actually empty report
>
> State-Changed-From-To: open->feedback
> State-Changed-By: jhawk
> State-Changed-When: Fri Feb 21 14:36:20 PST 2003
> State-Changed-Why:
> I changed your variable name to make it more clear; look good?
Fine. please close this PR now.
--
Takahiro Kambe <taca@back-street.net>
State-Changed-From-To: feedback->closed
State-Changed-By: jhawk
State-Changed-When: Fri Feb 21 20:19:47 PST 2003
State-Changed-Why:
Fixed & approved by submitter.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.