NetBSD Problem Report #17394

Received: (qmail 14616 invoked by uid 605); 25 Jun 2002 20:59:42 -0000
Message-Id: <20020625205939.E1289AC@proven.weird.com>
Date: Tue, 25 Jun 2002 16:59:39 -0400 (EDT)
From: woods@weird.com (Greg A. Woods)
Sender: gnats-bugs-owner@netbsd.org
Reply-To: woods@planix.com (Greg A. Woods)
To: gnats-bugs@gnats.netbsd.org
Subject: a DEBUG printf() in UVM is too terse
X-Send-Pr-Version: 3.95

>Number:         17394
>Category:       kern
>Synopsis:       a DEBUG printf() in UVM is too terse
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 25 21:00:00 +0000 2002
>Closed-Date:    Sun May 04 01:54:57 +0000 2003
>Last-Modified:  Sun May 04 01:55:00 +0000 2003
>Originator:     Greg A. Woods
>Release:        NetBSD-current 2002/06/24
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD
>Description:

	a DEBUG printf() in UVM uses the overloaded term "comm"

	(I'm not sure this should be a DEBUG printf -- maybe it should
	be logged at some medium level such as LOG_NOTICE?)

>How-To-Repeat:

	search for other confusing uses of "comm" in kernel messages...

>Fix:

Index: uvm_mmap.c
===================================================================
RCS file: /cvs/master/m-NetBSD/main/syssrc/sys/uvm/uvm_mmap.c,v
retrieving revision 1.63
diff -c -c -r1.63 uvm_mmap.c
*** uvm_mmap.c	22 Mar 2002 11:06:33 -0000	1.63
--- uvm_mmap.c	25 Jun 2002 20:56:37 -0000
***************
*** 395,401 ****
  		if ((flags & (MAP_SHARED|MAP_PRIVATE)) == 0) {
  #if defined(DEBUG)
  			printf("WARNING: defaulted mmap() share type to "
! 			   "%s (pid %d comm %s)\n", vp->v_type == VCHR ?
  			   "MAP_SHARED" : "MAP_PRIVATE", p->p_pid,
  			    p->p_comm);
  #endif
--- 395,401 ----
  		if ((flags & (MAP_SHARED|MAP_PRIVATE)) == 0) {
  #if defined(DEBUG)
  			printf("WARNING: defaulted mmap() share type to "
! 			   "%s (pid %d, commmand %s)\n", vp->v_type == VCHR ?
  			   "MAP_SHARED" : "MAP_PRIVATE", p->p_pid,
  			    p->p_comm);
  #endif
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: gmcgarry 
State-Changed-When: Sun May 4 01:54:37 UTC 2003 
State-Changed-Why:  
applied. 

From: Gregory McGarry <gmcgarry@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: pr/17394 CVS commit: src/sys/uvm
Date: Sun,  4 May 2003 01:54:27 +0000 (UTC)

 Module Name:	src
 Committed By:	gmcgarry
 Date:		Sun May  4 01:54:26 UTC 2003

 Modified Files:
 	src/sys/uvm: uvm_mmap.c

 Log Message:
 Don't use overloaded term "comm".  From Greg A. Woods in PR#17394.


 To generate a diff of this commit:
 cvs rdiff -r1.70 -r1.71 src/sys/uvm/uvm_mmap.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.