NetBSD Problem Report #17705

Received: (qmail 13917 invoked by uid 605); 24 Jul 2002 15:29:56 -0000
Message-Id: <200207241531.g6OFVQT06927@darkstar.local>
Date: Wed, 24 Jul 2002 17:31:26 +0200 (CEST)
From: Julio Merino <jmmv@hispabsd.org>
Sender: gnats-bugs-owner@netbsd.org
Reply-To: jmmv@hispabsd.org
To: gnats-bugs@gnats.netbsd.org
Subject: gkrellm's buildlink has wrong named macro
X-Send-Pr-Version: 3.95

>Number:         17705
>Category:       pkg
>Synopsis:       gkrellm's buildlink has wrong named macro
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    he
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 24 15:30:01 +0000 2002
>Closed-Date:    Wed Jul 24 17:43:43 +0000 2002
>Last-Modified:  Wed Jul 24 17:45:00 +0000 2002
>Originator:     Julio Merino
>Release:        NetBSD 1.6D
>Organization:
HispaBSD
>Environment:


System: NetBSD darkstar.local 1.6D NetBSD 1.6D (DARKSTAR) #0: Mon Jul 22 12:44:12 CEST 2002 jmmv@darkstar.local:/var/build/kernel/DARKSTAR i386
Architecture: i386
Machine: i386
>Description:
	The buildlink.mk file of sysutils/gkrellm uses a macro named
	_BUILDLINK_MK. This is incorrect as it does not specify to which
	package it belongs. This could cause conflicts if some other package
	has such misnamed variable.
>How-To-Repeat:

>Fix:

Index: buildlink.mk
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/sysutils/gkrellm/buildlink.mk,v
retrieving revision 1.1
diff -u -u -r1.1 buildlink.mk
--- buildlink.mk	2002/07/13 15:38:15	1.1
+++ buildlink.mk	2002/07/24 15:27:51
@@ -12,8 +12,8 @@
 # (4) Add ${BUILDLINK_DIR}/lib to the front of the linker's library search
 #     path.

-.if !defined(_BUILDLINK_MK)
-_BUILDLINK_MK=	# defined
+.if !defined(GKRELLM_BUILDLINK_MK)
+GKRELLM_BUILDLINK_MK=	# defined

 .include "../../mk/bsd.buildlink.mk"

@@ -29,6 +29,6 @@
 BUILDLINK_TARGETS+=		${BUILDLINK_TARGETS.gkrellm}

 pre-configure: ${BUILDLINK_TARGETS}
-gkrellm-buildlink: _BUILDLINK_USE
+gkrellm-buildlink: GKRELLM_BUILDLINK_USE

-.endif	# _BUILDLINK_MK
+.endif	# GKRELLM_BUILDLINK_MK
>Release-Note:
>Audit-Trail:

From: Julio Merino <jmmv@hispabsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:  
Subject: Re: pkg/17705
Date: Wed, 24 Jul 2002 17:36:44 +0200

 The above patch contains an error, sorry. Here is the right one.


 Index: buildlink.mk
 ===================================================================
 RCS file: /pub/NetBSD-CVS/pkgsrc/sysutils/gkrellm/buildlink.mk,v
 retrieving revision 1.1
 diff -u -u -r1.1 buildlink.mk
 --- buildlink.mk	2002/07/13 15:38:15	1.1
 +++ buildlink.mk	2002/07/24 15:33:30
 @@ -12,8 +12,8 @@
  # (4) Add ${BUILDLINK_DIR}/lib to the front of the linker's library search
  #     path.

 -.if !defined(_BUILDLINK_MK)
 -_BUILDLINK_MK=	# defined
 +.if !defined(GKRELLM_BUILDLINK_MK)
 +GKRELLM_BUILDLINK_MK=	# defined

  .include "../../mk/bsd.buildlink.mk"

 @@ -31,4 +31,4 @@
  pre-configure: ${BUILDLINK_TARGETS}
  gkrellm-buildlink: _BUILDLINK_USE

 -.endif	# _BUILDLINK_MK
 +.endif	# GKRELLM_BUILDLINK_MK

State-Changed-From-To: open->feedback 
State-Changed-By: he 
State-Changed-When: Wed Jul 24 10:25:09 PDT 2002 
State-Changed-Why:  
Fix from last of the submitted patches applied, 
I assume this fixes the problem? 


Responsible-Changed-From-To: pkg-manager->he 
Responsible-Changed-By: he 
Responsible-Changed-When: Wed Jul 24 10:25:09 PDT 2002 
Responsible-Changed-Why:  
I'll handle this PR. 

From: Julio Merino <jmmv@hispabsd.org>
To: he@netbsd.org
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/17705
Date: Wed, 24 Jul 2002 19:35:23 +0200

 Yes, the last patch fixes the problem.

 -- 
 HispaBSD admin - http://www.hispabsd.org
 Julio Merino <jmmv@hispabsd.org>
State-Changed-From-To: feedback->closed 
State-Changed-By: he 
State-Changed-When: Wed Jul 24 10:43:21 PDT 2002 
State-Changed-Why:  
PR submitter confirms this fixes the problem. 

From: Havard Eidnes <he@netbsd.org>
To: jmmv@hispabsd.org
Cc: gnats-bugs@gnats.netbsd.org
Subject: Re: pkg/17705
Date: Wed, 24 Jul 2002 19:44:01 +0200 (CEST)

 > Yes, the last patch fixes the problem.

 OK, thanks; closing the PR.

 - H=E5vard
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.