NetBSD Problem Report #18134
Received: (qmail 22517 invoked by uid 605); 31 Aug 2002 00:02:48 -0000
Message-Id: <20020831000245.51E6011122@narn.netbsd.org>
Date: Fri, 30 Aug 2002 17:02:45 -0700 (PDT)
From: c.prevotaux@hexanet.fr
Sender: gnats-bugs-owner@netbsd.org
Reply-To: c.prevotaux@hexanet.fr
To: gnats-bugs@gnats.netbsd.org
Subject: rsync-2.5.5 package does not bind to IPv4 port when used in daemon mode
X-Send-Pr-Version: www-1.0
>Number: 18134
>Category: pkg
>Synopsis: rsync-2.5.5 package does not bind to IPv4 port when used in daemon mode
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: salo
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Aug 31 00:03:00 +0000 2002
>Closed-Date: Sat Jul 12 00:18:38 +0000 2003
>Last-Modified: Thu Apr 20 13:48:51 +0000 2006
>Originator: Christophe Prevotaux
>Release: 1.5.2
>Organization:
Hexanet SARL
>Environment:
NetBSD zippy.hexanet.fr 1.5.2 NetBSD 1.5.2 (ZIPPY) #4: Wed Jan 16 23:04:45 CET 2002 nighty@zippy.hexanet.fr:/usr/src/sys/arch/i386/compile/ZIPPY i386
>Description:
The pkg rsync-2.5.5 does not bind to a IPv4 port (it binds only to an IPv6 port)
when used with rsync --daemon, making it impossible to use rsync as rsync server under
NetBSD 1.5.2
>How-To-Repeat:
just compile the pkg and try rsync --daemon then do a netstat -a
and search for the rsync port in the IPv4 port list , you'll find.... nothing
>Fix:
>Release-Note:
>Audit-Trail:
From: itojun@iijlab.net
To: Thomas Klausner <wiz@danbala.ifoer.tuwien.ac.at>
Cc: gnats-bugs@netbsd.org
Subject: Re: pkg/18134
Date: Mon, 30 Sep 2002 13:38:55 +0900
>Could you please take a look at pkg/18134 [rsync-2.5.5 package does
>not bind to IPv4 port when used in daemon mode]?
i think it should be reported to original authors of rsync.
rsync --daemon should listen to both AF_INET and AF_INET6 port.
itojun
Responsible-Changed-From-To: pkg-manager->wiz
Responsible-Changed-By: darcy
Responsible-Changed-When: Sun Feb 16 10:51:55 PST 2003
Responsible-Changed-Why:
I notice that itojun sent you email regarding this but I am not sure why.
Do you want to follow up with the rsync people like he suggested? How about
making the suggestion and then closing the PR since we will then have done
anything we can on this issue?
Date: Mon, 17 Feb 2003 10:28:44 +0100
From: Thomas Klausner <wiz@danbala.ifoer.tuwien.ac.at>
Sender: gnats-bugs-owner@netbsd.org
Message-Id: <20030217092844.GL21476@danbala.tuwien.ac.at>
To: gnats-bugs@netbsd.org
Cc: itojun@netbsd.org, darcy@netbsd.org
Subject: PR 18134
I sent the following mail to the rsync list in September, but didn't
get a reply.
What should we do about it?
Thomas
From: Thomas Klausner <wiz@danbala.tuwien.ac.at>
Subject: rsync --daemon only binding against IPv6
To: rsync@lists.samba.org
Date: Mon, 30 Sep 2002 14:57:09 +0200
Hi!
We (NetBSD pkgsrc) got the following bug report:
http://www.NetBSD.org/cgi-bin/query-pr-single.pl?number=18134
In short, it says that rsync-2.5.5 does not bind to a IPv4 port (it
binds only to an IPv6 port) when used with rsync --daemon, making it
impossible to use rsync as rsync server under NetBSD 1.5.2
Any hints on this one?
Also, one patch we have in pkgsrc seems not to have been included in
the distribution yet. It is attached. It was added to pkgsrc with the
following comment:
The arithmetic here must be ordered so that type promotions (s->n is
unsigned) do not cause a false match.
Bye,
Thomas
--
Thomas Klausner - wiz@danbala.ifoer.tuwien.ac.at
Main Rule of Usenet: Never argue with idiots. They drag you down to
their level, then beat you with experience.
$NetBSD: patch-aa,v 1.8 2002/03/12 16:02:57 tron Exp $
--- match.c.orig Sun Feb 3 02:38:39 2002
+++ match.c Tue Mar 12 16:55:19 2002
@@ -247,7 +247,7 @@
running match, the checksum update and the
literal send. */
if (offset > last_match &&
- offset-last_match >= CHUNK_SIZE+s->n &&
+ offset >= last_match+CHUNK_SIZE+s->n &&
(end-offset > CHUNK_SIZE)) {
matched(f,s,buf,offset - s->n, -2);
}
----------
--
Thomas Klausner - wiz@danbala.ifoer.tuwien.ac.at
What is wanted is not the will to believe, but the will to find
out, which is the exact opposite. -- Bertrand Russell
Date: Tue, 18 Feb 2003 16:09:18 +0900
From: itojun@iijlab.net
Sender: gnats-bugs-owner@netbsd.org
Message-Id: <20030218070918.894CE4B23@coconut.itojun.org>
To: Thomas Klausner <wiz@danbala.ifoer.tuwien.ac.at>
Cc: gnats-bugs@netbsd.org, darcy@netbsd.org
In-Reply-To: <20030217092844.GL21476@danbala.tuwien.ac.at>
Subject: Re: PR 18134
rsync should really select/listen to multiple sockets returned by
getaddrinfo(AI_PASSIVE).
itojun
Date: Tue, 18 Feb 2003 08:19:46 +0100
From: Thomas Klausner <wiz@danbala.ifoer.tuwien.ac.at>
Sender: gnats-bugs-owner@netbsd.org
Message-Id: <20030218071946.GV21476@danbala.tuwien.ac.at>
To: itojun@iijlab.net
Cc: gnats-bugs@netbsd.org, darcy@netbsd.org
In-Reply-To: <20030218070918.894CE4B23@coconut.itojun.org>
Subject: Re: PR 18134
References: <20030217092844.GL21476@danbala.tuwien.ac.at> <20030218070918.894CE4B23@coconut.itojun.org>
Can you patch it?
Thomas
--
Thomas Klausner - wiz@danbala.ifoer.tuwien.ac.at
What is wanted is not the will to believe, but the will to find
out, which is the exact opposite. -- Bertrand Russell
Responsible-Changed-From-To: wiz->salo
Responsible-Changed-By: wiz
Responsible-Changed-When: Thu Apr 10 10:44:39 PDT 2003
Responsible-Changed-Why:
Salo expressed interest in this one.
From: Lubomir Sedlacik <salo@netbsd.org>
To: gnats-bugs@gnats.netbsd.org
Cc:
Subject: pr/18134 CVS commit: pkgsrc/net/rsync
Date: Fri, 11 Apr 2003 06:56:07 +0300 (EEST)
Module Name: pkgsrc
Committed By: salo
Date: Fri Apr 11 03:56:06 UTC 2003
Modified Files:
pkgsrc/net/rsync: Makefile distinfo
Added Files:
pkgsrc/net/rsync/patches: patch-af
Log Message:
Bump PKGREVISION: Fix binding in --daemon mode.
Addresses PR pkg/18134.
Patch by itojun.
To generate a diff of this commit:
cvs rdiff -r1.45 -r1.46 pkgsrc/net/rsync/Makefile
cvs rdiff -r1.10 -r1.11 pkgsrc/net/rsync/distinfo
cvs rdiff -r0 -r1.3 pkgsrc/net/rsync/patches/patch-af
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->feedback
State-Changed-By: salo
State-Changed-When: Thu Apr 10 20:59:17 PDT 2003
State-Changed-Why:
Could you please try the 2.5.6nb1 version with a patch from itojun?
it seemed to work just fine for me.
tcp 0 0 *.rsync *.* LISTEN
tcp6 0 0 *.rsync *.* LISTEN
my tests with few files succeeded using both -4 and -6.
State-Changed-From-To: feedback->closed
State-Changed-By: salo
State-Changed-When: Sat Jul 12 00:17:30 UTC 2003
State-Changed-Why:
no reply in 3 months and the issue is fixed.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.